Hemant Agrawal [Tue, 19 Dec 2017 10:14:38 +0000 (15:44 +0530)]
license: introduce SPDX identifiers
The DPDK uses the Open Source BSD-3-Clause license for the core libraries
and drivers. The kernel components are naturally GPLv2 licensed.
Many of the files in the DPDK source code contain the full text of the
applicable license. For example, most of the BSD-3-Clause files contain a
full copy of the BSD-3-Clause license text.
Including big blocks of License headers in all files blows up the source
code with mostly redundant information. An additional problem is that even
the same licenses are referred to by a number of slightly varying text
blocks (full, abbreviated, different indentation, line wrapping and/or
white space, with obsolete address information, ...) which makes validation
and automatic processing a nightmare.
To make this easier, DPDK uses of a single line reference to
Unique License Identifiers in source files as defined by the Linux
Foundation's SPDX project https://spdk.org.
Adding license information in this fashion, rather than adding full license
text, can be more efficient for developers; decreases errors; and improves
automated detection of licenses. The current set of valid, predefined SPDX
identifiers is set forth on the SPDX License List at
https://spdx.org/licenses/.
For example, to label a file as subject to the BSD-3-Clause license,
the following text would be used as the top line of the file.
SPDX-License-Identifier: BSD-3-Clause
Note: Any new file contributions in DPDK shall adhere to the above scheme.
It is also recommended to replace or at least amend the existing license
text in the code with SPDX-License-Identifiers.
Any exception to DPDK IP policies shall be approved by DPDK tech board and
DPDK Governing Board. Steps for any exception approval:
1. Mention the appropriate license identifier form SPDX. If the license is
not listed in SPDX Licenses. It is the submitters responsibiliity to get
it first listed.
2. Get the required approval from the DPDK Technical Board. Technical board
may advise the author to check alternate means first. If no other
alternatives are found and the merit of the contributions are important
for DPDK's mission, it may decide on such exception with two-thirds vote
of the members.
3. Technical board then approach Governing board for such limited approval
for the given contribution only.
Any approvals shall be documented in "licenses/exceptions.txt" with record
dates.
Note: From the legal point of view, this patch is supposed to be only a
change to the textual representation of the license information, but in no
way any change to the actual license terms. With this patch applied, all
files will still be licensed under the same terms they were before.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Ferruh Yigit [Sat, 16 Dec 2017 02:22:41 +0000 (02:22 +0000)]
devtools: add git log checks for SCTP and IOVA
Acronyms must be uppercase.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Olivier Matz [Thu, 14 Dec 2017 14:21:40 +0000 (15:21 +0100)]
devtools: enhance error message in get maintainer script
When the DPDK_GETMAINTAINER_PATH variable was not set, the error
message from get-maintainer.sh was quite cheap:
$ devtools/get-maintainer.sh --help
usage: get-maintainer.sh <patch>
Cannot execute DPDK_GETMAINTAINER_PATH
Add a more detailed explanation about this variable in the help.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tiwei Bie [Fri, 1 Dec 2017 11:04:35 +0000 (19:04 +0800)]
maintainers: claim responsibility for virtio PMD
Add myself as co-maintainer for virtio driver.
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Jingjing Wu [Mon, 4 Dec 2017 06:15:51 +0000 (14:15 +0800)]
maintainers: update for i40e
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
Tomasz Duszynski [Thu, 14 Dec 2017 09:43:58 +0000 (10:43 +0100)]
maintainers: update mrvl crypto
Fix typo in email address.
Fixes:
8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Jingjing Wu [Mon, 4 Dec 2017 06:18:26 +0000 (14:18 +0800)]
maintainers: update for testpmd
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
Marko Kovacevic [Tue, 5 Dec 2017 15:22:07 +0000 (15:22 +0000)]
maintainers: claim co-maintainership of docs
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Sergio Gonzalez Monroy [Mon, 18 Dec 2017 14:02:06 +0000 (14:02 +0000)]
maintainers: resign from maintenance
I will not be directly working on the DPDK project anymore.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ferruh Yigit [Fri, 22 Dec 2017 02:13:16 +0000 (02:13 +0000)]
bus/dpaa: fix build when assert enabled
Enabling CONFIG_RTE_ENABLE_ASSERT cause build error because some fields
protected by RTE_LIBRTE_DPAA_HWDEBUG macro accessed within DPAA_ASSERT.
All DPAA_ASSERT macro usage causing the build error wrapped with
RTE_LIBRTE_DPAA_HWDEBUG macro.
Fixes:
f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces")
Fixes:
c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Ilya V. Matveychikov [Sun, 19 Nov 2017 08:18:49 +0000 (12:18 +0400)]
eal: update assertion macro
Update RTE_VERIFY macro to make it possible to use complex expressions
in RTE_ASSERT.
Now it’s possible to have % char inside the expression, for example:
RTE_ASSERT((sizeof(some_struct) % 64) == 0)
Before the patch, “%" sign acts like a conversion specification
beginning character.
Fixes:
148f963fb532 ("xen: core library changes")
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit [Fri, 15 Dec 2017 23:09:49 +0000 (23:09 +0000)]
mk: remove TILE-Gx machine type
This file was forgotten when removing TILE-Gx arch.
Fixes:
31123211bd27 ("remove unmaintained TILE-Gx architecture")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Stephen Hemminger [Tue, 26 Sep 2017 07:17:12 +0000 (08:17 +0100)]
doc: update oldest supported kernel in Linux guide
The DPDK needs to stay up to date with current LTS Linux kernel support.
If the kernel is older than LTS it is likely to be insecure and buggy.
Therefore only require DPDK to work on oldest LTS kernel.
If distribution vendors want to support DPDK on older kernels, that is
their choice. But the upstream source does not need to be cluttered
with support for this.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Timothy Redaelli [Fri, 17 Nov 2017 14:40:17 +0000 (15:40 +0100)]
app/testpmd: remove xenvirt again
The xenvirt PMD was removed from 17.11
while this link parameter was added.
Fixes:
5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
Cc: stable@dpdk.org
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
Acked-by: Luca Boccassi <bluca@debian.org>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Ferruh Yigit [Tue, 28 Nov 2017 23:45:53 +0000 (23:45 +0000)]
kni: fix build with kernel 4.15
build error:
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2809:2:
error: implicit declaration of function ‘setup_timer’;
did you mean ‘sk_stop_timer’? [-Werror=implicit-function-declaration]
setup_timer(&adapter->watchdog_timer, &igb_watchdog,
^~~~~~~~~~~
sk_stop_timer
cc1: all warnings being treated as errors
error observed whed CONFIG_RTE_KNI_KMOD_ETHTOOL config option enabled.
Because Linux removed setup_timer macros for kernel version >= 4.15
Linux:
513ae785c63c ("timer: Remove setup_*timer() interface")
Replaced setup_timer with timer_setup for new kernel versions.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon [Thu, 23 Nov 2017 22:33:52 +0000 (23:33 +0100)]
version: 18.02-rc0
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
John McNamara [Wed, 22 Nov 2017 17:38:21 +0000 (17:38 +0000)]
doc: add template release notes for 18.02
Add template release notes for DPDK 18.02 with inline
comments and explanations of the various sections.
Signed-off-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon [Wed, 15 Nov 2017 00:24:53 +0000 (01:24 +0100)]
version: 17.11.0
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Wed, 15 Nov 2017 17:54:07 +0000 (18:54 +0100)]
doc: fix GSO guide as PDF
The PDF cannot be built because of some images integration being
forced as SVG. They are converted for PDF format, so the extension
must be a wildcard in the RST file.
Fixes:
f6010c7655cc ("doc: add GSO programmer's guide")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Shahaf Shuler [Wed, 15 Nov 2017 07:09:49 +0000 (09:09 +0200)]
net/mlx5: fix flow mark action on port start
Mark action flag was not set on the flow, causing the rx burst function
after port start to ignore the flow mark.
Fixes:
8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Thomas Monjalon [Wed, 15 Nov 2017 00:42:24 +0000 (01:42 +0100)]
maintainers: move NXP bus drivers in related section
A bus maintainers section has been introduced in 17.11.
Let's move all bus drivers in the same place.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Wed, 15 Nov 2017 00:35:34 +0000 (01:35 +0100)]
doc: add bus libraries to release notes
Fixes:
919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
Fixes:
7e7df6d0a41d ("bus/fslmc: introduce fsl-mc bus driver")
Fixes:
c752998b5e2e ("pci: introduce library and driver")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
John McNamara [Fri, 3 Nov 2017 15:24:23 +0000 (15:24 +0000)]
doc: announce behaviour change to i40e RSS
Add deprecation notice to highlight a future change in the
default configuration behavior for flexible payload for RSS.
Signed-off-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Andrey Chilikin <andrey.chilikin@intel.com>
Maria Lingemark [Tue, 14 Nov 2017 08:04:24 +0000 (09:04 +0100)]
pdump: fix typo in error log
Fixes:
278f945402c5 ("pdump: add new library for packet capture")
Signed-off-by: Maria Lingemark <maria.lingemark@ericsson.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ilya V. Matveychikov [Fri, 10 Nov 2017 13:56:43 +0000 (16:56 +0300)]
mbuf: fix segments number type increase
Update types of variables to correspond to nb_segs type change from
uint8_t to uint16_t.
Fixes:
97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
Cc: stable@dpdk.org
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Andrew Rybchenko [Tue, 14 Nov 2017 11:32:35 +0000 (11:32 +0000)]
net/sfc: avoid Tx queue setup failure if thresholds are set
Tx queue prefetch, host and writeback thresholds are used for
performance fine-tuning and not applicable to Solarflare NICs.
It is safe to just log warning and do not fail Tx queue setup
to be more friendly to DPDK applications which hardcode it.
Fixes:
b1b7ad933b39 ("net/sfc: set up and release Tx queues")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Andrew Rybchenko [Tue, 14 Nov 2017 11:32:34 +0000 (11:32 +0000)]
net/sfc: avoid Rx queue setup failure if thresholds are set
Rx queue prefetch, host and writeback thresholds are used for
performance fine-tuning and not applicable to Solarflare NICs.
It is safe to just log warning and do not fail Rx queue setup
to be more friendly to DPDK applications which hardcode it.
Fixes:
ce35b05c635e ("net/sfc: implement Rx queue setup release operations")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Thierry Herbelot [Tue, 14 Nov 2017 13:52:44 +0000 (14:52 +0100)]
net/mlx5: fix build without soft counters
total_length is only visible when SOFT_COUNTERS are enabled
Fixes:
3f13f8c23a7c ("net/mlx5: support hardware TSO")
Cc: stable@dpdk.org
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Nelio Laranjeiro [Mon, 13 Nov 2017 10:25:16 +0000 (11:25 +0100)]
net/mlx5: fix flow director deletion
The specification are wrongly computed causing the rule to not be match
correctly for deletion.
Fixes:
4c3e9bcdd52e ("net/mlx5: support flow director")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thomas Monjalon [Mon, 13 Nov 2017 05:40:50 +0000 (06:40 +0100)]
version: 17.11-rc4
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Raslan Darawsheh [Sun, 12 Nov 2017 14:27:01 +0000 (16:27 +0200)]
doc: add tested platforms with Mellanox NICs
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Rami Rosen [Sat, 28 Oct 2017 03:36:53 +0000 (06:36 +0300)]
doc: fix a typo in EAL guide
Fix an error in DPDK programmer's guide (EAL section):
it should be rte_thread_get_affinity() instead of
rte_pthread_get_affinity().
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Rami Rosen [Sat, 28 Oct 2017 07:57:51 +0000 (10:57 +0300)]
doc: fix a typo in pipeline app guide
This patch fixes a trivial typo in ip pipeline app guide.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Pavel Shirshov [Fri, 10 Nov 2017 08:21:48 +0000 (00:21 -0800)]
usertools: fix a typo in bind script
Signed-off-by: Pavel Shirshov <pavel.shirshov@gmail.com>
Pavel Shirshov [Fri, 10 Nov 2017 08:24:23 +0000 (00:24 -0800)]
lib: fix typos
Signed-off-by: Pavel Shirshov <pavel.shirshov@gmail.com>
Jerin Jacob [Sun, 12 Nov 2017 07:56:58 +0000 (13:26 +0530)]
bus/pci: fix a typo in doxygen file description
Fixes:
764bf26873b9 ("add FreeBSD support")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Pengzhen Liu [Fri, 27 Oct 2017 03:54:09 +0000 (11:54 +0800)]
net/virtio: fix memory leak on failure
In function eth_virtio_dev_init(), dynamic memory stored
in "eth_dev->data->mac_addrs" variable and it is not freed
when function return,
this is a possible memory leak.
Fixes:
8ced1542f7a3 ("net/virtio: eth_dev->data->mac_addrs is not freed")
Cc: stable@dpdk.org
Signed-off-by: Pengzhen Liu <liupengzhen3@huawei.com>
Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Jia He [Fri, 10 Nov 2017 03:30:42 +0000 (03:30 +0000)]
ring: guarantee load/load order in enqueue and dequeue
We watched a rte panic of mbuf_autotest in our qualcomm arm64 server
(Amberwing).
Root cause:
In __rte_ring_move_cons_head()
...
do {
/* Restore n as it may change every loop */
n = max;
*old_head = r->cons.head; //1st load
const uint32_t prod_tail = r->prod.tail; //2nd load
In weak memory order architectures (powerpc,arm), the 2nd load might be
reodered before the 1st load, that makes *entries is bigger than we wanted.
This nasty reording messed enque/deque up.
cpu1(producer) cpu2(consumer) cpu3(consumer)
load r->prod.tail
in enqueue:
load r->cons.tail
load r->prod.head
store r->prod.tail
load r->cons.head
load r->prod.tail
...
store r->cons.{head,tail}
load r->cons.head
Then, r->cons.head will be bigger than prod_tail, then make *entries very
big and the consumer will go forward incorrectly.
After this patch, the old cons.head will be recaculated after failure of
rte_atomic32_cmpset
There is no such issue on X86, because X86 is strong memory order model.
But rte_smp_rmb() doesn't have impact on runtime performance on X86, so
keep the same code without architectures specific concerns.
Fixes:
50d769054872 ("ring: add burst API")
Cc: stable@dpdk.org
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Signed-off-by: Jie Liu <jie2.liu@hxt-semitech.com>
Signed-off-by: Bing Zhao <bing.zhao@hxt-semitech.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
Pablo de Lara [Tue, 24 Oct 2017 09:55:54 +0000 (10:55 +0100)]
maintainers: update PTP client example
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Pablo de Lara [Tue, 24 Oct 2017 09:56:44 +0000 (10:56 +0100)]
maintainers: update job stats library
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Xiao Wang [Wed, 25 Oct 2017 11:22:54 +0000 (04:22 -0700)]
maintainers: update for fm10k
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
Nelio Laranjeiro [Fri, 3 Nov 2017 10:04:46 +0000 (11:04 +0100)]
maintainers: resign from mlx4 maintenance
I have been a little too busy these past months and could not follow all
the re-work of this PMD.
So the best thing for this PMD would be to move the mlx4 maintenance to
more involved people.
Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Jianfeng Tan [Wed, 8 Nov 2017 01:07:59 +0000 (01:07 +0000)]
maintainers: claim maintainership of VDEV bus
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
Thomas Monjalon [Mon, 6 Nov 2017 11:36:51 +0000 (12:36 +0100)]
maintainers: fill git trees for net and crypto API
The ethdev API (including rte_flow) is managed in the dpdk-next-net tree.
The crypto API is managed in the dpdk-next-crypto tree.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Luca Boccassi [Tue, 31 Oct 2017 16:28:55 +0000 (16:28 +0000)]
doc: mention 17.11 LTS in contributing guide
Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Bruce Richardson [Mon, 6 Nov 2017 11:28:06 +0000 (11:28 +0000)]
doc: update API/ABI policy
Following agreement at the DPDK Technical Board meeting of 2017-10-13 [1],
update the documentation with the ABI/API policy changes.
[1] http://dpdk.org/ml/archives/dev/2017-October/079961.html
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Shahaf Shuler [Tue, 17 Oct 2017 14:24:14 +0000 (17:24 +0300)]
doc: update deprecation of ethdev offload API
Update deprecation notice for the new ethdev offloads API.
Deprecation of the old offloads API is set to 18.05.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Gaetan Rivet [Wed, 8 Nov 2017 09:53:27 +0000 (10:53 +0100)]
doc: postpone devargs clean-up
These changes were planned for 17.11 but were proposed too late.
Postpone those to v18.02 instead.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
John McNamara [Fri, 10 Nov 2017 12:27:15 +0000 (12:27 +0000)]
doc: update release notes for 17.11
Fix grammar, spelling and formatting of DPDK 17.11 release notes.
Signed-off-by: John McNamara <john.mcnamara@intel.com>
Yulong Pei [Thu, 9 Nov 2017 06:40:15 +0000 (14:40 +0800)]
doc: add tested Intel platforms with Intel NICs
Add tested Intel platforms with Intel NICs to the release note.
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Santosh Shukla [Tue, 7 Nov 2017 06:59:34 +0000 (12:29 +0530)]
doc: fix mempool option in octeontx guide
Fixes:
f820b5896631 ("doc: add octeontx ethdev driver documentation")
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Santosh Shukla [Tue, 7 Nov 2017 06:59:33 +0000 (12:29 +0530)]
doc: add octeontx mempool guide
This commit adds a section to the docs listing the mempool
device PMDs available.
It then adds the octeontx fpavf mempool PMD to the listed mempool
devices.
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Santosh Shukla [Tue, 7 Nov 2017 06:59:32 +0000 (12:29 +0530)]
doc: add octeontx platform guide
This commit adds a section to the docs listing the platform
guide for the PMDs.
It then adds the octeontx platform guide to the listed platform
devices.
Patch also removes platform specific duplicate setup information from
eventdev/octeontx.rst, nics/octeontx.rst and update to
plaform/octeontx.rst.
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Moti Haimovsky [Thu, 9 Nov 2017 17:30:56 +0000 (19:30 +0200)]
doc: update mlx4 documentation
This updates mlx4 documentation and DPDK release notes
to reflect the PMD support for rdma-core from linux-rdma.
- PMD is now freed from Mellanox OFED and now only depends on the
public rdma-core package (v15 and above) instead.
(see https://github.com/linux-rdma/rdma-core/releases)
This PMD should run under Linux v4.14 and above.
- In case any of the above requirements can't be satisfied,
Mellanox OFED v4.2 and above also provide an updated rdma-core
as well back-ported kernel modules for most Linux distributions
and previous Linux versions.
(see http://www.mellanox.com/page/products_dyn?product_family=26).
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Moti Haimovsky [Thu, 9 Nov 2017 17:30:55 +0000 (19:30 +0200)]
doc: remove mlx4 Rx inline support
This commit removes the stale MLX4_INLINE_RECV_SIZE environment
variable from the documentation.
Fixes:
056eaf2e6d55 ("net/mlx4: drop inline receive support")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Moti Haimovsky [Thu, 9 Nov 2017 17:30:54 +0000 (19:30 +0200)]
doc: remove mlx4 Tx inline compilation option
This patch removes the stale CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE compilation
option from the documentation.
Fixes:
586db080585b ("net/mlx4: remove Tx inline compilation option")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Radu Nicolau [Thu, 9 Nov 2017 12:29:42 +0000 (12:29 +0000)]
doc: add inline crypto feature
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Thomas Monjalon [Wed, 8 Nov 2017 20:44:10 +0000 (21:44 +0100)]
doc: move fast mbuf free feature in net guide
The feature was added at the end of the table.
And the description was between the anchor _nic_features_timesync
and its title.
It is moved near related features with a new anchor.
It is also renamed from "mbuf fast free" to "fast mbuf free".
Fixes:
d6f90afd3070 ("ethdev: add mbuf fast free Tx offload")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ilya V. Matveychikov [Fri, 10 Nov 2017 13:55:16 +0000 (16:55 +0300)]
pdump: fix possible mbuf leak on failure
If pdump_pktmbuf_copy_data() fails it's possible to have segment leak
as rte_pktmbuf_free() only handles m_dup chain but not the seg just
allocated and yet not chained.
Fixes:
278f945402c5 ("pdump: add new library for packet capture")
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
Ilya V. Matveychikov [Fri, 10 Nov 2017 13:57:25 +0000 (16:57 +0300)]
examples/ipv4_multicast: fix segments number type
Fixes:
97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
Radoslaw Biernacki [Thu, 9 Nov 2017 18:14:32 +0000 (19:14 +0100)]
test/memory: fix autotest parsing
This patch fixes three problems in memory autotest:
- the regex for IOVA
- missing validation of second and following output lines
- propagation of error to consecutive tests
- conversion base for mem size (hex indtead of dec)
First fix is for changes introduced with IOVA, the regex was not
updated which lead to unit test failure. Patch now also uses loop for
line outputs processing to verify more than just one line. By this we
also satisfy the pexpect() and scan the "Test OK"/"Test Failed" so in
case of error all output lines are consumed and does not break the
consecutive test (error does not propagate).
Fixes:
7ba49d39f14c ("mem: rename segment address from physical to IOVA")
Fixes:
b4ce15aa2bc7 ("app/test: fix memory autotest")
Signed-off-by: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
Radoslaw Biernacki [Wed, 8 Nov 2017 12:33:14 +0000 (13:33 +0100)]
test/memzone: fix memory leak
This patch fixes the memory leaks in memzone_autotest. Those memory leaks
lead to failures in tests from the same testing group due to out of memory
problems. With introduction of rte_memzone_free() it is now possible to
free the memzone. Fix uses this API call to make a clean after each test
case.
Fixes:
ff909fe21f0a ("mem: introduce memzone freeing")
Cc: stable@dpdk.org
Signed-off-by: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
Jasvinder Singh [Fri, 10 Nov 2017 10:30:49 +0000 (10:30 +0000)]
app/testpmd: remove port status check from TM command
Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when
port is started. It doesn't work in case of i40e device as DCB
configuration is deleted when port is stopped. Therefore, removes the
port status check before invoking leaf and nonleaf node API in the cli.
If needed, device can add port status check at the driver layer.
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Jerin Jacob [Wed, 8 Nov 2017 07:04:55 +0000 (12:34 +0530)]
eal: fix an include guard comment
Fixes:
af75078fece3 ("first public release")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Zhiyong Yang [Thu, 9 Nov 2017 09:21:24 +0000 (17:21 +0800)]
net/virtio: fix Rx interrupt with VFIO
When running l3fwd-power to test virtio rxq interrupt using vfio
pci noiommu mode, startup fails. In the function virtio_read_caps,
the code if (flags & PCI_MSIX_ENABLE) intends to double check
if vfio msix is enabled or not. However, it is not enable at that
time. So use_msix is assigned to "0", not "1", which causes the
failure of configuring rxq intr in l3fwd-power.
This patch adds the function "vtpci_msix_detect" to detect the status
of msix when interrupt changes happen.
In the meanwhile, virtio_intr_enable/disable are introduced to wrap
rte_intr_enable/disable to enhance the ability to detect msix.
use_msix can indicate three different msix status by:
VIRTIO_MSIX_NONE (0)
VIRTIO_MSIX_DISABLED (1)
VIRTIO_MSIX_ENABLED (2)
Fixes:
cb482cb3a305 ("net/virtio: fix MAC address read")
Cc: stable@dpdk.org
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Edward Makarov [Fri, 10 Nov 2017 14:18:04 +0000 (14:18 +0000)]
net/mlx5: fix link speed bitmasks
The constant ETHTOOL_LINK_MODE_1000baseT_Full_BIT and the others like
that in mlx5_link_update_unlocked_gs must be bit masks but unfortunately
they are bit numbers. This commit fixes the issue.
Fixes:
188408719888 ("net/mlx5: fix support for newer link speeds")
Cc: stable@dpdk.org
Signed-off-by: Edward Makarov <makarov@kraftway.ru>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Matan Azrad [Fri, 10 Nov 2017 08:27:18 +0000 (08:27 +0000)]
net/mlx4: fix missing stamp during Tx completion
After processing completed packets, the owner bit of each TXBB comprised
in its WQEs must be invalidated. The loop stops short of processing the
last WQE.
Fixes:
c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs")
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Ajit Khaparde [Thu, 9 Nov 2017 17:46:28 +0000 (11:46 -0600)]
net/bnxt: fix link handling and configuration
Remove a case where we were sending a deprecated field to the FW.
There is no need to send auto_link_speed to the FW.
Also set the auto_mode correctly depending on the setting requested.
Fixes:
7bc8e9a227cc ("net/bnxt: support async link notification")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Thu, 9 Nov 2017 17:46:27 +0000 (11:46 -0600)]
net/bnxt: fix duplicate creation of ntuple filter
Prevent the creation of duplicate 5tuple filters.
Fixes:
b7435d660a8c ("net/bnxt: add ntuple filtering support")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Alejandro Lucero [Wed, 8 Nov 2017 14:42:23 +0000 (14:42 +0000)]
net/nfp: fix possible memory leak
Memory allocated was not being released in any exit path.
Coverity issue: 195030
Fixes:
48e2255f1b63 ("net/nfp: add NSP support for HW link configuration")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 14:36:32 +0000 (14:36 +0000)]
net/nfp: fix null pointer check
First, the received pointer was not checked before. Then the pointer
from malloc was not the one used in the existing check.
Coverity issue: 195027
Fixes:
ad60bca34899 ("net/nfp: read PF port MAC addr using NSP")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 12:28:11 +0000 (12:28 +0000)]
net/nfp: fix possible bad shif operation
We do not know how big can the BAR be, but we know anything less
than 1MB is an error. This BAR needs to be big enough for accessing
most of NFP internals.
Coverity issue: 195024
Fixes:
d12206e00590 ("net/nfp: add NSP user space interface")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 12:19:48 +0000 (12:19 +0000)]
net/nfp: fix checking function return value
The fstat function could return a value that indicates an error condition.
If this is not checked, the error condition may not be handled correctly.
Coverity issue: 195019
Fixes:
f37d8a4b67b2 ("net/nfp: add NSP FW upload command")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 12:14:13 +0000 (12:14 +0000)]
net/nfp: fix resource leak
File descriptor is not released in any potential exit path
inside the function.
Coverity issue: 195018
Fixes:
f37d8a4b67b2 ("net/nfp: add NSP FW upload command")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 12:07:14 +0000 (12:07 +0000)]
net/nfp: fix memory allocation
If the function actually returns a null value, a null pointer
dereference will occur.
Coverity issue: 195013
Fixes:
dd63df2bfff3 ("net/nfp: add NSP symbol resolution command")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Alejandro Lucero [Wed, 8 Nov 2017 11:59:45 +0000 (11:59 +0000)]
net/nfp: fix stats struct initial value
Not all struct fields will be written and random data could
confuse readers.
Coverity issue: 140755
Fixes:
92aa491b881e ("nfp: add statistics")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Ilya V. Matveychikov [Thu, 9 Nov 2017 13:54:09 +0000 (17:54 +0400)]
drivers/net: fix number of segment storage type
Fixes:
97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
Cc: stable@dpdk.org
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Shahaf Shuler [Thu, 9 Nov 2017 13:50:49 +0000 (15:50 +0200)]
net/mlx4: fix rxq interrupt memory corruption
intr_vec allocation size was wrong causing a memory corruption.
Fixes:
0a2ae703192c ("net/mlx4: fix Rx interrupts management")
Cc: stable@dpdk.org
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Shahaf Shuler [Thu, 9 Nov 2017 13:10:14 +0000 (15:10 +0200)]
net/mlx5: fix rxq interrupt memory corruption
intr_vec allocation size was wrong causing a memory corruption.
Fixes:
e1016cb73383 ("net/mlx5: fix Rx interrupts management")
Cc: stable@dpdk.org
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Nélio Laranjeiro [Thu, 9 Nov 2017 12:43:06 +0000 (13:43 +0100)]
net/mlx5: fix flow director rules comparison
When deleting/replacing a flow director rule the first rule of the list
was always the one replaced instead of the corresponding one.
Fixes:
4c3e9bcdd52e ("net/mlx5: support flow director")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Harish Patil [Thu, 9 Nov 2017 06:52:20 +0000 (22:52 -0800)]
net/qede: fix default config option
Restore the default configuration as in previous releases and
add a debug msg.
Fixes:
f07aa795c92a ("net/qede: disable per-VF Tx switching feature")
Cc: stable@dpdk.org
Signed-off-by: Harish Patil <harish.patil@cavium.com>
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Thu, 9 Nov 2017 06:52:19 +0000 (22:52 -0800)]
doc: update qede PMD NIC guide
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Moti Haimovsky [Thu, 9 Nov 2017 08:59:33 +0000 (10:59 +0200)]
net/mlx4: fix Rx packet type offloads
This patch improves Rx packet type offload report in case the device is
a virtual function device.
In these devices we observed that the L2 tunnel flag is set also for
non-tunneled packets, this leads to a complete misinterpretation of the
packet type being received.
This issue occurs since the tunnel_mode is not set to 0x7 by the driver
for virtual devices and therefore the value in the L2 tunnel flag is
meaningless and should be ignored.
Fixes:
aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Xiaoyun Li [Thu, 9 Nov 2017 06:30:14 +0000 (14:30 +0800)]
net/i40e: fix VF cannot forward packets issue
When Rx interrupt is not enabled, there is no need to check if interrupt
allow others. It will cause VF cannot forwarding packets issue. This patch
fixes this issue.
Fixes:
96a9fd03c25f ("net/i40e: fix Rx queue interrupt mapping in VF")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
Akhil Goyal [Thu, 9 Nov 2017 12:23:57 +0000 (17:53 +0530)]
security: fix anonymous unions in structure definitions
Fixes:
c261d1431bd8 ("security: introduce security API and framework")
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Radu Nicolau [Thu, 9 Nov 2017 09:57:21 +0000 (09:57 +0000)]
examples/ipsec-secgw: fix build with gcc 4.5.1
On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:
examples/ipsec-secgw/ipsec.c:87:4 error:
unknown field ‘ipsec’ specified in initializer
Fixes:
ec17993a145a ("examples/ipsec-secgw: support security offload")
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Shijith Thotton [Wed, 8 Nov 2017 12:04:07 +0000 (17:34 +0530)]
net/liquidio: support device reset in driver
Reset device during init and close if bound to igb_uio.
Fixes:
369db3ae8e91 ("igb_uio: remove device reset in release")
Cc: stable@dpdk.org
Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Jasvinder Singh [Wed, 8 Nov 2017 10:25:08 +0000 (10:25 +0000)]
net/softnic: fix build with gcc 4.5.1
Fix the build error due to improper handling of unions
on SUSE11 (gcc 4.5.1).
drivers/net/softnic/rte_eth_softnic_tm.c:588:3
error: unknown field 'nonleaf' specified in initializer
Fixes:
299a89de916a ("net/softnic: add TM capabilities ops")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon [Wed, 8 Nov 2017 01:51:44 +0000 (02:51 +0100)]
version: 17.11-rc3
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Mon, 6 Nov 2017 14:40:54 +0000 (15:40 +0100)]
doc: adjust column width of PMD overview tables
The net PMD overview table is big and required to be shrunk.
The crypto PMD tables had variable column sizes: the latest
columns were smaller.
The minimum width is set to 0.9em without any forced padding.
The maximum width is set to 2em.
The width of the first column set by sphinx is overridden to 0
for full elasticity.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon [Mon, 6 Nov 2017 14:45:29 +0000 (15:45 +0100)]
doc: move dom0 removal notice in removed items
Since the release notes has a new section for removed items,
the dom0 removal notice can be moved there.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Shreyansh Jain [Thu, 26 Oct 2017 14:25:58 +0000 (19:55 +0530)]
doc: add DPAA2 event adapter to release notes
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked by: Nipun Gupta <nipun.gupta@nxp.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Akhil Goyal [Tue, 7 Nov 2017 06:44:28 +0000 (12:14 +0530)]
doc: add security library to release notes
Removed the deprication notice for ABI breakage and updated
release notes for rte_security.
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Pablo de Lara [Tue, 7 Nov 2017 09:55:56 +0000 (09:55 +0000)]
doc: update IPsec multi-buffer library version
A new library of the IPsec Multi-buffer library has been
released (0.47), which is used by the AESNI GCM PMD.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Rami Rosen [Sun, 29 Oct 2017 13:24:44 +0000 (15:24 +0200)]
doc: fix a typo in EAL guide
This patch fixes a trivial typo in DPDK programmer's guide:
it should be rte_cpu_get_features() instead of rte_cpu_get_feature().
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Ferruh Yigit [Tue, 7 Nov 2017 23:38:11 +0000 (23:38 +0000)]
net/qede: fix icc build
observed icc version "icc (ICC) 18.0.0
20170811"
build error:
.../dpdk/drivers/net/qede/qede_ethdev.c(1475):
error #279: controlling expression is constant
assert(false && "Unable to start periodic timer");
^
Warning disabled in Makefile.
Fixes:
2af14ca79c0a ("net/qede: support 100G")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Rasesh Mody [Tue, 7 Nov 2017 08:34:25 +0000 (00:34 -0800)]
net/qede: fix null pointer dereferences
Fix null pointer dereferences in qede_vxlan_enable() and
qede_conf_udp_dst_port()
Coverity issue: 195010, 195012, 198439
Fixes:
e0947ed912f7 ("net/qede: add support for VXLAN UDP port config over VF")
Fixes:
739a5b2f2b49 ("net/qede/base: use passed ptt handler")
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Tue, 7 Nov 2017 08:34:24 +0000 (00:34 -0800)]
net/qede/base: fix division by zero
Fix division by zero in calculating the regpair elements per page
Remove unused API ecore_cxt_free_proto_ilt()
Coverity issue:
1379423,
1379428
Fixes:
22d07d939c3c ("net/qede/base: update")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Tue, 7 Nov 2017 08:34:23 +0000 (00:34 -0800)]
net/qede/base: fix return code init of filter functions
Fix for uninitialized scalar variable for filter APIs
Coverity issue:
1445717,
1445718,
1445721,
1445722
Fixes:
2e2f392b249a ("net/qede/base: upgrade the FW to 8.20.0.0")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Tue, 7 Nov 2017 08:34:22 +0000 (00:34 -0800)]
net/qede: fix PF translation table release
Appropriately release the ptt[PF translation table] handler that is
acquired in error case
Fixes:
e0947ed912f7 ("net/qede: add support for VXLAN UDP port config over VF")
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>