ethdev: increase port id range
[dpdk.git] / drivers / net / bonding / rte_eth_bond_8023ad.c
index a2313b3..c1873aa 100644 (file)
@@ -44,7 +44,6 @@
 #include "rte_eth_bond_private.h"
 
 static void bond_mode_8023ad_ext_periodic_cb(void *arg);
-
 #ifdef RTE_LIBRTE_BOND_DEBUG_8023AD
 #define MODE4_DEBUG(fmt, ...) RTE_LOG(DEBUG, PMD, "%6u [Port %u: %s] " fmt, \
                        bond_dbg_get_time_diff_ms(), slave_id, \
@@ -210,7 +209,7 @@ set_warning_flags(struct port *port, uint16_t flags)
 }
 
 static void
-show_warnings(uint8_t slave_id)
+show_warnings(uint16_t slave_id)
 {
        struct port *port = &mode_8023ad_ports[slave_id];
        uint8_t warnings;
@@ -279,7 +278,7 @@ record_default(struct port *port)
  * @param port                 Port on which LACPDU was received.
  */
 static void
-rx_machine(struct bond_dev_private *internals, uint8_t slave_id,
+rx_machine(struct bond_dev_private *internals, uint16_t slave_id,
                struct lacpdu *lacp)
 {
        struct port *agg, *port = &mode_8023ad_ports[slave_id];
@@ -400,7 +399,7 @@ rx_machine(struct bond_dev_private *internals, uint8_t slave_id,
  * @param port                 Port to handle state machine.
  */
 static void
-periodic_machine(struct bond_dev_private *internals, uint8_t slave_id)
+periodic_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
        struct port *port = &mode_8023ad_ports[slave_id];
        /* Calculate if either site is LACP enabled */
@@ -462,7 +461,7 @@ periodic_machine(struct bond_dev_private *internals, uint8_t slave_id)
  * @param port                 Port to handle state machine.
  */
 static void
-mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
+mux_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
        struct port *port = &mode_8023ad_ports[slave_id];
 
@@ -565,7 +564,7 @@ mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
  * @param port
  */
 static void
-tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
+tx_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
        struct port *agg, *port = &mode_8023ad_ports[slave_id];
 
@@ -660,6 +659,25 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
        SM_FLAG_CLR(port, NTT);
 }
 
+static uint8_t
+max_index(uint64_t *a, int n)
+{
+       if (n <= 0)
+               return -1;
+
+       int i, max_i = 0;
+       uint64_t max = a[0];
+
+       for (i = 1; i < n; ++i) {
+               if (a[i] > max) {
+                       max = a[i];
+                       max_i = i;
+               }
+       }
+
+       return max_i;
+}
+
 /**
  * Function assigns port to aggregator.
  *
@@ -670,8 +688,13 @@ static void
 selection_logic(struct bond_dev_private *internals, uint8_t slave_id)
 {
        struct port *agg, *port;
-       uint8_t slaves_count, new_agg_id, i;
-       uint8_t *slaves;
+       uint16_t slaves_count, new_agg_id, i, j = 0;
+       uint16_t *slaves;
+       uint64_t agg_bandwidth[8] = {0};
+       uint64_t agg_count[8] = {0};
+       uint16_t default_slave = 0;
+       uint8_t mode_count_id, mode_band_id;
+       struct rte_eth_link link_info;
 
        slaves = internals->active_slaves;
        slaves_count = internals->active_slave_count;
@@ -684,6 +707,10 @@ selection_logic(struct bond_dev_private *internals, uint8_t slave_id)
                if (agg->aggregator_port_id != slaves[i])
                        continue;
 
+               agg_count[agg->aggregator_port_id] += 1;
+               rte_eth_link_get_nowait(slaves[i], &link_info);
+               agg_bandwidth[agg->aggregator_port_id] += link_info.link_speed;
+
                /* Actors system ID is not checked since all slave device have the same
                 * ID (MAC address). */
                if ((agg->actor.key == port->actor.key &&
@@ -694,15 +721,36 @@ selection_logic(struct bond_dev_private *internals, uint8_t slave_id)
                        (agg->actor.key &
                                rte_cpu_to_be_16(BOND_LINK_FULL_DUPLEX_KEY)) != 0) {
 
-                       break;
+                       if (j == 0)
+                               default_slave = i;
+                       j++;
                }
        }
 
-       /* By default, port uses it self as agregator */
-       if (i == slaves_count)
-               new_agg_id = slave_id;
-       else
-               new_agg_id = slaves[i];
+       switch (internals->mode4.agg_selection) {
+       case AGG_COUNT:
+               mode_count_id = max_index(
+                               (uint64_t *)agg_count, slaves_count);
+               new_agg_id = mode_count_id;
+               break;
+       case AGG_BANDWIDTH:
+               mode_band_id = max_index(
+                               (uint64_t *)agg_bandwidth, slaves_count);
+               new_agg_id = mode_band_id;
+               break;
+       case AGG_STABLE:
+               if (default_slave == slaves_count)
+                       new_agg_id = slave_id;
+               else
+                       new_agg_id = slaves[default_slave];
+               break;
+       default:
+               if (default_slave == slaves_count)
+                       new_agg_id = slave_id;
+               else
+                       new_agg_id = slaves[default_slave];
+               break;
+       }
 
        if (new_agg_id != port->aggregator_port_id) {
                port->aggregator_port_id = new_agg_id;
@@ -875,7 +923,8 @@ bond_mode_8023ad_periodic_cb(void *arg)
 }
 
 void
-bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
+bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,
+                               uint16_t slave_id)
 {
        struct bond_dev_private *internals = bond_dev->data->dev_private;
 
@@ -903,13 +952,13 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
        memcpy(&port->actor, &initial, sizeof(struct port_params));
        /* Standard requires that port ID must be grater than 0.
         * Add 1 do get corresponding port_number */
-       port->actor.port_number = rte_cpu_to_be_16((uint16_t)slave_id + 1);
+       port->actor.port_number = rte_cpu_to_be_16(slave_id + 1);
 
        memcpy(&port->partner, &initial, sizeof(struct port_params));
 
        /* default states */
        port->actor_state = STATE_AGGREGATION | STATE_LACP_ACTIVE | STATE_DEFAULTED;
-       port->partner_state = STATE_LACP_ACTIVE;
+       port->partner_state = STATE_LACP_ACTIVE | STATE_AGGREGATION;
        port->sm_flags = SM_FLAGS_BEGIN;
 
        /* use this port as agregator */
@@ -974,12 +1023,12 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 
 int
 bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev,
-               uint8_t slave_id)
+               uint16_t slave_id)
 {
        struct bond_dev_private *internals = bond_dev->data->dev_private;
        void *pkt = NULL;
        struct port *port;
-       uint8_t i;
+       uint16_t i;
 
        /* Given slave must be in active list */
        RTE_ASSERT(find_slave_by_id(internals->active_slaves,
@@ -1018,7 +1067,7 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev)
        struct bond_dev_private *internals = bond_dev->data->dev_private;
        struct ether_addr slave_addr;
        struct port *slave, *agg_slave;
-       uint8_t slave_id, i, j;
+       uint16_t slave_id, i, j;
 
        bond_mode_8023ad_stop(bond_dev);
 
@@ -1063,17 +1112,8 @@ bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
        conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks;
        conf->update_timeout_ms = mode4->update_timeout_us / 1000;
        conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks;
-}
-
-static void
-bond_mode_8023ad_conf_get_v1607(struct rte_eth_dev *dev,
-               struct rte_eth_bond_8023ad_conf *conf)
-{
-       struct bond_dev_private *internals = dev->data->dev_private;
-       struct mode8023ad_private *mode4 = &internals->mode4;
-
-       bond_mode_8023ad_conf_get(dev, conf);
        conf->slowrx_cb = mode4->slowrx_cb;
+       conf->agg_selection = mode4->agg_selection;
 }
 
 static void
@@ -1088,6 +1128,7 @@ bond_mode_8023ad_conf_get_default(struct rte_eth_bond_8023ad_conf *conf)
        conf->rx_marker_period_ms = BOND_8023AD_RX_MARKER_PERIOD_MS;
        conf->update_timeout_ms = BOND_MODE_8023AX_UPDATE_TIMEOUT_MS;
        conf->slowrx_cb = NULL;
+       conf->agg_selection = AGG_STABLE;
 }
 
 static void
@@ -1110,27 +1151,6 @@ bond_mode_8023ad_conf_assign(struct mode8023ad_private *mode4,
        mode4->dedicated_queues.tx_qid = UINT16_MAX;
 }
 
-static void
-bond_mode_8023ad_setup_v20(struct rte_eth_dev *dev,
-               struct rte_eth_bond_8023ad_conf *conf)
-{
-       struct rte_eth_bond_8023ad_conf def_conf;
-       struct bond_dev_private *internals = dev->data->dev_private;
-       struct mode8023ad_private *mode4 = &internals->mode4;
-
-       if (conf == NULL) {
-               conf = &def_conf;
-               bond_mode_8023ad_conf_get_default(conf);
-       }
-
-       bond_mode_8023ad_stop(dev);
-       bond_mode_8023ad_conf_assign(mode4, conf);
-
-       if (dev->data->dev_started)
-               bond_mode_8023ad_start(dev);
-}
-
-
 void
 bond_mode_8023ad_setup(struct rte_eth_dev *dev,
                struct rte_eth_bond_8023ad_conf *conf)
@@ -1147,6 +1167,7 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev,
        bond_mode_8023ad_stop(dev);
        bond_mode_8023ad_conf_assign(mode4, conf);
        mode4->slowrx_cb = conf->slowrx_cb;
+       mode4->agg_selection = AGG_STABLE;
 
        if (dev->data->dev_started)
                bond_mode_8023ad_start(dev);
@@ -1194,7 +1215,7 @@ bond_mode_8023ad_stop(struct rte_eth_dev *bond_dev)
 
 void
 bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
-       uint8_t slave_id, struct rte_mbuf *pkt)
+                                 uint16_t slave_id, struct rte_mbuf *pkt)
 {
        struct mode8023ad_private *mode4 = &internals->mode4;
        struct port *port = &mode_8023ad_ports[slave_id];
@@ -1275,7 +1296,7 @@ free_out:
 }
 
 int
-rte_eth_bond_8023ad_conf_get_v20(uint8_t port_id,
+rte_eth_bond_8023ad_conf_get(uint16_t port_id,
                struct rte_eth_bond_8023ad_conf *conf)
 {
        struct rte_eth_dev *bond_dev;
@@ -1290,31 +1311,52 @@ rte_eth_bond_8023ad_conf_get_v20(uint8_t port_id,
        bond_mode_8023ad_conf_get(bond_dev, conf);
        return 0;
 }
-VERSION_SYMBOL(rte_eth_bond_8023ad_conf_get, _v20, 2.0);
 
 int
-rte_eth_bond_8023ad_conf_get_v1607(uint8_t port_id,
-               struct rte_eth_bond_8023ad_conf *conf)
+rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id,
+               enum rte_bond_8023ad_agg_selection agg_selection)
 {
        struct rte_eth_dev *bond_dev;
+       struct bond_dev_private *internals;
+       struct mode8023ad_private *mode4;
+
+       bond_dev = &rte_eth_devices[port_id];
+       internals = bond_dev->data->dev_private;
 
        if (valid_bonded_port_id(port_id) != 0)
                return -EINVAL;
-
-       if (conf == NULL)
+       if (internals->mode != 4)
                return -EINVAL;
 
-       bond_dev = &rte_eth_devices[port_id];
-       bond_mode_8023ad_conf_get_v1607(bond_dev, conf);
+       mode4 = &internals->mode4;
+       if (agg_selection == AGG_COUNT || agg_selection == AGG_BANDWIDTH
+                       || agg_selection == AGG_STABLE)
+               mode4->agg_selection = agg_selection;
        return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_eth_bond_8023ad_conf_get, _v1607, 16.07);
-MAP_STATIC_SYMBOL(int rte_eth_bond_8023ad_conf_get(uint8_t port_id,
-               struct rte_eth_bond_8023ad_conf *conf),
-               rte_eth_bond_8023ad_conf_get_v1607);
+
+int rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id)
+{
+       struct rte_eth_dev *bond_dev;
+       struct bond_dev_private *internals;
+       struct mode8023ad_private *mode4;
+
+       bond_dev = &rte_eth_devices[port_id];
+       internals = bond_dev->data->dev_private;
+
+       if (valid_bonded_port_id(port_id) != 0)
+               return -EINVAL;
+       if (internals->mode != 4)
+               return -EINVAL;
+       mode4 = &internals->mode4;
+
+       return mode4->agg_selection;
+}
+
+
 
 static int
-bond_8023ad_setup_validate(uint8_t port_id,
+bond_8023ad_setup_validate(uint16_t port_id,
                struct rte_eth_bond_8023ad_conf *conf)
 {
        if (valid_bonded_port_id(port_id) != 0)
@@ -1338,8 +1380,9 @@ bond_8023ad_setup_validate(uint8_t port_id,
        return 0;
 }
 
+
 int
-rte_eth_bond_8023ad_setup_v20(uint8_t port_id,
+rte_eth_bond_8023ad_setup(uint16_t port_id,
                struct rte_eth_bond_8023ad_conf *conf)
 {
        struct rte_eth_dev *bond_dev;
@@ -1350,35 +1393,17 @@ rte_eth_bond_8023ad_setup_v20(uint8_t port_id,
                return err;
 
        bond_dev = &rte_eth_devices[port_id];
-       bond_mode_8023ad_setup_v20(bond_dev, conf);
+       bond_mode_8023ad_setup(bond_dev, conf);
 
        return 0;
 }
-VERSION_SYMBOL(rte_eth_bond_8023ad_setup, _v20, 2.0);
 
-int
-rte_eth_bond_8023ad_setup_v1607(uint8_t port_id,
-               struct rte_eth_bond_8023ad_conf *conf)
-{
-       struct rte_eth_dev *bond_dev;
-       int err;
 
-       err = bond_8023ad_setup_validate(port_id, conf);
-       if (err != 0)
-               return err;
 
-       bond_dev = &rte_eth_devices[port_id];
-       bond_mode_8023ad_setup(bond_dev, conf);
 
-       return 0;
-}
-BIND_DEFAULT_SYMBOL(rte_eth_bond_8023ad_setup, _v1607, 16.07);
-MAP_STATIC_SYMBOL(int rte_eth_bond_8023ad_setup(uint8_t port_id,
-               struct rte_eth_bond_8023ad_conf *conf),
-               rte_eth_bond_8023ad_setup_v1607);
 
 int
-rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
+rte_eth_bond_8023ad_slave_info(uint16_t port_id, uint16_t slave_id,
                struct rte_eth_bond_8023ad_slave_info *info)
 {
        struct rte_eth_dev *bond_dev;
@@ -1411,7 +1436,7 @@ rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
 }
 
 static int
-bond_8023ad_ext_validate(uint8_t port_id, uint8_t slave_id)
+bond_8023ad_ext_validate(uint16_t port_id, uint16_t slave_id)
 {
        struct rte_eth_dev *bond_dev;
        struct bond_dev_private *internals;
@@ -1439,7 +1464,8 @@ bond_8023ad_ext_validate(uint8_t port_id, uint8_t slave_id)
 }
 
 int
-rte_eth_bond_8023ad_ext_collect(uint8_t port_id, uint8_t slave_id, int enabled)
+rte_eth_bond_8023ad_ext_collect(uint16_t port_id, uint16_t slave_id,
+                               int enabled)
 {
        struct port *port;
        int res;
@@ -1459,7 +1485,8 @@ rte_eth_bond_8023ad_ext_collect(uint8_t port_id, uint8_t slave_id, int enabled)
 }
 
 int
-rte_eth_bond_8023ad_ext_distrib(uint8_t port_id, uint8_t slave_id, int enabled)
+rte_eth_bond_8023ad_ext_distrib(uint16_t port_id, uint16_t slave_id,
+                               int enabled)
 {
        struct port *port;
        int res;
@@ -1479,7 +1506,7 @@ rte_eth_bond_8023ad_ext_distrib(uint8_t port_id, uint8_t slave_id, int enabled)
 }
 
 int
-rte_eth_bond_8023ad_ext_distrib_get(uint8_t port_id, uint8_t slave_id)
+rte_eth_bond_8023ad_ext_distrib_get(uint16_t port_id, uint16_t slave_id)
 {
        struct port *port;
        int err;
@@ -1493,7 +1520,7 @@ rte_eth_bond_8023ad_ext_distrib_get(uint8_t port_id, uint8_t slave_id)
 }
 
 int
-rte_eth_bond_8023ad_ext_collect_get(uint8_t port_id, uint8_t slave_id)
+rte_eth_bond_8023ad_ext_collect_get(uint16_t port_id, uint16_t slave_id)
 {
        struct port *port;
        int err;
@@ -1507,7 +1534,7 @@ rte_eth_bond_8023ad_ext_collect_get(uint8_t port_id, uint8_t slave_id)
 }
 
 int
-rte_eth_bond_8023ad_ext_slowtx(uint8_t port_id, uint8_t slave_id,
+rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t slave_id,
                struct rte_mbuf *lacp_pkt)
 {
        struct port *port;
@@ -1568,7 +1595,7 @@ bond_mode_8023ad_ext_periodic_cb(void *arg)
 }
 
 int
-rte_eth_bond_8023ad_dedicated_queues_enable(uint8_t port)
+rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
 {
        int retval = 0;
        struct rte_eth_dev *dev = &rte_eth_devices[port];
@@ -1592,7 +1619,7 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint8_t port)
 }
 
 int
-rte_eth_bond_8023ad_dedicated_queues_disable(uint8_t port)
+rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
 {
        int retval = 0;
        struct rte_eth_dev *dev = &rte_eth_devices[port];