ethdev: retrieve xstats by ID
[dpdk.git] / lib / librte_ether / rte_ethdev.c
index a87ddd9..fe56f65 100644 (file)
@@ -1357,12 +1357,19 @@ get_xstats_count(uint8_t port_id)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
        dev = &rte_eth_devices[port_id];
+       if (dev->dev_ops->xstats_get_names_by_ids != NULL) {
+               count = (*dev->dev_ops->xstats_get_names_by_ids)(dev, NULL,
+                               NULL, 0);
+               if (count < 0)
+                       return count;
+       }
        if (dev->dev_ops->xstats_get_names != NULL) {
                count = (*dev->dev_ops->xstats_get_names)(dev, NULL, 0);
                if (count < 0)
                        return count;
        } else
                count = 0;
+
        count += RTE_NB_STATS;
        count += RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS) *
                 RTE_NB_RXQ_STATS;
@@ -1372,150 +1379,323 @@ get_xstats_count(uint8_t port_id)
 }
 
 int
-rte_eth_xstats_get_names(uint8_t port_id,
+rte_eth_xstats_get_names_v1607(uint8_t port_id,
        struct rte_eth_xstat_name *xstats_names,
-       unsigned size)
+       unsigned int size)
 {
-       struct rte_eth_dev *dev;
-       int cnt_used_entries;
-       int cnt_expected_entries;
-       int cnt_driver_entries;
-       uint32_t idx, id_queue;
-       uint16_t num_q;
+       return rte_eth_xstats_get_names(port_id, xstats_names, size, NULL);
+}
+VERSION_SYMBOL(rte_eth_xstats_get_names, _v1607, 16.07);
 
-       cnt_expected_entries = get_xstats_count(port_id);
-       if (xstats_names == NULL || cnt_expected_entries < 0 ||
-                       (int)size < cnt_expected_entries)
-               return cnt_expected_entries;
+int
+rte_eth_xstats_get_names_v1705(uint8_t port_id,
+       struct rte_eth_xstat_name *xstats_names, unsigned int size,
+       uint64_t *ids)
+{
+       /* Get all xstats */
+       if (!ids) {
+               struct rte_eth_dev *dev;
+               int cnt_used_entries;
+               int cnt_expected_entries;
+               int cnt_driver_entries;
+               uint32_t idx, id_queue;
+               uint16_t num_q;
 
-       /* port_id checked in get_xstats_count() */
-       dev = &rte_eth_devices[port_id];
-       cnt_used_entries = 0;
+               cnt_expected_entries = get_xstats_count(port_id);
+               if (xstats_names == NULL || cnt_expected_entries < 0 ||
+                               (int)size < cnt_expected_entries)
+                       return cnt_expected_entries;
 
-       for (idx = 0; idx < RTE_NB_STATS; idx++) {
-               snprintf(xstats_names[cnt_used_entries].name,
-                       sizeof(xstats_names[0].name),
-                       "%s", rte_stats_strings[idx].name);
-               cnt_used_entries++;
-       }
-       num_q = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);
-       for (id_queue = 0; id_queue < num_q; id_queue++) {
-               for (idx = 0; idx < RTE_NB_RXQ_STATS; idx++) {
+               /* port_id checked in get_xstats_count() */
+               dev = &rte_eth_devices[port_id];
+               cnt_used_entries = 0;
+
+               for (idx = 0; idx < RTE_NB_STATS; idx++) {
                        snprintf(xstats_names[cnt_used_entries].name,
                                sizeof(xstats_names[0].name),
-                               "rx_q%u%s",
-                               id_queue, rte_rxq_stats_strings[idx].name);
+                               "%s", rte_stats_strings[idx].name);
                        cnt_used_entries++;
                }
+               num_q = RTE_MIN(dev->data->nb_rx_queues,
+                               RTE_ETHDEV_QUEUE_STAT_CNTRS);
+               for (id_queue = 0; id_queue < num_q; id_queue++) {
+                       for (idx = 0; idx < RTE_NB_RXQ_STATS; idx++) {
+                               snprintf(xstats_names[cnt_used_entries].name,
+                                       sizeof(xstats_names[0].name),
+                                       "rx_q%u%s",
+                                       id_queue,
+                                       rte_rxq_stats_strings[idx].name);
+                               cnt_used_entries++;
+                       }
+
+               }
+               num_q = RTE_MIN(dev->data->nb_tx_queues,
+                               RTE_ETHDEV_QUEUE_STAT_CNTRS);
+               for (id_queue = 0; id_queue < num_q; id_queue++) {
+                       for (idx = 0; idx < RTE_NB_TXQ_STATS; idx++) {
+                               snprintf(xstats_names[cnt_used_entries].name,
+                                       sizeof(xstats_names[0].name),
+                                       "tx_q%u%s",
+                                       id_queue,
+                                       rte_txq_stats_strings[idx].name);
+                               cnt_used_entries++;
+                       }
+               }
+
+               if (dev->dev_ops->xstats_get_names_by_ids != NULL) {
+                       /* If there are any driver-specific xstats, append them
+                        * to end of list.
+                        */
+                       cnt_driver_entries =
+                               (*dev->dev_ops->xstats_get_names_by_ids)(
+                               dev,
+                               xstats_names + cnt_used_entries,
+                               NULL,
+                               size - cnt_used_entries);
+                       if (cnt_driver_entries < 0)
+                               return cnt_driver_entries;
+                       cnt_used_entries += cnt_driver_entries;
+
+               } else if (dev->dev_ops->xstats_get_names != NULL) {
+                       /* If there are any driver-specific xstats, append them
+                        * to end of list.
+                        */
+                       cnt_driver_entries = (*dev->dev_ops->xstats_get_names)(
+                               dev,
+                               xstats_names + cnt_used_entries,
+                               size - cnt_used_entries);
+                       if (cnt_driver_entries < 0)
+                               return cnt_driver_entries;
+                       cnt_used_entries += cnt_driver_entries;
+               }
 
+               return cnt_used_entries;
        }
-       num_q = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);
-       for (id_queue = 0; id_queue < num_q; id_queue++) {
-               for (idx = 0; idx < RTE_NB_TXQ_STATS; idx++) {
-                       snprintf(xstats_names[cnt_used_entries].name,
-                               sizeof(xstats_names[0].name),
-                               "tx_q%u%s",
-                               id_queue, rte_txq_stats_strings[idx].name);
-                       cnt_used_entries++;
+       /* Get only xstats given by IDS */
+       else {
+               uint16_t len, i;
+               struct rte_eth_xstat_name *xstats_names_copy;
+
+               len = rte_eth_xstats_get_names_v1705(port_id, NULL, 0, NULL);
+
+               xstats_names_copy =
+                               malloc(sizeof(struct rte_eth_xstat_name) * len);
+               if (!xstats_names_copy) {
+                       RTE_PMD_DEBUG_TRACE(
+                            "ERROR: can't allocate memory for values_copy\n");
+                       free(xstats_names_copy);
+                       return -1;
+               }
+
+               rte_eth_xstats_get_names_v1705(port_id, xstats_names_copy,
+                               len, NULL);
+
+               for (i = 0; i < size; i++) {
+                       if (ids[i] >= len) {
+                               RTE_PMD_DEBUG_TRACE(
+                                       "ERROR: id value isn't valid\n");
+                               return -1;
+                       }
+                       strcpy(xstats_names[i].name,
+                                       xstats_names_copy[ids[i]].name);
                }
+               free(xstats_names_copy);
+               return size;
        }
+}
+BIND_DEFAULT_SYMBOL(rte_eth_xstats_get_names, _v1705, 17.05);
 
-       if (dev->dev_ops->xstats_get_names != NULL) {
-               /* If there are any driver-specific xstats, append them
-                * to end of list.
-                */
-               cnt_driver_entries = (*dev->dev_ops->xstats_get_names)(
-                       dev,
-                       xstats_names + cnt_used_entries,
-                       size - cnt_used_entries);
-               if (cnt_driver_entries < 0)
-                       return cnt_driver_entries;
-               cnt_used_entries += cnt_driver_entries;
+MAP_STATIC_SYMBOL(int
+               rte_eth_xstats_get_names(uint8_t port_id,
+                       struct rte_eth_xstat_name *xstats_names,
+                       unsigned int size,
+                       uint64_t *ids), rte_eth_xstats_get_names_v1705);
+
+/* retrieve ethdev extended statistics */
+int
+rte_eth_xstats_get_v22(uint8_t port_id, struct rte_eth_xstat *xstats,
+       unsigned int n)
+{
+       uint64_t *values_copy;
+       uint16_t size, i;
+
+       values_copy = malloc(sizeof(values_copy) * n);
+       if (!values_copy) {
+               RTE_PMD_DEBUG_TRACE(
+                               "ERROR: Cannot allocate memory for xstats\n");
+               return -1;
        }
+       size = rte_eth_xstats_get(port_id, 0, values_copy, n);
 
-       return cnt_used_entries;
+       for (i = 0; i < n; i++) {
+               xstats[i].id = i;
+               xstats[i].value = values_copy[i];
+       }
+       free(values_copy);
+       return size;
 }
+VERSION_SYMBOL(rte_eth_xstats_get, _v22, 2.2);
 
 /* retrieve ethdev extended statistics */
 int
-rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstat *xstats,
-       unsigned n)
-{
-       struct rte_eth_stats eth_stats;
-       struct rte_eth_dev *dev;
-       unsigned count = 0, i, q;
-       signed xcount = 0;
-       uint64_t val, *stats_ptr;
-       uint16_t nb_rxqs, nb_txqs;
+rte_eth_xstats_get_v1705(uint8_t port_id, uint64_t *ids, uint64_t *values,
+       unsigned int n)
+{
+       /* If need all xstats */
+       if (!ids) {
+               struct rte_eth_stats eth_stats;
+               struct rte_eth_dev *dev;
+               unsigned int count = 0, i, q;
+               signed int xcount = 0;
+               uint64_t val, *stats_ptr;
+               uint16_t nb_rxqs, nb_txqs;
+
+               RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+               dev = &rte_eth_devices[port_id];
+
+               nb_rxqs = RTE_MIN(dev->data->nb_rx_queues,
+                               RTE_ETHDEV_QUEUE_STAT_CNTRS);
+               nb_txqs = RTE_MIN(dev->data->nb_tx_queues,
+                               RTE_ETHDEV_QUEUE_STAT_CNTRS);
+
+               /* Return generic statistics */
+               count = RTE_NB_STATS + (nb_rxqs * RTE_NB_RXQ_STATS) +
+                       (nb_txqs * RTE_NB_TXQ_STATS);
+
+
+               /* implemented by the driver */
+               if (dev->dev_ops->xstats_get_by_ids != NULL) {
+                       /* Retrieve the xstats from the driver at the end of the
+                        * xstats struct. Retrieve all xstats.
+                        */
+                       xcount = (*dev->dev_ops->xstats_get_by_ids)(dev,
+                                       NULL,
+                                       values ? values + count : NULL,
+                                       (n > count) ? n - count : 0);
+
+                       if (xcount < 0)
+                               return xcount;
+               /* implemented by the driver */
+               } else if (dev->dev_ops->xstats_get != NULL) {
+                       /* Retrieve the xstats from the driver at the end of the
+                        * xstats struct. Retrieve all xstats.
+                        * Compatibility for PMD without xstats_get_by_ids
+                        */
+                       unsigned int size = (n > count) ? n - count : 1;
+                       struct rte_eth_xstat xstats[size];
+
+                       xcount = (*dev->dev_ops->xstats_get)(dev,
+                                       values ? xstats : NULL, size);
+
+                       if (xcount < 0)
+                               return xcount;
+
+                       if (values != NULL)
+                               for (i = 0 ; i < (unsigned int)xcount; i++)
+                                       values[i + count] = xstats[i].value;
+               }
 
-       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+               if (n < count + xcount || values == NULL)
+                       return count + xcount;
 
-       dev = &rte_eth_devices[port_id];
+               /* now fill the xstats structure */
+               count = 0;
+               rte_eth_stats_get(port_id, &eth_stats);
 
-       nb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);
-       nb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);
+               /* global stats */
+               for (i = 0; i < RTE_NB_STATS; i++) {
+                       stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                               rte_stats_strings[i].offset);
+                       val = *stats_ptr;
+                       values[count++] = val;
+               }
 
-       /* Return generic statistics */
-       count = RTE_NB_STATS + (nb_rxqs * RTE_NB_RXQ_STATS) +
-               (nb_txqs * RTE_NB_TXQ_STATS);
+               /* per-rxq stats */
+               for (q = 0; q < nb_rxqs; q++) {
+                       for (i = 0; i < RTE_NB_RXQ_STATS; i++) {
+                               stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                           rte_rxq_stats_strings[i].offset +
+                                           q * sizeof(uint64_t));
+                               val = *stats_ptr;
+                               values[count++] = val;
+                       }
+               }
 
-       /* implemented by the driver */
-       if (dev->dev_ops->xstats_get != NULL) {
-               /* Retrieve the xstats from the driver at the end of the
-                * xstats struct.
-                */
-               xcount = (*dev->dev_ops->xstats_get)(dev,
-                                    xstats ? xstats + count : NULL,
-                                    (n > count) ? n - count : 0);
+               /* per-txq stats */
+               for (q = 0; q < nb_txqs; q++) {
+                       for (i = 0; i < RTE_NB_TXQ_STATS; i++) {
+                               stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                           rte_txq_stats_strings[i].offset +
+                                           q * sizeof(uint64_t));
+                               val = *stats_ptr;
+                               values[count++] = val;
+                       }
+               }
 
-               if (xcount < 0)
-                       return xcount;
+               return count + xcount;
        }
+       /* Need only xstats given by IDS array */
+       else {
+               uint16_t i, size;
+               uint64_t *values_copy;
 
-       if (n < count + xcount || xstats == NULL)
-               return count + xcount;
+               size = rte_eth_xstats_get_v1705(port_id, NULL, NULL, 0);
 
-       /* now fill the xstats structure */
-       count = 0;
-       rte_eth_stats_get(port_id, &eth_stats);
+               values_copy = malloc(sizeof(values_copy) * size);
+               if (!values_copy) {
+                       RTE_PMD_DEBUG_TRACE(
+                           "ERROR: can't allocate memory for values_copy\n");
+                       return -1;
+               }
 
-       /* global stats */
-       for (i = 0; i < RTE_NB_STATS; i++) {
-               stats_ptr = RTE_PTR_ADD(&eth_stats,
-                                       rte_stats_strings[i].offset);
-               val = *stats_ptr;
-               xstats[count++].value = val;
-       }
+               rte_eth_xstats_get_v1705(port_id, NULL, values_copy, size);
 
-       /* per-rxq stats */
-       for (q = 0; q < nb_rxqs; q++) {
-               for (i = 0; i < RTE_NB_RXQ_STATS; i++) {
-                       stats_ptr = RTE_PTR_ADD(&eth_stats,
-                                       rte_rxq_stats_strings[i].offset +
-                                       q * sizeof(uint64_t));
-                       val = *stats_ptr;
-                       xstats[count++].value = val;
+               for (i = 0; i < n; i++) {
+                       if (ids[i] >= size) {
+                               RTE_PMD_DEBUG_TRACE(
+                                       "ERROR: id value isn't valid\n");
+                               return -1;
+                       }
+                       values[i] = values_copy[ids[i]];
                }
+               free(values_copy);
+               return n;
        }
+}
+BIND_DEFAULT_SYMBOL(rte_eth_xstats_get, _v1705, 17.05);
 
-       /* per-txq stats */
-       for (q = 0; q < nb_txqs; q++) {
-               for (i = 0; i < RTE_NB_TXQ_STATS; i++) {
-                       stats_ptr = RTE_PTR_ADD(&eth_stats,
-                                       rte_txq_stats_strings[i].offset +
-                                       q * sizeof(uint64_t));
-                       val = *stats_ptr;
-                       xstats[count++].value = val;
-               }
+MAP_STATIC_SYMBOL(int
+               rte_eth_xstats_get(uint8_t port_id, uint64_t *ids,
+               uint64_t *values, unsigned int n), rte_eth_xstats_get_v1705);
+
+int
+rte_eth_xstats_get_all(uint8_t port_id, struct rte_eth_xstat *xstats,
+       unsigned int n)
+{
+       uint64_t *values_copy;
+       uint16_t size, i;
+
+       values_copy = malloc(sizeof(values_copy) * n);
+       if (!values_copy) {
+               RTE_PMD_DEBUG_TRACE(
+                               "ERROR: Cannot allocate memory for xstats\n");
+               return -1;
        }
+       size = rte_eth_xstats_get(port_id, 0, values_copy, n);
 
-       for (i = 0; i < count; i++)
+       for (i = 0; i < n; i++) {
                xstats[i].id = i;
-       /* add an offset to driver-specific stats */
-       for ( ; i < count + xcount; i++)
-               xstats[i].id += count;
+               xstats[i].value = values_copy[i];
+       }
+       free(values_copy);
+       return size;
+}
 
-       return count + xcount;
+int
+rte_eth_xstats_get_names_all(uint8_t port_id,
+               struct rte_eth_xstat_name *xstats_names, unsigned int n)
+{
+       return rte_eth_xstats_get_names(port_id, xstats_names, n, NULL);
 }
 
 /* reset ethdev extended statistics */