bus/pci: ignore missing NUMA node on Windows
authorTal Shnaiderman <talshn@nvidia.com>
Sun, 13 Dec 2020 14:16:04 +0000 (16:16 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 5 Jan 2021 22:01:36 +0000 (23:01 +0100)
On older processors, NUMA isn't bound to PCIe locality.
those cases return ERROR_NOT_FOUND in response to the
SetupDiGetDevicePropertyW call with DEVPKEY_Device_Numa_Node
attribute.

This error fails the probe process for the PCIe device.
this commit will ignore such failure and will set the
numa_node to 0.

Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
Cc: stable@dpdk.org
Reported-by: Odi Assli <odia@nvidia.com>
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Tested-by: Odi Assli <odia@nvidia.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
drivers/bus/pci/windows/pci.c

index fbf0785..f662584 100644 (file)
@@ -235,6 +235,12 @@ get_device_resource_info(HDEVINFO dev_info,
                &DEVPKEY_Device_Numa_Node, &property_type,
                (BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
        if (!res) {
+               DWORD error = GetLastError();
+               if (error == ERROR_NOT_FOUND) {
+                       /* On older CPUs, NUMA is not bound to PCIe locality. */
+                       dev->device.numa_node = 0;
+                       return ERROR_SUCCESS;
+               }
                RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
                        "(DEVPKEY_Device_Numa_Node)");
                return -1;