use 2 streams (input and output) instead of 1 in parse_from_memory()
authorOlivier Matz <zer0@droids-corp.org>
Wed, 29 Aug 2012 22:10:57 +0000 (00:10 +0200)
committerOlivier Matz <zer0@droids-corp.org>
Wed, 29 Aug 2012 22:10:57 +0000 (00:10 +0200)
The initial code was not well tested and according to Sergey it is not
working properly.

Signed-off-by: Sergey Satskiy <sergey.satskiy@gmail.com>
Signed-off-by: Olivier Matz <zer0@droids-corp.org>
diff2html.py

index 337667f..b361491 100644 (file)
@@ -424,9 +424,11 @@ def main():
 
 def parse_from_memory(txt, exclude_headers, show_hunk_infos):
     " Parses diff from memory and returns a string with html "
-    stream = StringIO.StringIO(txt)
-    parse_input(stream, stream, exclude_headers, show_hunk_infos)
-    return stream.buf
+    input_stream = StringIO.StringIO(txt)
+    output_stream = StringIO.StringIO()
+    parse_input(input_stream, output_stream, exclude_headers, show_hunk_infos)
+    return output_stream.getvalue()
+
 
 if __name__ == "__main__":
     main()