drivers/net/bnxt/bnxt_flow.c

   1 /* SPDX-License-Identifier: BSD-3-Clause
   2  * Copyright(c) 2014-2018 Broadcom
   3  * All rights reserved.
   4  */
   5
   6 #include <sys/queue.h>
   7
   8 #include <rte_log.h>
   9 #include <rte_malloc.h>
  10 #include <rte_flow.h>
  11 #include <rte_flow_driver.h>
  12 #include <rte_tailq.h>
  13
  14 #include "bnxt.h"
  15 #include "bnxt_filter.h"
  16 #include "bnxt_hwrm.h"
  17 #include "bnxt_ring.h"
  18 #include "bnxt_rxq.h"
  19 #include "bnxt_vnic.h"
  20 #include "hsi_struct_def_dpdk.h"
  21
  22 static int
  23 bnxt_flow_args_validate(const struct rte_flow_attr *attr,
  24                         const struct rte_flow_item pattern[],
  25                         const struct rte_flow_action actions[],
  26                         struct rte_flow_error *error)
  27 {
  28         if (!pattern) {
  29                 rte_flow_error_set(error,
  30                                    EINVAL,
  31                                    RTE_FLOW_ERROR_TYPE_ITEM_NUM,
  32                                    NULL,
  33                                    "NULL pattern.");
  34                 return -rte_errno;
  35         }
  36
  37         if (!actions) {
  38                 rte_flow_error_set(error,
  39                                    EINVAL,
  40                                    RTE_FLOW_ERROR_TYPE_ACTION_NUM,
  41                                    NULL,
  42                                    "NULL action.");
  43                 return -rte_errno;
  44         }
  45
  46         if (!attr) {
  47                 rte_flow_error_set(error,
  48                                    EINVAL,
  49                                    RTE_FLOW_ERROR_TYPE_ATTR,
  50                                    NULL,
  51                                    "NULL attribute.");
  52                 return -rte_errno;
  53         }
  54
  55         return 0;
  56 }
  57
  58 static const struct rte_flow_item *
  59 bnxt_flow_non_void_item(const struct rte_flow_item *cur)
  60 {
  61         while (1) {
  62                 if (cur->type != RTE_FLOW_ITEM_TYPE_VOID)
  63                         return cur;
  64                 cur++;
  65         }
  66 }
  67
  68 static const struct rte_flow_action *
  69 bnxt_flow_non_void_action(const struct rte_flow_action *cur)
  70 {
  71         while (1) {
  72                 if (cur->type != RTE_FLOW_ACTION_TYPE_VOID)
  73                         return cur;
  74                 cur++;
  75         }
  76 }
  77
  78 static int
  79 bnxt_filter_type_check(const struct rte_flow_item pattern[],
  80                        struct rte_flow_error *error)
  81 {
  82         const struct rte_flow_item *item =
  83                 bnxt_flow_non_void_item(pattern);
  84         int use_ntuple = 1;
  85         bool has_vlan = 0;
  86
  87         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
  88                 switch (item->type) {
  89                 case RTE_FLOW_ITEM_TYPE_ANY:
  90                 case RTE_FLOW_ITEM_TYPE_ETH:
  91                         use_ntuple = 0;
  92                         break;
  93                 case RTE_FLOW_ITEM_TYPE_VLAN:
  94                         use_ntuple = 0;
  95                         has_vlan = 1;
  96                         break;
  97                 case RTE_FLOW_ITEM_TYPE_IPV4:
  98                 case RTE_FLOW_ITEM_TYPE_IPV6:
  99                 case RTE_FLOW_ITEM_TYPE_TCP:
 100                 case RTE_FLOW_ITEM_TYPE_UDP:
 101                         /* FALLTHROUGH */
 102                         /* need ntuple match, reset exact match */
 103                         use_ntuple |= 1;
 104                         break;
 105                 default:
 106                         PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
 107                         use_ntuple |= 0;
 108                 }
 109                 item++;
 110         }
 111
 112         if (has_vlan && use_ntuple) {
 113                 PMD_DRV_LOG(ERR,
 114                             "VLAN flow cannot use NTUPLE filter\n");
 115                 rte_flow_error_set(error, EINVAL,
 116                                    RTE_FLOW_ERROR_TYPE_ITEM,
 117                                    item,
 118                                    "Cannot use VLAN with NTUPLE");
 119                 return -rte_errno;
 120         }
 121
 122         return use_ntuple;
 123 }
 124
 125 static int
 126 bnxt_validate_and_parse_flow_type(struct bnxt *bp,
 127                                   const struct rte_flow_attr *attr,
 128                                   const struct rte_flow_item pattern[],
 129                                   struct rte_flow_error *error,
 130                                   struct bnxt_filter_info *filter)
 131 {
 132         const struct rte_flow_item *item = bnxt_flow_non_void_item(pattern);
 133         const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
 134         const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
 135         const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
 136         const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
 137         const struct rte_flow_item_udp *udp_spec, *udp_mask;
 138         const struct rte_flow_item_eth *eth_spec, *eth_mask;
 139         const struct rte_ether_addr *dst, *src;
 140         const struct rte_flow_item_nvgre *nvgre_spec;
 141         const struct rte_flow_item_nvgre *nvgre_mask;
 142         const struct rte_flow_item_gre *gre_spec;
 143         const struct rte_flow_item_gre *gre_mask;
 144         const struct rte_flow_item_vxlan *vxlan_spec;
 145         const struct rte_flow_item_vxlan *vxlan_mask;
 146         uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
 147         uint8_t tni_mask[] = {0xFF, 0xFF, 0xFF};
 148         const struct rte_flow_item_vf *vf_spec;
 149         uint32_t tenant_id_be = 0, valid_flags = 0;
 150         bool vni_masked = 0;
 151         bool tni_masked = 0;
 152         uint32_t en_ethertype;
 153         uint8_t inner = 0;
 154         uint32_t vf = 0;
 155         uint32_t en = 0;
 156         int use_ntuple;
 157         int dflt_vnic;
 158
 159         use_ntuple = bnxt_filter_type_check(pattern, error);
 160         if (use_ntuple < 0)
 161                 return use_ntuple;
 162         PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
 163
 164         filter->filter_type = use_ntuple ?
 165                 HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_L2_FILTER;
 166         en_ethertype = use_ntuple ?
 167                 NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE :
 168                 EM_FLOW_ALLOC_INPUT_EN_ETHERTYPE;
 169
 170         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
 171                 if (item->last) {
 172                         /* last or range is NOT supported as match criteria */
 173                         rte_flow_error_set(error, EINVAL,
 174                                            RTE_FLOW_ERROR_TYPE_ITEM,
 175                                            item,
 176                                            "No support for range");
 177                         return -rte_errno;
 178                 }
 179
 180                 switch (item->type) {
 181                 case RTE_FLOW_ITEM_TYPE_ANY:
 182                         inner =
 183                         ((const struct rte_flow_item_any *)item->spec)->num > 3;
 184                         if (inner)
 185                                 PMD_DRV_LOG(DEBUG, "Parse inner header\n");
 186                         break;
 187                 case RTE_FLOW_ITEM_TYPE_ETH:
 188                         if (!item->spec || !item->mask)
 189                                 break;
 190
 191                         eth_spec = item->spec;
 192                         eth_mask = item->mask;
 193
 194                         /* Source MAC address mask cannot be partially set.
 195                          * Should be All 0's or all 1's.
 196                          * Destination MAC address mask must not be partially
 197                          * set. Should be all 1's or all 0's.
 198                          */
 199                         if ((!rte_is_zero_ether_addr(&eth_mask->src) &&
 200                              !rte_is_broadcast_ether_addr(&eth_mask->src)) ||
 201                             (!rte_is_zero_ether_addr(&eth_mask->dst) &&
 202                              !rte_is_broadcast_ether_addr(&eth_mask->dst))) {
 203                                 rte_flow_error_set(error,
 204                                                    EINVAL,
 205                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 206                                                    item,
 207                                                    "MAC_addr mask not valid");
 208                                 return -rte_errno;
 209                         }
 210
 211                         /* Mask is not allowed. Only exact matches are */
 212                         if (eth_mask->type &&
 213                             eth_mask->type != RTE_BE16(0xffff)) {
 214                                 rte_flow_error_set(error, EINVAL,
 215                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 216                                                    item,
 217                                                    "ethertype mask not valid");
 218                                 return -rte_errno;
 219                         }
 220
 221                         if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
 222                                 dst = &eth_spec->dst;
 223                                 if (!rte_is_valid_assigned_ether_addr(dst)) {
 224                                         rte_flow_error_set(error,
 225                                                            EINVAL,
 226                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 227                                                            item,
 228                                                            "DMAC is invalid");
 229                                         PMD_DRV_LOG(ERR,
 230                                                     "DMAC is invalid!\n");
 231                                         return -rte_errno;
 232                                 }
 233                                 rte_memcpy(filter->dst_macaddr,
 234                                            &eth_spec->dst, RTE_ETHER_ADDR_LEN);
 235                                 en |= use_ntuple ?
 236                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
 237                                         EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
 238                                 valid_flags |= inner ?
 239                                         BNXT_FLOW_L2_INNER_DST_VALID_FLAG :
 240                                         BNXT_FLOW_L2_DST_VALID_FLAG;
 241                                 filter->priority = attr->priority;
 242                                 PMD_DRV_LOG(DEBUG,
 243                                             "Creating a priority flow\n");
 244                         }
 245                         if (rte_is_broadcast_ether_addr(&eth_mask->src)) {
 246                                 src = &eth_spec->src;
 247                                 if (!rte_is_valid_assigned_ether_addr(src)) {
 248                                         rte_flow_error_set(error,
 249                                                            EINVAL,
 250                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 251                                                            item,
 252                                                            "SMAC is invalid");
 253                                         PMD_DRV_LOG(ERR,
 254                                                     "SMAC is invalid!\n");
 255                                         return -rte_errno;
 256                                 }
 257                                 rte_memcpy(filter->src_macaddr,
 258                                            &eth_spec->src, RTE_ETHER_ADDR_LEN);
 259                                 en |= use_ntuple ?
 260                                         NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
 261                                         EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
 262                                 valid_flags |= inner ?
 263                                         BNXT_FLOW_L2_INNER_SRC_VALID_FLAG :
 264                                         BNXT_FLOW_L2_SRC_VALID_FLAG;
 265                         } /*
 266                            * else {
 267                            *  PMD_DRV_LOG(ERR, "Handle this condition\n");
 268                            * }
 269                            */
 270                         if (eth_mask->type) {
 271                                 filter->ethertype =
 272                                         rte_be_to_cpu_16(eth_spec->type);
 273                                 en |= en_ethertype;
 274                         }
 275                         if (inner)
 276                                 valid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;
 277
 278                         break;
 279                 case RTE_FLOW_ITEM_TYPE_VLAN:
 280                         vlan_spec = item->spec;
 281                         vlan_mask = item->mask;
 282                         if (en & en_ethertype) {
 283                                 rte_flow_error_set(error, EINVAL,
 284                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 285                                                    item,
 286                                                    "VLAN TPID matching is not"
 287                                                    " supported");
 288                                 return -rte_errno;
 289                         }
 290                         if (vlan_mask->tci &&
 291                             vlan_mask->tci == RTE_BE16(0x0fff)) {
 292                                 /* Only the VLAN ID can be matched. */
 293                                 filter->l2_ovlan =
 294                                         rte_be_to_cpu_16(vlan_spec->tci &
 295                                                          RTE_BE16(0x0fff));
 296                                 en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
 297                         } else {
 298                                 rte_flow_error_set(error,
 299                                                    EINVAL,
 300                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 301                                                    item,
 302                                                    "VLAN mask is invalid");
 303                                 return -rte_errno;
 304                         }
 305                         if (vlan_mask->inner_type &&
 306                             vlan_mask->inner_type != RTE_BE16(0xffff)) {
 307                                 rte_flow_error_set(error, EINVAL,
 308                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 309                                                    item,
 310                                                    "inner ethertype mask not"
 311                                                    " valid");
 312                                 return -rte_errno;
 313                         }
 314                         if (vlan_mask->inner_type) {
 315                                 filter->ethertype =
 316                                         rte_be_to_cpu_16(vlan_spec->inner_type);
 317                                 en |= en_ethertype;
 318                         }
 319
 320                         break;
 321                 case RTE_FLOW_ITEM_TYPE_IPV4:
 322                         /* If mask is not involved, we could use EM filters. */
 323                         ipv4_spec = item->spec;
 324                         ipv4_mask = item->mask;
 325
 326                         if (!item->spec || !item->mask)
 327                                 break;
 328
 329                         /* Only IP DST and SRC fields are maskable. */
 330                         if (ipv4_mask->hdr.version_ihl ||
 331                             ipv4_mask->hdr.type_of_service ||
 332                             ipv4_mask->hdr.total_length ||
 333                             ipv4_mask->hdr.packet_id ||
 334                             ipv4_mask->hdr.fragment_offset ||
 335                             ipv4_mask->hdr.time_to_live ||
 336                             ipv4_mask->hdr.next_proto_id ||
 337                             ipv4_mask->hdr.hdr_checksum) {
 338                                 rte_flow_error_set(error,
 339                                                    EINVAL,
 340                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 341                                                    item,
 342                                                    "Invalid IPv4 mask.");
 343                                 return -rte_errno;
 344                         }
 345
 346                         filter->dst_ipaddr[0] = ipv4_spec->hdr.dst_addr;
 347                         filter->src_ipaddr[0] = ipv4_spec->hdr.src_addr;
 348
 349                         if (use_ntuple)
 350                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 351                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 352                         else
 353                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 354                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 355
 356                         if (ipv4_mask->hdr.src_addr) {
 357                                 filter->src_ipaddr_mask[0] =
 358                                         ipv4_mask->hdr.src_addr;
 359                                 en |= !use_ntuple ? 0 :
 360                                      NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 361                         }
 362
 363                         if (ipv4_mask->hdr.dst_addr) {
 364                                 filter->dst_ipaddr_mask[0] =
 365                                         ipv4_mask->hdr.dst_addr;
 366                                 en |= !use_ntuple ? 0 :
 367                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 368                         }
 369
 370                         filter->ip_addr_type = use_ntuple ?
 371                          HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
 372                          HWRM_CFA_EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
 373
 374                         if (ipv4_spec->hdr.next_proto_id) {
 375                                 filter->ip_protocol =
 376                                         ipv4_spec->hdr.next_proto_id;
 377                                 if (use_ntuple)
 378                                         en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
 379                                 else
 380                                         en |= EM_FLOW_ALLOC_INPUT_EN_IP_PROTO;
 381                         }
 382                         break;
 383                 case RTE_FLOW_ITEM_TYPE_IPV6:
 384                         ipv6_spec = item->spec;
 385                         ipv6_mask = item->mask;
 386
 387                         if (!item->spec || !item->mask)
 388                                 break;
 389
 390                         /* Only IP DST and SRC fields are maskable. */
 391                         if (ipv6_mask->hdr.vtc_flow ||
 392                             ipv6_mask->hdr.payload_len ||
 393                             ipv6_mask->hdr.proto ||
 394                             ipv6_mask->hdr.hop_limits) {
 395                                 rte_flow_error_set(error,
 396                                                    EINVAL,
 397                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 398                                                    item,
 399                                                    "Invalid IPv6 mask.");
 400                                 return -rte_errno;
 401                         }
 402
 403                         if (use_ntuple)
 404                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 405                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 406                         else
 407                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 408                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 409
 410                         rte_memcpy(filter->src_ipaddr,
 411                                    ipv6_spec->hdr.src_addr, 16);
 412                         rte_memcpy(filter->dst_ipaddr,
 413                                    ipv6_spec->hdr.dst_addr, 16);
 414
 415                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
 416                                                    16)) {
 417                                 rte_memcpy(filter->src_ipaddr_mask,
 418                                            ipv6_mask->hdr.src_addr, 16);
 419                                 en |= !use_ntuple ? 0 :
 420                                     NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 421                         }
 422
 423                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
 424                                                    16)) {
 425                                 rte_memcpy(filter->dst_ipaddr_mask,
 426                                            ipv6_mask->hdr.dst_addr, 16);
 427                                 en |= !use_ntuple ? 0 :
 428                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 429                         }
 430
 431                         filter->ip_addr_type = use_ntuple ?
 432                                 NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
 433                                 EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
 434                         break;
 435                 case RTE_FLOW_ITEM_TYPE_TCP:
 436                         tcp_spec = item->spec;
 437                         tcp_mask = item->mask;
 438
 439                         if (!item->spec || !item->mask)
 440                                 break;
 441
 442                         /* Check TCP mask. Only DST & SRC ports are maskable */
 443                         if (tcp_mask->hdr.sent_seq ||
 444                             tcp_mask->hdr.recv_ack ||
 445                             tcp_mask->hdr.data_off ||
 446                             tcp_mask->hdr.tcp_flags ||
 447                             tcp_mask->hdr.rx_win ||
 448                             tcp_mask->hdr.cksum ||
 449                             tcp_mask->hdr.tcp_urp) {
 450                                 rte_flow_error_set(error,
 451                                                    EINVAL,
 452                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 453                                                    item,
 454                                                    "Invalid TCP mask");
 455                                 return -rte_errno;
 456                         }
 457
 458                         filter->src_port = tcp_spec->hdr.src_port;
 459                         filter->dst_port = tcp_spec->hdr.dst_port;
 460
 461                         if (use_ntuple)
 462                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 463                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 464                         else
 465                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 466                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 467
 468                         if (tcp_mask->hdr.dst_port) {
 469                                 filter->dst_port_mask = tcp_mask->hdr.dst_port;
 470                                 en |= !use_ntuple ? 0 :
 471                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 472                         }
 473
 474                         if (tcp_mask->hdr.src_port) {
 475                                 filter->src_port_mask = tcp_mask->hdr.src_port;
 476                                 en |= !use_ntuple ? 0 :
 477                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 478                         }
 479                         break;
 480                 case RTE_FLOW_ITEM_TYPE_UDP:
 481                         udp_spec = item->spec;
 482                         udp_mask = item->mask;
 483
 484                         if (!item->spec || !item->mask)
 485                                 break;
 486
 487                         if (udp_mask->hdr.dgram_len ||
 488                             udp_mask->hdr.dgram_cksum) {
 489                                 rte_flow_error_set(error,
 490                                                    EINVAL,
 491                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 492                                                    item,
 493                                                    "Invalid UDP mask");
 494                                 return -rte_errno;
 495                         }
 496
 497                         filter->src_port = udp_spec->hdr.src_port;
 498                         filter->dst_port = udp_spec->hdr.dst_port;
 499
 500                         if (use_ntuple)
 501                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 502                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 503                         else
 504                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 505                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 506
 507                         if (udp_mask->hdr.dst_port) {
 508                                 filter->dst_port_mask = udp_mask->hdr.dst_port;
 509                                 en |= !use_ntuple ? 0 :
 510                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 511                         }
 512
 513                         if (udp_mask->hdr.src_port) {
 514                                 filter->src_port_mask = udp_mask->hdr.src_port;
 515                                 en |= !use_ntuple ? 0 :
 516                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 517                         }
 518                         break;
 519                 case RTE_FLOW_ITEM_TYPE_VXLAN:
 520                         vxlan_spec = item->spec;
 521                         vxlan_mask = item->mask;
 522                         /* Check if VXLAN item is used to describe protocol.
 523                          * If yes, both spec and mask should be NULL.
 524                          * If no, both spec and mask shouldn't be NULL.
 525                          */
 526                         if ((!vxlan_spec && vxlan_mask) ||
 527                             (vxlan_spec && !vxlan_mask)) {
 528                                 rte_flow_error_set(error,
 529                                                    EINVAL,
 530                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 531                                                    item,
 532                                                    "Invalid VXLAN item");
 533                                 return -rte_errno;
 534                         }
 535
 536                         if (!vxlan_spec && !vxlan_mask) {
 537                                 filter->tunnel_type =
 538                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 539                                 break;
 540                         }
 541
 542                         if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
 543                             vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
 544                             vxlan_spec->flags != 0x8) {
 545                                 rte_flow_error_set(error,
 546                                                    EINVAL,
 547                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 548                                                    item,
 549                                                    "Invalid VXLAN item");
 550                                 return -rte_errno;
 551                         }
 552
 553                         /* Check if VNI is masked. */
 554                         if (vxlan_spec && vxlan_mask) {
 555                                 vni_masked =
 556                                         !!memcmp(vxlan_mask->vni, vni_mask,
 557                                                  RTE_DIM(vni_mask));
 558                                 if (vni_masked) {
 559                                         rte_flow_error_set
 560                                                 (error,
 561                                                  EINVAL,
 562                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 563                                                  item,
 564                                                  "Invalid VNI mask");
 565                                         return -rte_errno;
 566                                 }
 567
 568                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 569                                            vxlan_spec->vni, 3);
 570                                 filter->vni =
 571                                         rte_be_to_cpu_32(tenant_id_be);
 572                                 filter->tunnel_type =
 573                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 574                         }
 575                         break;
 576                 case RTE_FLOW_ITEM_TYPE_NVGRE:
 577                         nvgre_spec = item->spec;
 578                         nvgre_mask = item->mask;
 579                         /* Check if NVGRE item is used to describe protocol.
 580                          * If yes, both spec and mask should be NULL.
 581                          * If no, both spec and mask shouldn't be NULL.
 582                          */
 583                         if ((!nvgre_spec && nvgre_mask) ||
 584                             (nvgre_spec && !nvgre_mask)) {
 585                                 rte_flow_error_set(error,
 586                                                    EINVAL,
 587                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 588                                                    item,
 589                                                    "Invalid NVGRE item");
 590                                 return -rte_errno;
 591                         }
 592
 593                         if (!nvgre_spec && !nvgre_mask) {
 594                                 filter->tunnel_type =
 595                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 596                                 break;
 597                         }
 598
 599                         if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
 600                             nvgre_spec->protocol != 0x6558) {
 601                                 rte_flow_error_set(error,
 602                                                    EINVAL,
 603                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 604                                                    item,
 605                                                    "Invalid NVGRE item");
 606                                 return -rte_errno;
 607                         }
 608
 609                         if (nvgre_spec && nvgre_mask) {
 610                                 tni_masked =
 611                                         !!memcmp(nvgre_mask->tni, tni_mask,
 612                                                  RTE_DIM(tni_mask));
 613                                 if (tni_masked) {
 614                                         rte_flow_error_set
 615                                                 (error,
 616                                                  EINVAL,
 617                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 618                                                  item,
 619                                                  "Invalid TNI mask");
 620                                         return -rte_errno;
 621                                 }
 622                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 623                                            nvgre_spec->tni, 3);
 624                                 filter->vni =
 625                                         rte_be_to_cpu_32(tenant_id_be);
 626                                 filter->tunnel_type =
 627                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 628                         }
 629                         break;
 630
 631                 case RTE_FLOW_ITEM_TYPE_GRE:
 632                         gre_spec = (const struct rte_flow_item_gre *)item->spec;
 633                         gre_mask = (const struct rte_flow_item_gre *)item->mask;
 634
 635                         /*
 636                          *Check if GRE item is used to describe protocol.
 637                          * If yes, both spec and mask should be NULL.
 638                          * If no, both spec and mask shouldn't be NULL.
 639                          */
 640                         if (!!gre_spec ^ !!gre_mask) {
 641                                 rte_flow_error_set(error, EINVAL,
 642                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 643                                                    item,
 644                                                    "Invalid GRE item");
 645                                 return -rte_errno;
 646                         }
 647
 648                         if (!gre_spec && !gre_mask) {
 649                                 filter->tunnel_type =
 650                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE;
 651                                 break;
 652                         }
 653                         break;
 654
 655                 case RTE_FLOW_ITEM_TYPE_VF:
 656                         vf_spec = item->spec;
 657                         vf = vf_spec->id;
 658                         if (!BNXT_PF(bp)) {
 659                                 rte_flow_error_set(error,
 660                                                    EINVAL,
 661                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 662                                                    item,
 663                                                    "Configuring on a VF!");
 664                                 return -rte_errno;
 665                         }
 666
 667                         if (vf >= bp->pdev->max_vfs) {
 668                                 rte_flow_error_set(error,
 669                                                    EINVAL,
 670                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 671                                                    item,
 672                                                    "Incorrect VF id!");
 673                                 return -rte_errno;
 674                         }
 675
 676                         if (!attr->transfer) {
 677                                 rte_flow_error_set(error,
 678                                                    ENOTSUP,
 679                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 680                                                    item,
 681                                                    "Matching VF traffic without"
 682                                                    " affecting it (transfer attribute)"
 683                                                    " is unsupported");
 684                                 return -rte_errno;
 685                         }
 686
 687                         filter->mirror_vnic_id =
 688                         dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
 689                         if (dflt_vnic < 0) {
 690                                 /* This simply indicates there's no driver
 691                                  * loaded. This is not an error.
 692                                  */
 693                                 rte_flow_error_set
 694                                         (error,
 695                                          EINVAL,
 696                                          RTE_FLOW_ERROR_TYPE_ITEM,
 697                                          item,
 698                                          "Unable to get default VNIC for VF");
 699                                 return -rte_errno;
 700                         }
 701
 702                         filter->mirror_vnic_id = dflt_vnic;
 703                         en |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
 704                         break;
 705                 default:
 706                         break;
 707                 }
 708                 item++;
 709         }
 710         filter->enables = en;
 711         filter->valid_flags = valid_flags;
 712
 713         return 0;
 714 }
 715
 716 /* Parse attributes */
 717 static int
 718 bnxt_flow_parse_attr(const struct rte_flow_attr *attr,
 719                      struct rte_flow_error *error)
 720 {
 721         /* Must be input direction */
 722         if (!attr->ingress) {
 723                 rte_flow_error_set(error,
 724                                    EINVAL,
 725                                    RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
 726                                    attr,
 727                                    "Only support ingress.");
 728                 return -rte_errno;
 729         }
 730
 731         /* Not supported */
 732         if (attr->egress) {
 733                 rte_flow_error_set(error,
 734                                    EINVAL,
 735                                    RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
 736                                    attr,
 737                                    "No support for egress.");
 738                 return -rte_errno;
 739         }
 740
 741         return 0;
 742 }
 743
 744 static struct bnxt_filter_info *
 745 bnxt_find_matching_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
 746 {
 747         struct bnxt_filter_info *mf, *f0;
 748         struct bnxt_vnic_info *vnic0;
 749         int i;
 750
 751         vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
 752         f0 = STAILQ_FIRST(&vnic0->filter);
 753
 754         /* This flow has same DST MAC as the port/l2 filter. */
 755         if (memcmp(f0->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN) == 0)
 756                 return f0;
 757
 758         for (i = bp->max_vnics - 1; i >= 0; i--) {
 759                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
 760
 761                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
 762                         continue;
 763
 764                 STAILQ_FOREACH(mf, &vnic->filter, next) {
 765
 766                         if (mf->matching_l2_fltr_ptr)
 767                                 continue;
 768
 769                         if (mf->ethertype == nf->ethertype &&
 770                             mf->l2_ovlan == nf->l2_ovlan &&
 771                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
 772                             mf->l2_ivlan == nf->l2_ivlan &&
 773                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
 774                             !memcmp(mf->src_macaddr, nf->src_macaddr,
 775                                     RTE_ETHER_ADDR_LEN) &&
 776                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
 777                                     RTE_ETHER_ADDR_LEN))
 778                                 return mf;
 779                 }
 780         }
 781         return NULL;
 782 }
 783
 784 static struct bnxt_filter_info *
 785 bnxt_create_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 786                       struct bnxt_vnic_info *vnic)
 787 {
 788         struct bnxt_filter_info *filter1;
 789         int rc;
 790
 791         /* Alloc new L2 filter.
 792          * This flow needs MAC filter which does not match any existing
 793          * L2 filters.
 794          */
 795         filter1 = bnxt_get_unused_filter(bp);
 796         if (filter1 == NULL)
 797                 return NULL;
 798
 799         memcpy(filter1, nf, sizeof(*filter1));
 800
 801         filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_XDP_DISABLE;
 802         filter1->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;
 803         if (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 804             nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG) {
 805                 filter1->flags |=
 806                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 807                 PMD_DRV_LOG(DEBUG, "Create Outer filter\n");
 808         }
 809
 810         if (nf->filter_type == HWRM_CFA_L2_FILTER &&
 811             (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 812              nf->valid_flags & BNXT_FLOW_L2_INNER_SRC_VALID_FLAG)) {
 813                 PMD_DRV_LOG(DEBUG, "Create L2 filter for SRC MAC\n");
 814                 filter1->flags |=
 815                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_SOURCE_VALID;
 816                 memcpy(filter1->l2_addr, nf->src_macaddr, RTE_ETHER_ADDR_LEN);
 817         } else {
 818                 PMD_DRV_LOG(DEBUG, "Create L2 filter for DST MAC\n");
 819                 memcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);
 820         }
 821
 822         if (nf->priority &&
 823             (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||
 824              nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 825                 /* Tell the FW where to place the filter in the table. */
 826                 if (nf->priority > 65535) {
 827                         filter1->pri_hint =
 828                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;
 829                         /* This will place the filter in TCAM */
 830                         filter1->l2_filter_id_hint = (uint64_t)-1;
 831                 }
 832         }
 833
 834         if (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |
 835                                BNXT_FLOW_L2_SRC_VALID_FLAG |
 836                                BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 837                                BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 838                 filter1->enables =
 839                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
 840                         L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;
 841                 memset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 842         }
 843
 844         if (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {
 845                 filter1->flags |=
 846                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;
 847                 if (nf->ethertype == RTE_ETHER_TYPE_IPV4) {
 848                         /* Num VLANs for drop filter will/should be 0.
 849                          * If the req is memset to 0, then the count will
 850                          * be automatically set to 0.
 851                          */
 852                         if (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {
 853                                 filter1->enables |=
 854                                         L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;
 855                         } else {
 856                                 filter1->enables |=
 857                                         L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;
 858                                 filter1->flags |=
 859                                 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 860                         }
 861                 }
 862         }
 863
 864         rc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,
 865                                      filter1);
 866         if (rc) {
 867                 bnxt_free_filter(bp, filter1);
 868                 return NULL;
 869         }
 870         filter1->l2_ref_cnt++;
 871         return filter1;
 872 }
 873
 874 struct bnxt_filter_info *
 875 bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 876                    struct bnxt_vnic_info *vnic)
 877 {
 878         struct bnxt_filter_info *l2_filter = NULL;
 879
 880         l2_filter = bnxt_find_matching_l2_filter(bp, nf);
 881         if (l2_filter) {
 882                 l2_filter->l2_ref_cnt++;
 883         } else {
 884                 l2_filter = bnxt_create_l2_filter(bp, nf, vnic);
 885                 if (l2_filter) {
 886                         STAILQ_INSERT_TAIL(&vnic->filter, l2_filter, next);
 887                         l2_filter->vnic = vnic;
 888                 }
 889         }
 890         nf->matching_l2_fltr_ptr = l2_filter;
 891
 892         return l2_filter;
 893 }
 894
 895 static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 896 {
 897         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
 898         uint64_t rx_offloads = dev_conf->rxmode.offloads;
 899         int rc;
 900
 901         rc = bnxt_vnic_grp_alloc(bp, vnic);
 902         if (rc)
 903                 goto ret;
 904
 905         rc = bnxt_hwrm_vnic_alloc(bp, vnic);
 906         if (rc) {
 907                 PMD_DRV_LOG(ERR, "HWRM vnic alloc failure rc: %x\n", rc);
 908                 goto ret;
 909         }
 910         bp->nr_vnics++;
 911
 912         /* RSS context is required only when there is more than one RSS ring */
 913         if (vnic->rx_queue_cnt > 1) {
 914                 rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0 /* ctx_idx 0 */);
 915                 if (rc) {
 916                         PMD_DRV_LOG(ERR,
 917                                     "HWRM vnic ctx alloc failure: %x\n", rc);
 918                         goto ret;
 919                 }
 920         } else {
 921                 PMD_DRV_LOG(DEBUG, "No RSS context required\n");
 922         }
 923
 924         if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
 925                 vnic->vlan_strip = true;
 926         else
 927                 vnic->vlan_strip = false;
 928
 929         rc = bnxt_hwrm_vnic_cfg(bp, vnic);
 930         if (rc)
 931                 goto ret;
 932
 933         bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
 934
 935 ret:
 936         return rc;
 937 }
 938
 939 static int match_vnic_rss_cfg(struct bnxt *bp,
 940                               struct bnxt_vnic_info *vnic,
 941                               const struct rte_flow_action_rss *rss)
 942 {
 943         unsigned int match = 0, i;
 944
 945         if (vnic->rx_queue_cnt != rss->queue_num)
 946                 return -EINVAL;
 947
 948         for (i = 0; i < rss->queue_num; i++) {
 949                 if (!bp->rx_queues[rss->queue[i]]->vnic->rx_queue_cnt &&
 950                     !bp->rx_queues[rss->queue[i]]->rx_started)
 951                         return -EINVAL;
 952         }
 953
 954         for (i = 0; i < vnic->rx_queue_cnt; i++) {
 955                 int j;
 956
 957                 for (j = 0; j < vnic->rx_queue_cnt; j++) {
 958                         if (bp->grp_info[rss->queue[i]].fw_grp_id ==
 959                             vnic->fw_grp_ids[j])
 960                                 match++;
 961                 }
 962         }
 963
 964         if (match != vnic->rx_queue_cnt) {
 965                 PMD_DRV_LOG(ERR,
 966                             "VNIC queue count %d vs queues matched %d\n",
 967                             match, vnic->rx_queue_cnt);
 968                 return -EINVAL;
 969         }
 970
 971         return 0;
 972 }
 973
 974 static void
 975 bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,
 976                             struct bnxt_filter_info *filter1,
 977                             int use_ntuple)
 978 {
 979         if (!use_ntuple &&
 980             !(filter->valid_flags &
 981               ~(BNXT_FLOW_L2_DST_VALID_FLAG |
 982                 BNXT_FLOW_L2_SRC_VALID_FLAG |
 983                 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 984                 BNXT_FLOW_L2_INNER_DST_VALID_FLAG |
 985                 BNXT_FLOW_L2_DROP_FLAG |
 986                 BNXT_FLOW_PARSE_INNER_FLAG))) {
 987                 filter->flags = filter1->flags;
 988                 filter->enables = filter1->enables;
 989                 filter->filter_type = HWRM_CFA_L2_FILTER;
 990                 memcpy(filter->l2_addr, filter1->l2_addr, RTE_ETHER_ADDR_LEN);
 991                 memset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 992                 filter->pri_hint = filter1->pri_hint;
 993                 filter->l2_filter_id_hint = filter1->l2_filter_id_hint;
 994         }
 995         filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
 996         filter->l2_ref_cnt = filter1->l2_ref_cnt;
 997         PMD_DRV_LOG(DEBUG,
 998                 "l2_filter: %p fw_l2_filter_id %" PRIx64 " l2_ref_cnt %u\n",
 999                 filter1, filter->fw_l2_filter_id, filter->l2_ref_cnt);
1000 }
1001
1002 static int
1003 bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
1004                              const struct rte_flow_item pattern[],
1005                              const struct rte_flow_action actions[],
1006                              const struct rte_flow_attr *attr,
1007                              struct rte_flow_error *error,
1008                              struct bnxt_filter_info *filter)
1009 {
1010         const struct rte_flow_action *act =
1011                 bnxt_flow_non_void_action(actions);
1012         struct bnxt *bp = dev->data->dev_private;
1013         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
1014         struct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;
1015         const struct rte_flow_action_queue *act_q;
1016         const struct rte_flow_action_vf *act_vf;
1017         struct bnxt_filter_info *filter1 = NULL;
1018         const struct rte_flow_action_rss *rss;
1019         struct bnxt_rx_queue *rxq = NULL;
1020         int dflt_vnic, vnic_id;
1021         unsigned int rss_idx;
1022         uint32_t vf = 0, i;
1023         int rc, use_ntuple;
1024
1025         rc =
1026         bnxt_validate_and_parse_flow_type(bp, attr, pattern, error, filter);
1027         if (rc != 0)
1028                 goto ret;
1029
1030         rc = bnxt_flow_parse_attr(attr, error);
1031         if (rc != 0)
1032                 goto ret;
1033
1034         /* Since we support ingress attribute only - right now. */
1035         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1036                 filter->flags = HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_PATH_RX;
1037
1038         use_ntuple = bnxt_filter_type_check(pattern, error);
1039         switch (act->type) {
1040         case RTE_FLOW_ACTION_TYPE_QUEUE:
1041                 /* Allow this flow. Redirect to a VNIC. */
1042                 act_q = (const struct rte_flow_action_queue *)act->conf;
1043                 if (!act_q->index || act_q->index >= bp->rx_nr_rings) {
1044                         rte_flow_error_set(error,
1045                                            EINVAL,
1046                                            RTE_FLOW_ERROR_TYPE_ACTION,
1047                                            act,
1048                                            "Invalid queue ID.");
1049                         rc = -rte_errno;
1050                         goto ret;
1051                 }
1052                 PMD_DRV_LOG(DEBUG, "Queue index %d\n", act_q->index);
1053
1054                 vnic_id = attr->group;
1055                 if (!vnic_id) {
1056                         PMD_DRV_LOG(DEBUG, "Group id is 0\n");
1057                         vnic_id = act_q->index;
1058                 }
1059
1060                 vnic = &bp->vnic_info[vnic_id];
1061                 if (vnic == NULL) {
1062                         rte_flow_error_set(error,
1063                                            EINVAL,
1064                                            RTE_FLOW_ERROR_TYPE_ACTION,
1065                                            act,
1066                                            "No matching VNIC found.");
1067                         rc = -rte_errno;
1068                         goto ret;
1069                 }
1070                 if (vnic->rx_queue_cnt) {
1071                         if (vnic->start_grp_id != act_q->index) {
1072                                 PMD_DRV_LOG(ERR,
1073                                             "VNIC already in use\n");
1074                                 rte_flow_error_set(error,
1075                                                    EINVAL,
1076                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1077                                                    act,
1078                                                    "VNIC already in use");
1079                                 rc = -rte_errno;
1080                                 goto ret;
1081                         }
1082                         goto use_vnic;
1083                 }
1084
1085                 rxq = bp->rx_queues[act_q->index];
1086
1087                 if (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) && rxq &&
1088                     vnic->fw_vnic_id != INVALID_HW_RING_ID)
1089                         goto use_vnic;
1090
1091                 if (!rxq) {
1092                         PMD_DRV_LOG(ERR,
1093                                     "Queue invalid or used with other VNIC\n");
1094                         rte_flow_error_set(error,
1095                                            EINVAL,
1096                                            RTE_FLOW_ERROR_TYPE_ACTION,
1097                                            act,
1098                                            "Queue invalid queue or in use");
1099                         rc = -rte_errno;
1100                         goto ret;
1101                 }
1102
1103                 rxq->vnic = vnic;
1104                 rxq->rx_started = 1;
1105                 vnic->rx_queue_cnt++;
1106                 vnic->start_grp_id = act_q->index;
1107                 vnic->end_grp_id = act_q->index;
1108                 vnic->func_default = 0; //This is not a default VNIC.
1109
1110                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1111
1112                 rc = bnxt_vnic_prep(bp, vnic);
1113                 if (rc)  {
1114                         rte_flow_error_set(error,
1115                                            EINVAL,
1116                                            RTE_FLOW_ERROR_TYPE_ACTION,
1117                                            act,
1118                                            "VNIC prep fail");
1119                         rc = -rte_errno;
1120                         goto ret;
1121                 }
1122
1123                 PMD_DRV_LOG(DEBUG,
1124                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1125                             act_q->index, vnic, vnic->fw_grp_ids);
1126
1127 use_vnic:
1128                 vnic->ff_pool_idx = vnic_id;
1129                 PMD_DRV_LOG(DEBUG,
1130                             "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
1131                 filter->dst_id = vnic->fw_vnic_id;
1132
1133                 /* For ntuple filter, create the L2 filter with default VNIC.
1134                  * The user specified redirect queue will be set while creating
1135                  * the ntuple filter in hardware.
1136                  */
1137                 vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
1138                 if (use_ntuple)
1139                         filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1140                 else
1141                         filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1142                 if (filter1 == NULL) {
1143                         rte_flow_error_set(error,
1144                                            ENOSPC,
1145                                            RTE_FLOW_ERROR_TYPE_ACTION,
1146                                            act,
1147                                            "Filter not available");
1148                         rc = -rte_errno;
1149                         goto ret;
1150                 }
1151
1152                 PMD_DRV_LOG(DEBUG, "new fltr: %p l2fltr: %p l2_ref_cnt: %d\n",
1153                             filter, filter1, filter1->l2_ref_cnt);
1154                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1155                 break;
1156         case RTE_FLOW_ACTION_TYPE_DROP:
1157                 vnic0 = &bp->vnic_info[0];
1158                 filter->dst_id = vnic0->fw_vnic_id;
1159                 filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
1160                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1161                 if (filter1 == NULL) {
1162                         rte_flow_error_set(error,
1163                                            ENOSPC,
1164                                            RTE_FLOW_ERROR_TYPE_ACTION,
1165                                            act,
1166                                            "Filter not available");
1167                         rc = -rte_errno;
1168                         goto ret;
1169                 }
1170
1171                 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1172                         filter->flags =
1173                                 HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
1174                 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1175                         filter->flags =
1176                                 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
1177
1178                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1179                 break;
1180         case RTE_FLOW_ACTION_TYPE_COUNT:
1181                 vnic0 = &bp->vnic_info[0];
1182                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1183                 if (filter1 == NULL) {
1184                         rte_flow_error_set(error,
1185                                            ENOSPC,
1186                                            RTE_FLOW_ERROR_TYPE_ACTION,
1187                                            act,
1188                                            "New filter not available");
1189                         rc = -rte_errno;
1190                         goto ret;
1191                 }
1192
1193                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1194                 filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_METER;
1195                 break;
1196         case RTE_FLOW_ACTION_TYPE_VF:
1197                 act_vf = (const struct rte_flow_action_vf *)act->conf;
1198                 vf = act_vf->id;
1199
1200                 if (filter->tunnel_type ==
1201                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN ||
1202                     filter->tunnel_type ==
1203                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE) {
1204                         /* If issued on a VF, ensure id is 0 and is trusted */
1205                         if (BNXT_VF(bp)) {
1206                                 if (!BNXT_VF_IS_TRUSTED(bp) || vf) {
1207                                         rte_flow_error_set(error, EINVAL,
1208                                                 RTE_FLOW_ERROR_TYPE_ACTION,
1209                                                 act,
1210                                                 "Incorrect VF");
1211                                         rc = -rte_errno;
1212                                         goto ret;
1213                                 }
1214                         }
1215
1216                         filter->enables |= filter->tunnel_type;
1217                         filter->filter_type = HWRM_CFA_TUNNEL_REDIRECT_FILTER;
1218                         goto done;
1219                 }
1220
1221                 if (vf >= bp->pdev->max_vfs) {
1222                         rte_flow_error_set(error,
1223                                            EINVAL,
1224                                            RTE_FLOW_ERROR_TYPE_ACTION,
1225                                            act,
1226                                            "Incorrect VF id!");
1227                         rc = -rte_errno;
1228                         goto ret;
1229                 }
1230
1231                 filter->mirror_vnic_id =
1232                 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
1233                 if (dflt_vnic < 0) {
1234                         /* This simply indicates there's no driver loaded.
1235                          * This is not an error.
1236                          */
1237                         rte_flow_error_set(error,
1238                                            EINVAL,
1239                                            RTE_FLOW_ERROR_TYPE_ACTION,
1240                                            act,
1241                                            "Unable to get default VNIC for VF");
1242                         rc = -rte_errno;
1243                         goto ret;
1244                 }
1245
1246                 filter->mirror_vnic_id = dflt_vnic;
1247                 filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
1248
1249                 vnic0 = &bp->vnic_info[0];
1250                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1251                 if (filter1 == NULL) {
1252                         rte_flow_error_set(error,
1253                                            ENOSPC,
1254                                            RTE_FLOW_ERROR_TYPE_ACTION,
1255                                            act,
1256                                            "New filter not available");
1257                         rc = -rte_errno;
1258                         goto ret;
1259                 }
1260
1261                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1262                 break;
1263         case RTE_FLOW_ACTION_TYPE_RSS:
1264                 rss = (const struct rte_flow_action_rss *)act->conf;
1265
1266                 vnic_id = attr->group;
1267                 if (!vnic_id) {
1268                         PMD_DRV_LOG(ERR, "Group id cannot be 0\n");
1269                         rte_flow_error_set(error,
1270                                            EINVAL,
1271                                            RTE_FLOW_ERROR_TYPE_ATTR,
1272                                            NULL,
1273                                            "Group id cannot be 0");
1274                         rc = -rte_errno;
1275                         goto ret;
1276                 }
1277
1278                 vnic = &bp->vnic_info[vnic_id];
1279                 if (vnic == NULL) {
1280                         rte_flow_error_set(error,
1281                                            EINVAL,
1282                                            RTE_FLOW_ERROR_TYPE_ACTION,
1283                                            act,
1284                                            "No matching VNIC for RSS group.");
1285                         rc = -rte_errno;
1286                         goto ret;
1287                 }
1288                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1289
1290                 /* Check if requested RSS config matches RSS config of VNIC
1291                  * only if it is not a fresh VNIC configuration.
1292                  * Otherwise the existing VNIC configuration can be used.
1293                  */
1294                 if (vnic->rx_queue_cnt) {
1295                         rc = match_vnic_rss_cfg(bp, vnic, rss);
1296                         if (rc) {
1297                                 PMD_DRV_LOG(ERR,
1298                                             "VNIC and RSS config mismatch\n");
1299                                 rte_flow_error_set(error,
1300                                                    EINVAL,
1301                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1302                                                    act,
1303                                                    "VNIC and RSS cfg mismatch");
1304                                 rc = -rte_errno;
1305                                 goto ret;
1306                         }
1307                         goto vnic_found;
1308                 }
1309
1310                 for (i = 0; i < rss->queue_num; i++) {
1311                         PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n",
1312                                     rss->queue[i]);
1313
1314                         if (!rss->queue[i] ||
1315                             rss->queue[i] >= bp->rx_nr_rings ||
1316                             !bp->rx_queues[rss->queue[i]]) {
1317                                 rte_flow_error_set(error,
1318                                                    EINVAL,
1319                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1320                                                    act,
1321                                                    "Invalid queue ID for RSS");
1322                                 rc = -rte_errno;
1323                                 goto ret;
1324                         }
1325                         rxq = bp->rx_queues[rss->queue[i]];
1326
1327                         if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1328                             INVALID_HW_RING_ID) {
1329                                 PMD_DRV_LOG(ERR,
1330                                             "queue active with other VNIC\n");
1331                                 rte_flow_error_set(error,
1332                                                    EINVAL,
1333                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1334                                                    act,
1335                                                    "Invalid queue ID for RSS");
1336                                 rc = -rte_errno;
1337                                 goto ret;
1338                         }
1339
1340                         rxq->vnic = vnic;
1341                         rxq->rx_started = 1;
1342                         vnic->rx_queue_cnt++;
1343                 }
1344
1345                 vnic->start_grp_id = rss->queue[0];
1346                 vnic->end_grp_id = rss->queue[rss->queue_num - 1];
1347                 vnic->func_default = 0; //This is not a default VNIC.
1348
1349                 rc = bnxt_vnic_prep(bp, vnic);
1350                 if (rc) {
1351                         rte_flow_error_set(error,
1352                                            EINVAL,
1353                                            RTE_FLOW_ERROR_TYPE_ACTION,
1354                                            act,
1355                                            "VNIC prep fail");
1356                         rc = -rte_errno;
1357                         goto ret;
1358                 }
1359
1360                 PMD_DRV_LOG(DEBUG,
1361                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1362                             vnic_id, vnic, vnic->fw_grp_ids);
1363
1364                 vnic->ff_pool_idx = vnic_id;
1365                 PMD_DRV_LOG(DEBUG,
1366                             "Setting vnic ff_pool_idx %d\n", vnic->ff_pool_idx);
1367
1368                 /* This can be done only after vnic_grp_alloc is done. */
1369                 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1370                         vnic->fw_grp_ids[i] =
1371                                 bp->grp_info[rss->queue[i]].fw_grp_id;
1372                         /* Make sure vnic0 does not use these rings. */
1373                         bp->vnic_info[0].fw_grp_ids[rss->queue[i]] =
1374                                 INVALID_HW_RING_ID;
1375                 }
1376
1377                 for (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; ) {
1378                         for (i = 0; i < vnic->rx_queue_cnt; i++)
1379                                 vnic->rss_table[rss_idx++] =
1380                                         vnic->fw_grp_ids[i];
1381                 }
1382
1383                 /* Configure RSS only if the queue count is > 1 */
1384                 if (vnic->rx_queue_cnt > 1) {
1385                         vnic->hash_type =
1386                                 bnxt_rte_to_hwrm_hash_types(rss->types);
1387
1388                         if (!rss->key_len) {
1389                                 /* If hash key has not been specified,
1390                                  * use random hash key.
1391                                  */
1392                                 prandom_bytes(vnic->rss_hash_key,
1393                                               HW_HASH_KEY_SIZE);
1394                         } else {
1395                                 if (rss->key_len > HW_HASH_KEY_SIZE)
1396                                         memcpy(vnic->rss_hash_key,
1397                                                rss->key,
1398                                                HW_HASH_KEY_SIZE);
1399                                 else
1400                                         memcpy(vnic->rss_hash_key,
1401                                                rss->key,
1402                                                rss->key_len);
1403                         }
1404                         bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1405                 } else {
1406                         PMD_DRV_LOG(DEBUG, "No RSS config required\n");
1407                 }
1408
1409 vnic_found:
1410                 filter->dst_id = vnic->fw_vnic_id;
1411                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1412                 if (filter1 == NULL) {
1413                         rte_flow_error_set(error,
1414                                            ENOSPC,
1415                                            RTE_FLOW_ERROR_TYPE_ACTION,
1416                                            act,
1417                                            "New filter not available");
1418                         rc = -rte_errno;
1419                         goto ret;
1420                 }
1421
1422                 PMD_DRV_LOG(DEBUG, "L2 filter created\n");
1423                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1424                 break;
1425         default:
1426                 rte_flow_error_set(error,
1427                                    EINVAL,
1428                                    RTE_FLOW_ERROR_TYPE_ACTION,
1429                                    act,
1430                                    "Invalid action.");
1431                 rc = -rte_errno;
1432                 goto ret;
1433         }
1434
1435 done:
1436         act = bnxt_flow_non_void_action(++act);
1437         if (act->type != RTE_FLOW_ACTION_TYPE_END) {
1438                 rte_flow_error_set(error,
1439                                    EINVAL,
1440                                    RTE_FLOW_ERROR_TYPE_ACTION,
1441                                    act,
1442                                    "Invalid action.");
1443                 rc = -rte_errno;
1444                 goto ret;
1445         }
1446
1447         return rc;
1448 ret:
1449
1450         //TODO: Cleanup according to ACTION TYPE.
1451         if (rte_errno)  {
1452                 if (vnic && STAILQ_EMPTY(&vnic->filter))
1453                         vnic->rx_queue_cnt = 0;
1454
1455                 if (rxq && !vnic->rx_queue_cnt)
1456                         rxq->vnic = &bp->vnic_info[0];
1457         }
1458         return rc;
1459 }
1460
1461 static
1462 struct bnxt_vnic_info *find_matching_vnic(struct bnxt *bp,
1463                                           struct bnxt_filter_info *filter)
1464 {
1465         struct bnxt_vnic_info *vnic = NULL;
1466         unsigned int i;
1467
1468         for (i = 0; i < bp->max_vnics; i++) {
1469                 vnic = &bp->vnic_info[i];
1470                 if (vnic->fw_vnic_id != INVALID_VNIC_ID &&
1471                     filter->dst_id == vnic->fw_vnic_id) {
1472                         PMD_DRV_LOG(DEBUG, "Found matching VNIC Id %d\n",
1473                                     vnic->ff_pool_idx);
1474                         return vnic;
1475                 }
1476         }
1477         return NULL;
1478 }
1479
1480 static int
1481 bnxt_flow_validate(struct rte_eth_dev *dev,
1482                    const struct rte_flow_attr *attr,
1483                    const struct rte_flow_item pattern[],
1484                    const struct rte_flow_action actions[],
1485                    struct rte_flow_error *error)
1486 {
1487         struct bnxt *bp = dev->data->dev_private;
1488         struct bnxt_vnic_info *vnic = NULL;
1489         struct bnxt_filter_info *filter;
1490         int ret = 0;
1491
1492         bnxt_acquire_flow_lock(bp);
1493         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1494         if (ret != 0) {
1495                 bnxt_release_flow_lock(bp);
1496                 return ret;
1497         }
1498
1499         filter = bnxt_get_unused_filter(bp);
1500         if (filter == NULL) {
1501                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1502                 bnxt_release_flow_lock(bp);
1503                 return -ENOMEM;
1504         }
1505
1506         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1507                                            error, filter);
1508         if (ret)
1509                 goto exit;
1510
1511         vnic = find_matching_vnic(bp, filter);
1512         if (vnic) {
1513                 if (STAILQ_EMPTY(&vnic->filter)) {
1514                         rte_free(vnic->fw_grp_ids);
1515                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1516                         bnxt_hwrm_vnic_free(bp, vnic);
1517                         vnic->rx_queue_cnt = 0;
1518                         PMD_DRV_LOG(DEBUG, "Free VNIC\n");
1519                 }
1520         }
1521
1522         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1523                 bnxt_hwrm_clear_em_filter(bp, filter);
1524         else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1525                 bnxt_hwrm_clear_ntuple_filter(bp, filter);
1526         else
1527                 bnxt_hwrm_clear_l2_filter(bp, filter);
1528
1529 exit:
1530         /* No need to hold on to this filter if we are just validating flow */
1531         bnxt_free_filter(bp, filter);
1532         bnxt_release_flow_lock(bp);
1533
1534         return ret;
1535 }
1536
1537 static void
1538 bnxt_update_filter(struct bnxt *bp, struct bnxt_filter_info *old_filter,
1539                    struct bnxt_filter_info *new_filter)
1540 {
1541         /* Clear the new L2 filter that was created in the previous step in
1542          * bnxt_validate_and_parse_flow. For L2 filters, we will use the new
1543          * filter which points to the new destination queue and so we clear
1544          * the previous L2 filter. For ntuple filters, we are going to reuse
1545          * the old L2 filter and create new NTUPLE filter with this new
1546          * destination queue subsequently during bnxt_flow_create. So we
1547          * decrement the ref cnt of the L2 filter that would've been bumped
1548          * up previously in bnxt_validate_and_parse_flow as the old n-tuple
1549          * filter that was referencing it will be deleted now.
1550          */
1551         bnxt_hwrm_clear_l2_filter(bp, old_filter);
1552         if (new_filter->filter_type == HWRM_CFA_L2_FILTER) {
1553                 bnxt_hwrm_set_l2_filter(bp, new_filter->dst_id, new_filter);
1554         } else {
1555                 if (new_filter->filter_type == HWRM_CFA_EM_FILTER)
1556                         bnxt_hwrm_clear_em_filter(bp, old_filter);
1557                 if (new_filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1558                         bnxt_hwrm_clear_ntuple_filter(bp, old_filter);
1559         }
1560 }
1561
1562 static int
1563 bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
1564 {
1565         struct bnxt_filter_info *mf;
1566         struct rte_flow *flow;
1567         int i;
1568
1569         for (i = bp->max_vnics - 1; i >= 0; i--) {
1570                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
1571
1572                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
1573                         continue;
1574
1575                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
1576                         mf = flow->filter;
1577
1578                         if (mf->filter_type == nf->filter_type &&
1579                             mf->flags == nf->flags &&
1580                             mf->src_port == nf->src_port &&
1581                             mf->src_port_mask == nf->src_port_mask &&
1582                             mf->dst_port == nf->dst_port &&
1583                             mf->dst_port_mask == nf->dst_port_mask &&
1584                             mf->ip_protocol == nf->ip_protocol &&
1585                             mf->ip_addr_type == nf->ip_addr_type &&
1586                             mf->ethertype == nf->ethertype &&
1587                             mf->vni == nf->vni &&
1588                             mf->tunnel_type == nf->tunnel_type &&
1589                             mf->l2_ovlan == nf->l2_ovlan &&
1590                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
1591                             mf->l2_ivlan == nf->l2_ivlan &&
1592                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
1593                             !memcmp(mf->l2_addr, nf->l2_addr,
1594                                     RTE_ETHER_ADDR_LEN) &&
1595                             !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
1596                                     RTE_ETHER_ADDR_LEN) &&
1597                             !memcmp(mf->src_macaddr, nf->src_macaddr,
1598                                     RTE_ETHER_ADDR_LEN) &&
1599                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
1600                                     RTE_ETHER_ADDR_LEN) &&
1601                             !memcmp(mf->src_ipaddr, nf->src_ipaddr,
1602                                     sizeof(nf->src_ipaddr)) &&
1603                             !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
1604                                     sizeof(nf->src_ipaddr_mask)) &&
1605                             !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
1606                                     sizeof(nf->dst_ipaddr)) &&
1607                             !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
1608                                     sizeof(nf->dst_ipaddr_mask))) {
1609                                 if (mf->dst_id == nf->dst_id)
1610                                         return -EEXIST;
1611                                 /* Free the old filter, update flow
1612                                  * with new filter
1613                                  */
1614                                 bnxt_update_filter(bp, mf, nf);
1615                                 STAILQ_REMOVE(&vnic->filter, mf,
1616                                               bnxt_filter_info, next);
1617                                 STAILQ_INSERT_TAIL(&vnic->filter, nf, next);
1618                                 bnxt_free_filter(bp, mf);
1619                                 flow->filter = nf;
1620                                 return -EXDEV;
1621                         }
1622                 }
1623         }
1624         return 0;
1625 }
1626
1627 static struct rte_flow *
1628 bnxt_flow_create(struct rte_eth_dev *dev,
1629                  const struct rte_flow_attr *attr,
1630                  const struct rte_flow_item pattern[],
1631                  const struct rte_flow_action actions[],
1632                  struct rte_flow_error *error)
1633 {
1634         struct bnxt *bp = dev->data->dev_private;
1635         struct bnxt_vnic_info *vnic = NULL;
1636         struct bnxt_filter_info *filter;
1637         bool update_flow = false;
1638         struct rte_flow *flow;
1639         int ret = 0;
1640         uint32_t tun_type;
1641
1642         if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
1643                 rte_flow_error_set(error, EINVAL,
1644                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1645                                    "Failed to create flow, Not a Trusted VF!");
1646                 return NULL;
1647         }
1648
1649         if (!dev->data->dev_started) {
1650                 rte_flow_error_set(error,
1651                                    EINVAL,
1652                                    RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
1653                                    NULL,
1654                                    "Device must be started");
1655                 return NULL;
1656         }
1657
1658         flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0);
1659         if (!flow) {
1660                 rte_flow_error_set(error, ENOMEM,
1661                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1662                                    "Failed to allocate memory");
1663                 return flow;
1664         }
1665
1666         bnxt_acquire_flow_lock(bp);
1667         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1668         if (ret != 0) {
1669                 PMD_DRV_LOG(ERR, "Not a validate flow.\n");
1670                 goto free_flow;
1671         }
1672
1673         filter = bnxt_get_unused_filter(bp);
1674         if (filter == NULL) {
1675                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1676                 goto free_flow;
1677         }
1678
1679         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1680                                            error, filter);
1681         if (ret != 0)
1682                 goto free_filter;
1683
1684         ret = bnxt_match_filter(bp, filter);
1685         if (ret == -EEXIST) {
1686                 PMD_DRV_LOG(DEBUG, "Flow already exists.\n");
1687                 /* Clear the filter that was created as part of
1688                  * validate_and_parse_flow() above
1689                  */
1690                 bnxt_hwrm_clear_l2_filter(bp, filter);
1691                 goto free_filter;
1692         } else if (ret == -EXDEV) {
1693                 PMD_DRV_LOG(DEBUG, "Flow with same pattern exists\n");
1694                 PMD_DRV_LOG(DEBUG, "Updating with different destination\n");
1695                 update_flow = true;
1696         }
1697
1698         /* If tunnel redirection to a VF/PF is specified then only tunnel_type
1699          * is set and enable is set to the tunnel type. Issue hwrm cmd directly
1700          * in such a case.
1701          */
1702         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1703             filter->enables == filter->tunnel_type) {
1704                 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1705                 if (ret) {
1706                         rte_flow_error_set(error, -ret,
1707                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1708                                            "Unable to query tunnel to VF");
1709                         goto free_filter;
1710                 }
1711                 if (tun_type == (1U << filter->tunnel_type)) {
1712                         ret =
1713                         bnxt_hwrm_tunnel_redirect_free(bp,
1714                                                        filter->tunnel_type);
1715                         if (ret) {
1716                                 PMD_DRV_LOG(ERR,
1717                                             "Unable to free existing tunnel\n");
1718                                 rte_flow_error_set(error, -ret,
1719                                                    RTE_FLOW_ERROR_TYPE_HANDLE,
1720                                                    NULL,
1721                                                    "Unable to free preexisting "
1722                                                    "tunnel on VF");
1723                                 goto free_filter;
1724                         }
1725                 }
1726                 ret = bnxt_hwrm_tunnel_redirect(bp, filter->tunnel_type);
1727                 if (ret) {
1728                         rte_flow_error_set(error, -ret,
1729                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1730                                            "Unable to redirect tunnel to VF");
1731                         goto free_filter;
1732                 }
1733                 vnic = &bp->vnic_info[0];
1734                 goto done;
1735         }
1736
1737         if (filter->filter_type == HWRM_CFA_EM_FILTER) {
1738                 filter->enables |=
1739                         HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1740                 ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter);
1741         }
1742
1743         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) {
1744                 filter->enables |=
1745                         HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1746                 ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter);
1747         }
1748
1749         vnic = find_matching_vnic(bp, filter);
1750 done:
1751         if (!ret || update_flow) {
1752                 flow->filter = filter;
1753                 flow->vnic = vnic;
1754                 if (update_flow) {
1755                         ret = -EXDEV;
1756                         goto free_flow;
1757                 }
1758
1759                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
1760                 PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
1761                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
1762                 bnxt_release_flow_lock(bp);
1763                 return flow;
1764         }
1765
1766 free_filter:
1767         bnxt_free_filter(bp, filter);
1768 free_flow:
1769         if (ret == -EEXIST)
1770                 rte_flow_error_set(error, ret,
1771                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1772                                    "Matching Flow exists.");
1773         else if (ret == -EXDEV)
1774                 rte_flow_error_set(error, 0,
1775                                    RTE_FLOW_ERROR_TYPE_NONE, NULL,
1776                                    "Flow with pattern exists, updating destination queue");
1777         else
1778                 rte_flow_error_set(error, -ret,
1779                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1780                                    "Failed to create flow.");
1781         rte_free(flow);
1782         flow = NULL;
1783         bnxt_release_flow_lock(bp);
1784         return flow;
1785 }
1786
1787 static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
1788                                                struct bnxt_filter_info *filter,
1789                                                struct rte_flow_error *error)
1790 {
1791         uint16_t tun_dst_fid;
1792         uint32_t tun_type;
1793         int ret = 0;
1794
1795         ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1796         if (ret) {
1797                 rte_flow_error_set(error, -ret,
1798                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1799                                    "Unable to query tunnel to VF");
1800                 return ret;
1801         }
1802         if (tun_type == (1U << filter->tunnel_type)) {
1803                 ret = bnxt_hwrm_tunnel_redirect_info(bp, filter->tunnel_type,
1804                                                      &tun_dst_fid);
1805                 if (ret) {
1806                         rte_flow_error_set(error, -ret,
1807                                            RTE_FLOW_ERROR_TYPE_HANDLE,
1808                                            NULL,
1809                                            "tunnel_redirect info cmd fail");
1810                         return ret;
1811                 }
1812                 PMD_DRV_LOG(INFO, "Pre-existing tunnel fid = %x vf->fid = %x\n",
1813                             tun_dst_fid + bp->first_vf_id, bp->fw_fid);
1814
1815                 /* Tunnel doesn't belong to this VF, so don't send HWRM
1816                  * cmd, just delete the flow from driver
1817                  */
1818                 if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id))
1819                         PMD_DRV_LOG(ERR,
1820                                     "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
1821                 else
1822                         ret = bnxt_hwrm_tunnel_redirect_free(bp,
1823                                                         filter->tunnel_type);
1824         }
1825         return ret;
1826 }
1827
1828 static int
1829 _bnxt_flow_destroy(struct bnxt *bp,
1830                    struct rte_flow *flow,
1831                     struct rte_flow_error *error)
1832 {
1833         struct bnxt_filter_info *filter;
1834         struct bnxt_vnic_info *vnic;
1835         int ret = 0;
1836
1837         filter = flow->filter;
1838         vnic = flow->vnic;
1839
1840         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1841             filter->enables == filter->tunnel_type) {
1842                 ret = bnxt_handle_tunnel_redirect_destroy(bp, filter, error);
1843                 if (!ret)
1844                         goto done;
1845                 else
1846                         return ret;
1847         }
1848
1849         ret = bnxt_match_filter(bp, filter);
1850         if (ret == 0)
1851                 PMD_DRV_LOG(ERR, "Could not find matching flow\n");
1852
1853         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1854                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1855         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1856                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1857         ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1858
1859 done:
1860         if (!ret) {
1861                 /* If it is a L2 drop filter, when the filter is created,
1862                  * the FW updates the BC/MC records.
1863                  * Once this filter is removed, issue the set_rx_mask command
1864                  * to reset the BC/MC records in the HW to the settings
1865                  * before the drop counter is created.
1866                  */
1867                 if (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)
1868                         bnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);
1869
1870                 STAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);
1871                 bnxt_free_filter(bp, filter);
1872                 STAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);
1873                 rte_free(flow);
1874
1875                 /* If this was the last flow associated with this vnic,
1876                  * switch the queue back to RSS pool.
1877                  */
1878                 if (vnic && !vnic->func_default &&
1879                     STAILQ_EMPTY(&vnic->flow_list)) {
1880                         rte_free(vnic->fw_grp_ids);
1881                         if (vnic->rx_queue_cnt > 1)
1882                                 bnxt_hwrm_vnic_ctx_free(bp, vnic);
1883
1884                         bnxt_hwrm_vnic_free(bp, vnic);
1885                         vnic->rx_queue_cnt = 0;
1886                 }
1887         } else {
1888                 rte_flow_error_set(error, -ret,
1889                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1890                                    "Failed to destroy flow.");
1891         }
1892
1893         return ret;
1894 }
1895
1896 static int
1897 bnxt_flow_destroy(struct rte_eth_dev *dev,
1898                   struct rte_flow *flow,
1899                   struct rte_flow_error *error)
1900 {
1901         struct bnxt *bp = dev->data->dev_private;
1902         int ret = 0;
1903
1904         bnxt_acquire_flow_lock(bp);
1905         if (!flow) {
1906                 rte_flow_error_set(error, EINVAL,
1907                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1908                                    "Invalid flow: failed to destroy flow.");
1909                 bnxt_release_flow_lock(bp);
1910                 return -EINVAL;
1911         }
1912
1913         if (!flow->filter) {
1914                 rte_flow_error_set(error, EINVAL,
1915                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1916                                    "Invalid flow: failed to destroy flow.");
1917                 bnxt_release_flow_lock(bp);
1918                 return -EINVAL;
1919         }
1920         ret = _bnxt_flow_destroy(bp, flow, error);
1921         bnxt_release_flow_lock(bp);
1922
1923         return ret;
1924 }
1925
1926 static int
1927 bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
1928 {
1929         struct bnxt *bp = dev->data->dev_private;
1930         struct bnxt_vnic_info *vnic;
1931         struct rte_flow *flow;
1932         unsigned int i;
1933         int ret = 0;
1934
1935         bnxt_acquire_flow_lock(bp);
1936         for (i = 0; i < bp->max_vnics; i++) {
1937                 vnic = &bp->vnic_info[i];
1938                 if (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)
1939                         continue;
1940
1941                 while (!STAILQ_EMPTY(&vnic->flow_list)) {
1942                         flow = STAILQ_FIRST(&vnic->flow_list);
1943
1944                         if (!flow->filter)
1945                                 continue;
1946
1947                         ret = _bnxt_flow_destroy(bp, flow, error);
1948                         if (ret)
1949                                 break;
1950                 }
1951         }
1952         bnxt_release_flow_lock(bp);
1953
1954         return ret;
1955 }
1956
1957 const struct rte_flow_ops bnxt_flow_ops = {
1958         .validate = bnxt_flow_validate,
1959         .create = bnxt_flow_create,
1960         .destroy = bnxt_flow_destroy,
1961         .flush = bnxt_flow_flush,
1962 };