855994a6b02c2550fb6fde65071e0a2413a57b5b
[dpdk.git] / drivers / net / bnxt / bnxt_flow.c
1 /* SPDX-License-Identifier: BSD-3-Clause
2  * Copyright(c) 2014-2018 Broadcom
3  * All rights reserved.
4  */
5
6 #include <sys/queue.h>
7
8 #include <rte_log.h>
9 #include <rte_malloc.h>
10 #include <rte_flow.h>
11 #include <rte_flow_driver.h>
12 #include <rte_tailq.h>
13
14 #include "bnxt.h"
15 #include "bnxt_filter.h"
16 #include "bnxt_hwrm.h"
17 #include "bnxt_ring.h"
18 #include "bnxt_rxq.h"
19 #include "bnxt_vnic.h"
20 #include "hsi_struct_def_dpdk.h"
21
22 static int
23 bnxt_flow_args_validate(const struct rte_flow_attr *attr,
24                         const struct rte_flow_item pattern[],
25                         const struct rte_flow_action actions[],
26                         struct rte_flow_error *error)
27 {
28         if (!pattern) {
29                 rte_flow_error_set(error,
30                                    EINVAL,
31                                    RTE_FLOW_ERROR_TYPE_ITEM_NUM,
32                                    NULL,
33                                    "NULL pattern.");
34                 return -rte_errno;
35         }
36
37         if (!actions) {
38                 rte_flow_error_set(error,
39                                    EINVAL,
40                                    RTE_FLOW_ERROR_TYPE_ACTION_NUM,
41                                    NULL,
42                                    "NULL action.");
43                 return -rte_errno;
44         }
45
46         if (!attr) {
47                 rte_flow_error_set(error,
48                                    EINVAL,
49                                    RTE_FLOW_ERROR_TYPE_ATTR,
50                                    NULL,
51                                    "NULL attribute.");
52                 return -rte_errno;
53         }
54
55         return 0;
56 }
57
58 static const struct rte_flow_item *
59 bnxt_flow_non_void_item(const struct rte_flow_item *cur)
60 {
61         while (1) {
62                 if (cur->type != RTE_FLOW_ITEM_TYPE_VOID)
63                         return cur;
64                 cur++;
65         }
66 }
67
68 static const struct rte_flow_action *
69 bnxt_flow_non_void_action(const struct rte_flow_action *cur)
70 {
71         while (1) {
72                 if (cur->type != RTE_FLOW_ACTION_TYPE_VOID)
73                         return cur;
74                 cur++;
75         }
76 }
77
78 static int
79 bnxt_filter_type_check(const struct rte_flow_item pattern[],
80                        struct rte_flow_error *error)
81 {
82         const struct rte_flow_item *item =
83                 bnxt_flow_non_void_item(pattern);
84         int use_ntuple = 1;
85         bool has_vlan = 0;
86
87         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
88                 switch (item->type) {
89                 case RTE_FLOW_ITEM_TYPE_ANY:
90                 case RTE_FLOW_ITEM_TYPE_ETH:
91                         use_ntuple = 0;
92                         break;
93                 case RTE_FLOW_ITEM_TYPE_VLAN:
94                         use_ntuple = 0;
95                         has_vlan = 1;
96                         break;
97                 case RTE_FLOW_ITEM_TYPE_IPV4:
98                 case RTE_FLOW_ITEM_TYPE_IPV6:
99                 case RTE_FLOW_ITEM_TYPE_TCP:
100                 case RTE_FLOW_ITEM_TYPE_UDP:
101                         /* FALLTHROUGH */
102                         /* need ntuple match, reset exact match */
103                         use_ntuple |= 1;
104                         break;
105                 default:
106                         PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
107                         use_ntuple |= 0;
108                 }
109                 item++;
110         }
111
112         if (has_vlan && use_ntuple) {
113                 PMD_DRV_LOG(ERR,
114                             "VLAN flow cannot use NTUPLE filter\n");
115                 rte_flow_error_set(error, EINVAL,
116                                    RTE_FLOW_ERROR_TYPE_ITEM,
117                                    item,
118                                    "Cannot use VLAN with NTUPLE");
119                 return -rte_errno;
120         }
121
122         return use_ntuple;
123 }
124
125 static int
126 bnxt_validate_and_parse_flow_type(struct bnxt *bp,
127                                   const struct rte_flow_attr *attr,
128                                   const struct rte_flow_item pattern[],
129                                   struct rte_flow_error *error,
130                                   struct bnxt_filter_info *filter)
131 {
132         const struct rte_flow_item *item = bnxt_flow_non_void_item(pattern);
133         const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
134         const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
135         const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
136         const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
137         const struct rte_flow_item_udp *udp_spec, *udp_mask;
138         const struct rte_flow_item_eth *eth_spec, *eth_mask;
139         const struct rte_ether_addr *dst, *src;
140         const struct rte_flow_item_nvgre *nvgre_spec;
141         const struct rte_flow_item_nvgre *nvgre_mask;
142         const struct rte_flow_item_gre *gre_spec;
143         const struct rte_flow_item_gre *gre_mask;
144         const struct rte_flow_item_vxlan *vxlan_spec;
145         const struct rte_flow_item_vxlan *vxlan_mask;
146         uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
147         uint8_t tni_mask[] = {0xFF, 0xFF, 0xFF};
148         const struct rte_flow_item_vf *vf_spec;
149         uint32_t tenant_id_be = 0, valid_flags = 0;
150         bool vni_masked = 0;
151         bool tni_masked = 0;
152         uint32_t en_ethertype;
153         uint8_t inner = 0;
154         uint32_t vf = 0;
155         uint32_t en = 0;
156         int use_ntuple;
157         int dflt_vnic;
158
159         use_ntuple = bnxt_filter_type_check(pattern, error);
160         if (use_ntuple < 0)
161                 return use_ntuple;
162         PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
163
164         filter->filter_type = use_ntuple ?
165                 HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_L2_FILTER;
166         en_ethertype = use_ntuple ?
167                 NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE :
168                 EM_FLOW_ALLOC_INPUT_EN_ETHERTYPE;
169
170         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
171                 if (item->last) {
172                         /* last or range is NOT supported as match criteria */
173                         rte_flow_error_set(error, EINVAL,
174                                            RTE_FLOW_ERROR_TYPE_ITEM,
175                                            item,
176                                            "No support for range");
177                         return -rte_errno;
178                 }
179
180                 switch (item->type) {
181                 case RTE_FLOW_ITEM_TYPE_ANY:
182                         inner =
183                         ((const struct rte_flow_item_any *)item->spec)->num > 3;
184                         if (inner)
185                                 PMD_DRV_LOG(DEBUG, "Parse inner header\n");
186                         break;
187                 case RTE_FLOW_ITEM_TYPE_ETH:
188                         if (!item->spec || !item->mask)
189                                 break;
190
191                         eth_spec = item->spec;
192                         eth_mask = item->mask;
193
194                         /* Source MAC address mask cannot be partially set.
195                          * Should be All 0's or all 1's.
196                          * Destination MAC address mask must not be partially
197                          * set. Should be all 1's or all 0's.
198                          */
199                         if ((!rte_is_zero_ether_addr(&eth_mask->src) &&
200                              !rte_is_broadcast_ether_addr(&eth_mask->src)) ||
201                             (!rte_is_zero_ether_addr(&eth_mask->dst) &&
202                              !rte_is_broadcast_ether_addr(&eth_mask->dst))) {
203                                 rte_flow_error_set(error,
204                                                    EINVAL,
205                                                    RTE_FLOW_ERROR_TYPE_ITEM,
206                                                    item,
207                                                    "MAC_addr mask not valid");
208                                 return -rte_errno;
209                         }
210
211                         /* Mask is not allowed. Only exact matches are */
212                         if (eth_mask->type &&
213                             eth_mask->type != RTE_BE16(0xffff)) {
214                                 rte_flow_error_set(error, EINVAL,
215                                                    RTE_FLOW_ERROR_TYPE_ITEM,
216                                                    item,
217                                                    "ethertype mask not valid");
218                                 return -rte_errno;
219                         }
220
221                         if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
222                                 dst = &eth_spec->dst;
223                                 if (!rte_is_valid_assigned_ether_addr(dst)) {
224                                         rte_flow_error_set(error,
225                                                            EINVAL,
226                                                            RTE_FLOW_ERROR_TYPE_ITEM,
227                                                            item,
228                                                            "DMAC is invalid");
229                                         PMD_DRV_LOG(ERR,
230                                                     "DMAC is invalid!\n");
231                                         return -rte_errno;
232                                 }
233                                 rte_memcpy(filter->dst_macaddr,
234                                            &eth_spec->dst, RTE_ETHER_ADDR_LEN);
235                                 en |= use_ntuple ?
236                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
237                                         EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
238                                 valid_flags |= inner ?
239                                         BNXT_FLOW_L2_INNER_DST_VALID_FLAG :
240                                         BNXT_FLOW_L2_DST_VALID_FLAG;
241                                 filter->priority = attr->priority;
242                                 PMD_DRV_LOG(DEBUG,
243                                             "Creating a priority flow\n");
244                         }
245                         if (rte_is_broadcast_ether_addr(&eth_mask->src)) {
246                                 src = &eth_spec->src;
247                                 if (!rte_is_valid_assigned_ether_addr(src)) {
248                                         rte_flow_error_set(error,
249                                                            EINVAL,
250                                                            RTE_FLOW_ERROR_TYPE_ITEM,
251                                                            item,
252                                                            "SMAC is invalid");
253                                         PMD_DRV_LOG(ERR,
254                                                     "SMAC is invalid!\n");
255                                         return -rte_errno;
256                                 }
257                                 rte_memcpy(filter->src_macaddr,
258                                            &eth_spec->src, RTE_ETHER_ADDR_LEN);
259                                 en |= use_ntuple ?
260                                         NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
261                                         EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
262                                 valid_flags |= inner ?
263                                         BNXT_FLOW_L2_INNER_SRC_VALID_FLAG :
264                                         BNXT_FLOW_L2_SRC_VALID_FLAG;
265                         } /*
266                            * else {
267                            *  PMD_DRV_LOG(ERR, "Handle this condition\n");
268                            * }
269                            */
270                         if (eth_mask->type) {
271                                 filter->ethertype =
272                                         rte_be_to_cpu_16(eth_spec->type);
273                                 en |= en_ethertype;
274                         }
275                         if (inner)
276                                 valid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;
277
278                         break;
279                 case RTE_FLOW_ITEM_TYPE_VLAN:
280                         vlan_spec = item->spec;
281                         vlan_mask = item->mask;
282                         if (en & en_ethertype) {
283                                 rte_flow_error_set(error, EINVAL,
284                                                    RTE_FLOW_ERROR_TYPE_ITEM,
285                                                    item,
286                                                    "VLAN TPID matching is not"
287                                                    " supported");
288                                 return -rte_errno;
289                         }
290                         if (vlan_mask->tci &&
291                             vlan_mask->tci == RTE_BE16(0x0fff)) {
292                                 /* Only the VLAN ID can be matched. */
293                                 filter->l2_ovlan =
294                                         rte_be_to_cpu_16(vlan_spec->tci &
295                                                          RTE_BE16(0x0fff));
296                                 en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
297                         } else {
298                                 rte_flow_error_set(error,
299                                                    EINVAL,
300                                                    RTE_FLOW_ERROR_TYPE_ITEM,
301                                                    item,
302                                                    "VLAN mask is invalid");
303                                 return -rte_errno;
304                         }
305                         if (vlan_mask->inner_type &&
306                             vlan_mask->inner_type != RTE_BE16(0xffff)) {
307                                 rte_flow_error_set(error, EINVAL,
308                                                    RTE_FLOW_ERROR_TYPE_ITEM,
309                                                    item,
310                                                    "inner ethertype mask not"
311                                                    " valid");
312                                 return -rte_errno;
313                         }
314                         if (vlan_mask->inner_type) {
315                                 filter->ethertype =
316                                         rte_be_to_cpu_16(vlan_spec->inner_type);
317                                 en |= en_ethertype;
318                         }
319
320                         break;
321                 case RTE_FLOW_ITEM_TYPE_IPV4:
322                         /* If mask is not involved, we could use EM filters. */
323                         ipv4_spec = item->spec;
324                         ipv4_mask = item->mask;
325
326                         if (!item->spec || !item->mask)
327                                 break;
328
329                         /* Only IP DST and SRC fields are maskable. */
330                         if (ipv4_mask->hdr.version_ihl ||
331                             ipv4_mask->hdr.type_of_service ||
332                             ipv4_mask->hdr.total_length ||
333                             ipv4_mask->hdr.packet_id ||
334                             ipv4_mask->hdr.fragment_offset ||
335                             ipv4_mask->hdr.time_to_live ||
336                             ipv4_mask->hdr.next_proto_id ||
337                             ipv4_mask->hdr.hdr_checksum) {
338                                 rte_flow_error_set(error,
339                                                    EINVAL,
340                                                    RTE_FLOW_ERROR_TYPE_ITEM,
341                                                    item,
342                                                    "Invalid IPv4 mask.");
343                                 return -rte_errno;
344                         }
345
346                         filter->dst_ipaddr[0] = ipv4_spec->hdr.dst_addr;
347                         filter->src_ipaddr[0] = ipv4_spec->hdr.src_addr;
348
349                         if (use_ntuple)
350                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
351                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
352                         else
353                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
354                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
355
356                         if (ipv4_mask->hdr.src_addr) {
357                                 filter->src_ipaddr_mask[0] =
358                                         ipv4_mask->hdr.src_addr;
359                                 en |= !use_ntuple ? 0 :
360                                      NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
361                         }
362
363                         if (ipv4_mask->hdr.dst_addr) {
364                                 filter->dst_ipaddr_mask[0] =
365                                         ipv4_mask->hdr.dst_addr;
366                                 en |= !use_ntuple ? 0 :
367                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
368                         }
369
370                         filter->ip_addr_type = use_ntuple ?
371                          HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
372                          HWRM_CFA_EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
373
374                         if (ipv4_spec->hdr.next_proto_id) {
375                                 filter->ip_protocol =
376                                         ipv4_spec->hdr.next_proto_id;
377                                 if (use_ntuple)
378                                         en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
379                                 else
380                                         en |= EM_FLOW_ALLOC_INPUT_EN_IP_PROTO;
381                         }
382                         break;
383                 case RTE_FLOW_ITEM_TYPE_IPV6:
384                         ipv6_spec = item->spec;
385                         ipv6_mask = item->mask;
386
387                         if (!item->spec || !item->mask)
388                                 break;
389
390                         /* Only IP DST and SRC fields are maskable. */
391                         if (ipv6_mask->hdr.vtc_flow ||
392                             ipv6_mask->hdr.payload_len ||
393                             ipv6_mask->hdr.proto ||
394                             ipv6_mask->hdr.hop_limits) {
395                                 rte_flow_error_set(error,
396                                                    EINVAL,
397                                                    RTE_FLOW_ERROR_TYPE_ITEM,
398                                                    item,
399                                                    "Invalid IPv6 mask.");
400                                 return -rte_errno;
401                         }
402
403                         if (use_ntuple)
404                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
405                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
406                         else
407                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
408                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
409
410                         rte_memcpy(filter->src_ipaddr,
411                                    ipv6_spec->hdr.src_addr, 16);
412                         rte_memcpy(filter->dst_ipaddr,
413                                    ipv6_spec->hdr.dst_addr, 16);
414
415                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
416                                                    16)) {
417                                 rte_memcpy(filter->src_ipaddr_mask,
418                                            ipv6_mask->hdr.src_addr, 16);
419                                 en |= !use_ntuple ? 0 :
420                                     NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
421                         }
422
423                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
424                                                    16)) {
425                                 rte_memcpy(filter->dst_ipaddr_mask,
426                                            ipv6_mask->hdr.dst_addr, 16);
427                                 en |= !use_ntuple ? 0 :
428                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
429                         }
430
431                         filter->ip_addr_type = use_ntuple ?
432                                 NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
433                                 EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
434                         break;
435                 case RTE_FLOW_ITEM_TYPE_TCP:
436                         tcp_spec = item->spec;
437                         tcp_mask = item->mask;
438
439                         if (!item->spec || !item->mask)
440                                 break;
441
442                         /* Check TCP mask. Only DST & SRC ports are maskable */
443                         if (tcp_mask->hdr.sent_seq ||
444                             tcp_mask->hdr.recv_ack ||
445                             tcp_mask->hdr.data_off ||
446                             tcp_mask->hdr.tcp_flags ||
447                             tcp_mask->hdr.rx_win ||
448                             tcp_mask->hdr.cksum ||
449                             tcp_mask->hdr.tcp_urp) {
450                                 rte_flow_error_set(error,
451                                                    EINVAL,
452                                                    RTE_FLOW_ERROR_TYPE_ITEM,
453                                                    item,
454                                                    "Invalid TCP mask");
455                                 return -rte_errno;
456                         }
457
458                         filter->src_port = tcp_spec->hdr.src_port;
459                         filter->dst_port = tcp_spec->hdr.dst_port;
460
461                         if (use_ntuple)
462                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
463                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
464                         else
465                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
466                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
467
468                         if (tcp_mask->hdr.dst_port) {
469                                 filter->dst_port_mask = tcp_mask->hdr.dst_port;
470                                 en |= !use_ntuple ? 0 :
471                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
472                         }
473
474                         if (tcp_mask->hdr.src_port) {
475                                 filter->src_port_mask = tcp_mask->hdr.src_port;
476                                 en |= !use_ntuple ? 0 :
477                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
478                         }
479                         break;
480                 case RTE_FLOW_ITEM_TYPE_UDP:
481                         udp_spec = item->spec;
482                         udp_mask = item->mask;
483
484                         if (!item->spec || !item->mask)
485                                 break;
486
487                         if (udp_mask->hdr.dgram_len ||
488                             udp_mask->hdr.dgram_cksum) {
489                                 rte_flow_error_set(error,
490                                                    EINVAL,
491                                                    RTE_FLOW_ERROR_TYPE_ITEM,
492                                                    item,
493                                                    "Invalid UDP mask");
494                                 return -rte_errno;
495                         }
496
497                         filter->src_port = udp_spec->hdr.src_port;
498                         filter->dst_port = udp_spec->hdr.dst_port;
499
500                         if (use_ntuple)
501                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
502                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
503                         else
504                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
505                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
506
507                         if (udp_mask->hdr.dst_port) {
508                                 filter->dst_port_mask = udp_mask->hdr.dst_port;
509                                 en |= !use_ntuple ? 0 :
510                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
511                         }
512
513                         if (udp_mask->hdr.src_port) {
514                                 filter->src_port_mask = udp_mask->hdr.src_port;
515                                 en |= !use_ntuple ? 0 :
516                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
517                         }
518                         break;
519                 case RTE_FLOW_ITEM_TYPE_VXLAN:
520                         vxlan_spec = item->spec;
521                         vxlan_mask = item->mask;
522                         /* Check if VXLAN item is used to describe protocol.
523                          * If yes, both spec and mask should be NULL.
524                          * If no, both spec and mask shouldn't be NULL.
525                          */
526                         if ((!vxlan_spec && vxlan_mask) ||
527                             (vxlan_spec && !vxlan_mask)) {
528                                 rte_flow_error_set(error,
529                                                    EINVAL,
530                                                    RTE_FLOW_ERROR_TYPE_ITEM,
531                                                    item,
532                                                    "Invalid VXLAN item");
533                                 return -rte_errno;
534                         }
535
536                         if (!vxlan_spec && !vxlan_mask) {
537                                 filter->tunnel_type =
538                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
539                                 break;
540                         }
541
542                         if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
543                             vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
544                             vxlan_spec->flags != 0x8) {
545                                 rte_flow_error_set(error,
546                                                    EINVAL,
547                                                    RTE_FLOW_ERROR_TYPE_ITEM,
548                                                    item,
549                                                    "Invalid VXLAN item");
550                                 return -rte_errno;
551                         }
552
553                         /* Check if VNI is masked. */
554                         if (vxlan_spec && vxlan_mask) {
555                                 vni_masked =
556                                         !!memcmp(vxlan_mask->vni, vni_mask,
557                                                  RTE_DIM(vni_mask));
558                                 if (vni_masked) {
559                                         rte_flow_error_set
560                                                 (error,
561                                                  EINVAL,
562                                                  RTE_FLOW_ERROR_TYPE_ITEM,
563                                                  item,
564                                                  "Invalid VNI mask");
565                                         return -rte_errno;
566                                 }
567
568                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
569                                            vxlan_spec->vni, 3);
570                                 filter->vni =
571                                         rte_be_to_cpu_32(tenant_id_be);
572                                 filter->tunnel_type =
573                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
574                         }
575                         break;
576                 case RTE_FLOW_ITEM_TYPE_NVGRE:
577                         nvgre_spec = item->spec;
578                         nvgre_mask = item->mask;
579                         /* Check if NVGRE item is used to describe protocol.
580                          * If yes, both spec and mask should be NULL.
581                          * If no, both spec and mask shouldn't be NULL.
582                          */
583                         if ((!nvgre_spec && nvgre_mask) ||
584                             (nvgre_spec && !nvgre_mask)) {
585                                 rte_flow_error_set(error,
586                                                    EINVAL,
587                                                    RTE_FLOW_ERROR_TYPE_ITEM,
588                                                    item,
589                                                    "Invalid NVGRE item");
590                                 return -rte_errno;
591                         }
592
593                         if (!nvgre_spec && !nvgre_mask) {
594                                 filter->tunnel_type =
595                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
596                                 break;
597                         }
598
599                         if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
600                             nvgre_spec->protocol != 0x6558) {
601                                 rte_flow_error_set(error,
602                                                    EINVAL,
603                                                    RTE_FLOW_ERROR_TYPE_ITEM,
604                                                    item,
605                                                    "Invalid NVGRE item");
606                                 return -rte_errno;
607                         }
608
609                         if (nvgre_spec && nvgre_mask) {
610                                 tni_masked =
611                                         !!memcmp(nvgre_mask->tni, tni_mask,
612                                                  RTE_DIM(tni_mask));
613                                 if (tni_masked) {
614                                         rte_flow_error_set
615                                                 (error,
616                                                  EINVAL,
617                                                  RTE_FLOW_ERROR_TYPE_ITEM,
618                                                  item,
619                                                  "Invalid TNI mask");
620                                         return -rte_errno;
621                                 }
622                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
623                                            nvgre_spec->tni, 3);
624                                 filter->vni =
625                                         rte_be_to_cpu_32(tenant_id_be);
626                                 filter->tunnel_type =
627                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
628                         }
629                         break;
630
631                 case RTE_FLOW_ITEM_TYPE_GRE:
632                         gre_spec = (const struct rte_flow_item_gre *)item->spec;
633                         gre_mask = (const struct rte_flow_item_gre *)item->mask;
634
635                         /*
636                          *Check if GRE item is used to describe protocol.
637                          * If yes, both spec and mask should be NULL.
638                          * If no, both spec and mask shouldn't be NULL.
639                          */
640                         if (!!gre_spec ^ !!gre_mask) {
641                                 rte_flow_error_set(error, EINVAL,
642                                                    RTE_FLOW_ERROR_TYPE_ITEM,
643                                                    item,
644                                                    "Invalid GRE item");
645                                 return -rte_errno;
646                         }
647
648                         if (!gre_spec && !gre_mask) {
649                                 filter->tunnel_type =
650                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE;
651                                 break;
652                         }
653                         break;
654
655                 case RTE_FLOW_ITEM_TYPE_VF:
656                         vf_spec = item->spec;
657                         vf = vf_spec->id;
658                         if (!BNXT_PF(bp)) {
659                                 rte_flow_error_set(error,
660                                                    EINVAL,
661                                                    RTE_FLOW_ERROR_TYPE_ITEM,
662                                                    item,
663                                                    "Configuring on a VF!");
664                                 return -rte_errno;
665                         }
666
667                         if (vf >= bp->pdev->max_vfs) {
668                                 rte_flow_error_set(error,
669                                                    EINVAL,
670                                                    RTE_FLOW_ERROR_TYPE_ITEM,
671                                                    item,
672                                                    "Incorrect VF id!");
673                                 return -rte_errno;
674                         }
675
676                         if (!attr->transfer) {
677                                 rte_flow_error_set(error,
678                                                    ENOTSUP,
679                                                    RTE_FLOW_ERROR_TYPE_ITEM,
680                                                    item,
681                                                    "Matching VF traffic without"
682                                                    " affecting it (transfer attribute)"
683                                                    " is unsupported");
684                                 return -rte_errno;
685                         }
686
687                         filter->mirror_vnic_id =
688                         dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
689                         if (dflt_vnic < 0) {
690                                 /* This simply indicates there's no driver
691                                  * loaded. This is not an error.
692                                  */
693                                 rte_flow_error_set
694                                         (error,
695                                          EINVAL,
696                                          RTE_FLOW_ERROR_TYPE_ITEM,
697                                          item,
698                                          "Unable to get default VNIC for VF");
699                                 return -rte_errno;
700                         }
701
702                         filter->mirror_vnic_id = dflt_vnic;
703                         en |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
704                         break;
705                 default:
706                         break;
707                 }
708                 item++;
709         }
710         filter->enables = en;
711         filter->valid_flags = valid_flags;
712
713         return 0;
714 }
715
716 /* Parse attributes */
717 static int
718 bnxt_flow_parse_attr(const struct rte_flow_attr *attr,
719                      struct rte_flow_error *error)
720 {
721         /* Must be input direction */
722         if (!attr->ingress) {
723                 rte_flow_error_set(error,
724                                    EINVAL,
725                                    RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
726                                    attr,
727                                    "Only support ingress.");
728                 return -rte_errno;
729         }
730
731         /* Not supported */
732         if (attr->egress) {
733                 rte_flow_error_set(error,
734                                    EINVAL,
735                                    RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
736                                    attr,
737                                    "No support for egress.");
738                 return -rte_errno;
739         }
740
741         return 0;
742 }
743
744 static struct bnxt_filter_info *
745 bnxt_find_matching_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
746 {
747         struct bnxt_filter_info *mf, *f0;
748         struct bnxt_vnic_info *vnic0;
749         struct rte_flow *flow;
750         int i;
751
752         vnic0 = &bp->vnic_info[0];
753         f0 = STAILQ_FIRST(&vnic0->filter);
754
755         /* This flow has same DST MAC as the port/l2 filter. */
756         if (memcmp(f0->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN) == 0)
757                 return f0;
758
759         for (i = bp->max_vnics - 1; i >= 0; i--) {
760                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
761
762                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
763                         continue;
764
765                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
766                         mf = flow->filter;
767
768                         if (mf->matching_l2_fltr_ptr)
769                                 continue;
770
771                         if (mf->ethertype == nf->ethertype &&
772                             mf->l2_ovlan == nf->l2_ovlan &&
773                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
774                             mf->l2_ivlan == nf->l2_ivlan &&
775                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
776                             !memcmp(mf->src_macaddr, nf->src_macaddr,
777                                     RTE_ETHER_ADDR_LEN) &&
778                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
779                                     RTE_ETHER_ADDR_LEN))
780                                 return mf;
781                 }
782         }
783         return NULL;
784 }
785
786 static struct bnxt_filter_info *
787 bnxt_create_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
788                       struct bnxt_vnic_info *vnic)
789 {
790         struct bnxt_filter_info *filter1;
791         int rc;
792
793         /* Alloc new L2 filter.
794          * This flow needs MAC filter which does not match any existing
795          * L2 filters.
796          */
797         filter1 = bnxt_get_unused_filter(bp);
798         if (filter1 == NULL)
799                 return NULL;
800
801         filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_XDP_DISABLE;
802         filter1->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;
803         if (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
804             nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG) {
805                 filter1->flags |=
806                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
807                 PMD_DRV_LOG(DEBUG, "Create Outer filter\n");
808         }
809
810         if (nf->filter_type == HWRM_CFA_L2_FILTER &&
811             (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
812              nf->valid_flags & BNXT_FLOW_L2_INNER_SRC_VALID_FLAG)) {
813                 PMD_DRV_LOG(DEBUG, "Create L2 filter for SRC MAC\n");
814                 filter1->flags |=
815                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_SOURCE_VALID;
816                 memcpy(filter1->l2_addr, nf->src_macaddr, RTE_ETHER_ADDR_LEN);
817         } else {
818                 PMD_DRV_LOG(DEBUG, "Create L2 filter for DST MAC\n");
819                 memcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);
820         }
821
822         if (nf->priority &&
823             (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||
824              nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
825                 /* Tell the FW where to place the filter in the table. */
826                 if (nf->priority > 65535) {
827                         filter1->pri_hint =
828                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;
829                         /* This will place the filter in TCAM */
830                         filter1->l2_filter_id_hint = (uint64_t)-1;
831                 }
832         }
833
834         if (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |
835                                BNXT_FLOW_L2_SRC_VALID_FLAG |
836                                BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
837                                BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
838                 filter1->enables =
839                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
840                         L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;
841                 memset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
842         }
843
844         if (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {
845                 filter1->flags |=
846                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;
847                 if (nf->ethertype == RTE_ETHER_TYPE_IPV4) {
848                         /* Num VLANs for drop filter will/should be 0.
849                          * If the req is memset to 0, then the count will
850                          * be automatically set to 0.
851                          */
852                         if (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {
853                                 filter1->enables |=
854                                         L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;
855                         } else {
856                                 filter1->enables |=
857                                         L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;
858                                 filter1->flags |=
859                                 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
860                         }
861                 }
862         }
863
864         rc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,
865                                      filter1);
866         if (rc) {
867                 bnxt_free_filter(bp, filter1);
868                 return NULL;
869         }
870         filter1->l2_ref_cnt++;
871         return filter1;
872 }
873
874 struct bnxt_filter_info *
875 bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
876                    struct bnxt_vnic_info *vnic)
877 {
878         struct bnxt_filter_info *l2_filter = NULL;
879
880         l2_filter = bnxt_find_matching_l2_filter(bp, nf);
881         if (l2_filter) {
882                 l2_filter->l2_ref_cnt++;
883                 nf->matching_l2_fltr_ptr = l2_filter;
884         } else {
885                 l2_filter = bnxt_create_l2_filter(bp, nf, vnic);
886                 nf->matching_l2_fltr_ptr = NULL;
887         }
888
889         return l2_filter;
890 }
891
892 static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)
893 {
894         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
895         uint64_t rx_offloads = dev_conf->rxmode.offloads;
896         int rc;
897
898         rc = bnxt_vnic_grp_alloc(bp, vnic);
899         if (rc)
900                 goto ret;
901
902         rc = bnxt_hwrm_vnic_alloc(bp, vnic);
903         if (rc) {
904                 PMD_DRV_LOG(ERR, "HWRM vnic alloc failure rc: %x\n", rc);
905                 goto ret;
906         }
907         bp->nr_vnics++;
908
909         /* RSS context is required only when there is more than one RSS ring */
910         if (vnic->rx_queue_cnt > 1) {
911                 rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0 /* ctx_idx 0 */);
912                 if (rc) {
913                         PMD_DRV_LOG(ERR,
914                                     "HWRM vnic ctx alloc failure: %x\n", rc);
915                         goto ret;
916                 }
917         } else {
918                 PMD_DRV_LOG(DEBUG, "No RSS context required\n");
919         }
920
921         if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
922                 vnic->vlan_strip = true;
923         else
924                 vnic->vlan_strip = false;
925
926         rc = bnxt_hwrm_vnic_cfg(bp, vnic);
927         if (rc)
928                 goto ret;
929
930         bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
931
932 ret:
933         return rc;
934 }
935
936 static int match_vnic_rss_cfg(struct bnxt *bp,
937                               struct bnxt_vnic_info *vnic,
938                               const struct rte_flow_action_rss *rss)
939 {
940         unsigned int match = 0, i;
941
942         if (vnic->rx_queue_cnt != rss->queue_num)
943                 return -EINVAL;
944
945         for (i = 0; i < rss->queue_num; i++) {
946                 if (!bp->rx_queues[rss->queue[i]]->vnic->rx_queue_cnt &&
947                     !bp->rx_queues[rss->queue[i]]->rx_started)
948                         return -EINVAL;
949         }
950
951         for (i = 0; i < vnic->rx_queue_cnt; i++) {
952                 int j;
953
954                 for (j = 0; j < vnic->rx_queue_cnt; j++) {
955                         if (bp->grp_info[rss->queue[i]].fw_grp_id ==
956                             vnic->fw_grp_ids[j])
957                                 match++;
958                 }
959         }
960
961         if (match != vnic->rx_queue_cnt) {
962                 PMD_DRV_LOG(ERR,
963                             "VNIC queue count %d vs queues matched %d\n",
964                             match, vnic->rx_queue_cnt);
965                 return -EINVAL;
966         }
967
968         return 0;
969 }
970
971 static void
972 bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,
973                             struct bnxt_filter_info *filter1,
974                             int use_ntuple)
975 {
976         if (!use_ntuple &&
977             !(filter->valid_flags &
978               ~(BNXT_FLOW_L2_DST_VALID_FLAG |
979                 BNXT_FLOW_L2_SRC_VALID_FLAG |
980                 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
981                 BNXT_FLOW_L2_INNER_DST_VALID_FLAG |
982                 BNXT_FLOW_L2_DROP_FLAG |
983                 BNXT_FLOW_PARSE_INNER_FLAG))) {
984                 filter->flags = filter1->flags;
985                 filter->enables = filter1->enables;
986                 filter->filter_type = HWRM_CFA_L2_FILTER;
987                 memcpy(filter->l2_addr, filter1->l2_addr, RTE_ETHER_ADDR_LEN);
988                 memset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
989                 filter->pri_hint = filter1->pri_hint;
990                 filter->l2_filter_id_hint = filter1->l2_filter_id_hint;
991         }
992         filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
993         filter->l2_ref_cnt = filter1->l2_ref_cnt;
994         PMD_DRV_LOG(DEBUG,
995                 "l2_filter: %p fw_l2_filter_id %" PRIx64 " l2_ref_cnt %u\n",
996                 filter1, filter->fw_l2_filter_id, filter->l2_ref_cnt);
997 }
998
999 static int
1000 bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
1001                              const struct rte_flow_item pattern[],
1002                              const struct rte_flow_action actions[],
1003                              const struct rte_flow_attr *attr,
1004                              struct rte_flow_error *error,
1005                              struct bnxt_filter_info *filter)
1006 {
1007         const struct rte_flow_action *act =
1008                 bnxt_flow_non_void_action(actions);
1009         struct bnxt *bp = dev->data->dev_private;
1010         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
1011         struct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;
1012         const struct rte_flow_action_queue *act_q;
1013         const struct rte_flow_action_vf *act_vf;
1014         struct bnxt_filter_info *filter1 = NULL;
1015         const struct rte_flow_action_rss *rss;
1016         struct bnxt_rx_queue *rxq = NULL;
1017         int dflt_vnic, vnic_id;
1018         unsigned int rss_idx;
1019         uint32_t vf = 0, i;
1020         int rc, use_ntuple;
1021
1022         rc =
1023         bnxt_validate_and_parse_flow_type(bp, attr, pattern, error, filter);
1024         if (rc != 0)
1025                 goto ret;
1026
1027         rc = bnxt_flow_parse_attr(attr, error);
1028         if (rc != 0)
1029                 goto ret;
1030
1031         /* Since we support ingress attribute only - right now. */
1032         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1033                 filter->flags = HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_PATH_RX;
1034
1035         use_ntuple = bnxt_filter_type_check(pattern, error);
1036         switch (act->type) {
1037         case RTE_FLOW_ACTION_TYPE_QUEUE:
1038                 /* Allow this flow. Redirect to a VNIC. */
1039                 act_q = (const struct rte_flow_action_queue *)act->conf;
1040                 if (!act_q->index || act_q->index >= bp->rx_nr_rings) {
1041                         rte_flow_error_set(error,
1042                                            EINVAL,
1043                                            RTE_FLOW_ERROR_TYPE_ACTION,
1044                                            act,
1045                                            "Invalid queue ID.");
1046                         rc = -rte_errno;
1047                         goto ret;
1048                 }
1049                 PMD_DRV_LOG(DEBUG, "Queue index %d\n", act_q->index);
1050
1051                 vnic_id = attr->group;
1052                 if (!vnic_id) {
1053                         PMD_DRV_LOG(DEBUG, "Group id is 0\n");
1054                         vnic_id = act_q->index;
1055                 }
1056
1057                 vnic = &bp->vnic_info[vnic_id];
1058                 if (vnic == NULL) {
1059                         rte_flow_error_set(error,
1060                                            EINVAL,
1061                                            RTE_FLOW_ERROR_TYPE_ACTION,
1062                                            act,
1063                                            "No matching VNIC found.");
1064                         rc = -rte_errno;
1065                         goto ret;
1066                 }
1067                 if (vnic->rx_queue_cnt) {
1068                         if (vnic->start_grp_id != act_q->index) {
1069                                 PMD_DRV_LOG(ERR,
1070                                             "VNIC already in use\n");
1071                                 rte_flow_error_set(error,
1072                                                    EINVAL,
1073                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1074                                                    act,
1075                                                    "VNIC already in use");
1076                                 rc = -rte_errno;
1077                                 goto ret;
1078                         }
1079                         goto use_vnic;
1080                 }
1081
1082                 rxq = bp->rx_queues[act_q->index];
1083
1084                 if (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) && rxq &&
1085                     vnic->fw_vnic_id != INVALID_HW_RING_ID)
1086                         goto use_vnic;
1087
1088                 if (!rxq) {
1089                         PMD_DRV_LOG(ERR,
1090                                     "Queue invalid or used with other VNIC\n");
1091                         rte_flow_error_set(error,
1092                                            EINVAL,
1093                                            RTE_FLOW_ERROR_TYPE_ACTION,
1094                                            act,
1095                                            "Queue invalid queue or in use");
1096                         rc = -rte_errno;
1097                         goto ret;
1098                 }
1099
1100                 rxq->vnic = vnic;
1101                 rxq->rx_started = 1;
1102                 vnic->rx_queue_cnt++;
1103                 vnic->start_grp_id = act_q->index;
1104                 vnic->end_grp_id = act_q->index;
1105                 vnic->func_default = 0; //This is not a default VNIC.
1106
1107                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1108
1109                 rc = bnxt_vnic_prep(bp, vnic);
1110                 if (rc)  {
1111                         rte_flow_error_set(error,
1112                                            EINVAL,
1113                                            RTE_FLOW_ERROR_TYPE_ACTION,
1114                                            act,
1115                                            "VNIC prep fail");
1116                         rc = -rte_errno;
1117                         goto ret;
1118                 }
1119
1120                 PMD_DRV_LOG(DEBUG,
1121                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1122                             act_q->index, vnic, vnic->fw_grp_ids);
1123
1124 use_vnic:
1125                 vnic->ff_pool_idx = vnic_id;
1126                 PMD_DRV_LOG(DEBUG,
1127                             "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
1128                 filter->dst_id = vnic->fw_vnic_id;
1129
1130                 /* For ntuple filter, create the L2 filter with default VNIC.
1131                  * The user specified redirect queue will be set while creating
1132                  * the ntuple filter in hardware.
1133                  */
1134                 vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
1135                 if (use_ntuple)
1136                         filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1137                 else
1138                         filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1139                 if (filter1 == NULL) {
1140                         rte_flow_error_set(error,
1141                                            ENOSPC,
1142                                            RTE_FLOW_ERROR_TYPE_ACTION,
1143                                            act,
1144                                            "Filter not available");
1145                         rc = -rte_errno;
1146                         goto ret;
1147                 }
1148
1149                 PMD_DRV_LOG(DEBUG, "new fltr: %p l2fltr: %p l2_ref_cnt: %d\n",
1150                             filter, filter1, filter1->l2_ref_cnt);
1151                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1152                 break;
1153         case RTE_FLOW_ACTION_TYPE_DROP:
1154                 vnic0 = &bp->vnic_info[0];
1155                 filter->dst_id = vnic0->fw_vnic_id;
1156                 filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
1157                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1158                 if (filter1 == NULL) {
1159                         rte_flow_error_set(error,
1160                                            ENOSPC,
1161                                            RTE_FLOW_ERROR_TYPE_ACTION,
1162                                            act,
1163                                            "Filter not available");
1164                         rc = -rte_errno;
1165                         goto ret;
1166                 }
1167
1168                 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1169                         filter->flags =
1170                                 HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
1171                 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1172                         filter->flags =
1173                                 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
1174
1175                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1176                 break;
1177         case RTE_FLOW_ACTION_TYPE_COUNT:
1178                 vnic0 = &bp->vnic_info[0];
1179                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1180                 if (filter1 == NULL) {
1181                         rte_flow_error_set(error,
1182                                            ENOSPC,
1183                                            RTE_FLOW_ERROR_TYPE_ACTION,
1184                                            act,
1185                                            "New filter not available");
1186                         rc = -rte_errno;
1187                         goto ret;
1188                 }
1189
1190                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1191                 filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_METER;
1192                 break;
1193         case RTE_FLOW_ACTION_TYPE_VF:
1194                 act_vf = (const struct rte_flow_action_vf *)act->conf;
1195                 vf = act_vf->id;
1196
1197                 if (filter->tunnel_type ==
1198                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN ||
1199                     filter->tunnel_type ==
1200                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE) {
1201                         /* If issued on a VF, ensure id is 0 and is trusted */
1202                         if (BNXT_VF(bp)) {
1203                                 if (!BNXT_VF_IS_TRUSTED(bp) || vf) {
1204                                         rte_flow_error_set(error, EINVAL,
1205                                                 RTE_FLOW_ERROR_TYPE_ACTION,
1206                                                 act,
1207                                                 "Incorrect VF");
1208                                         rc = -rte_errno;
1209                                         goto ret;
1210                                 }
1211                         }
1212
1213                         filter->enables |= filter->tunnel_type;
1214                         filter->filter_type = HWRM_CFA_TUNNEL_REDIRECT_FILTER;
1215                         goto done;
1216                 }
1217
1218                 if (vf >= bp->pdev->max_vfs) {
1219                         rte_flow_error_set(error,
1220                                            EINVAL,
1221                                            RTE_FLOW_ERROR_TYPE_ACTION,
1222                                            act,
1223                                            "Incorrect VF id!");
1224                         rc = -rte_errno;
1225                         goto ret;
1226                 }
1227
1228                 filter->mirror_vnic_id =
1229                 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
1230                 if (dflt_vnic < 0) {
1231                         /* This simply indicates there's no driver loaded.
1232                          * This is not an error.
1233                          */
1234                         rte_flow_error_set(error,
1235                                            EINVAL,
1236                                            RTE_FLOW_ERROR_TYPE_ACTION,
1237                                            act,
1238                                            "Unable to get default VNIC for VF");
1239                         rc = -rte_errno;
1240                         goto ret;
1241                 }
1242
1243                 filter->mirror_vnic_id = dflt_vnic;
1244                 filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
1245
1246                 vnic0 = &bp->vnic_info[0];
1247                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1248                 if (filter1 == NULL) {
1249                         rte_flow_error_set(error,
1250                                            ENOSPC,
1251                                            RTE_FLOW_ERROR_TYPE_ACTION,
1252                                            act,
1253                                            "New filter not available");
1254                         rc = -rte_errno;
1255                         goto ret;
1256                 }
1257
1258                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1259                 break;
1260         case RTE_FLOW_ACTION_TYPE_RSS:
1261                 rss = (const struct rte_flow_action_rss *)act->conf;
1262
1263                 vnic_id = attr->group;
1264                 if (!vnic_id) {
1265                         PMD_DRV_LOG(ERR, "Group id cannot be 0\n");
1266                         rte_flow_error_set(error,
1267                                            EINVAL,
1268                                            RTE_FLOW_ERROR_TYPE_ATTR,
1269                                            NULL,
1270                                            "Group id cannot be 0");
1271                         rc = -rte_errno;
1272                         goto ret;
1273                 }
1274
1275                 vnic = &bp->vnic_info[vnic_id];
1276                 if (vnic == NULL) {
1277                         rte_flow_error_set(error,
1278                                            EINVAL,
1279                                            RTE_FLOW_ERROR_TYPE_ACTION,
1280                                            act,
1281                                            "No matching VNIC for RSS group.");
1282                         rc = -rte_errno;
1283                         goto ret;
1284                 }
1285                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1286
1287                 /* Check if requested RSS config matches RSS config of VNIC
1288                  * only if it is not a fresh VNIC configuration.
1289                  * Otherwise the existing VNIC configuration can be used.
1290                  */
1291                 if (vnic->rx_queue_cnt) {
1292                         rc = match_vnic_rss_cfg(bp, vnic, rss);
1293                         if (rc) {
1294                                 PMD_DRV_LOG(ERR,
1295                                             "VNIC and RSS config mismatch\n");
1296                                 rte_flow_error_set(error,
1297                                                    EINVAL,
1298                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1299                                                    act,
1300                                                    "VNIC and RSS cfg mismatch");
1301                                 rc = -rte_errno;
1302                                 goto ret;
1303                         }
1304                         goto vnic_found;
1305                 }
1306
1307                 for (i = 0; i < rss->queue_num; i++) {
1308                         PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n",
1309                                     rss->queue[i]);
1310
1311                         if (!rss->queue[i] ||
1312                             rss->queue[i] >= bp->rx_nr_rings ||
1313                             !bp->rx_queues[rss->queue[i]]) {
1314                                 rte_flow_error_set(error,
1315                                                    EINVAL,
1316                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1317                                                    act,
1318                                                    "Invalid queue ID for RSS");
1319                                 rc = -rte_errno;
1320                                 goto ret;
1321                         }
1322                         rxq = bp->rx_queues[rss->queue[i]];
1323
1324                         if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1325                             INVALID_HW_RING_ID) {
1326                                 PMD_DRV_LOG(ERR,
1327                                             "queue active with other VNIC\n");
1328                                 rte_flow_error_set(error,
1329                                                    EINVAL,
1330                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1331                                                    act,
1332                                                    "Invalid queue ID for RSS");
1333                                 rc = -rte_errno;
1334                                 goto ret;
1335                         }
1336
1337                         rxq->vnic = vnic;
1338                         rxq->rx_started = 1;
1339                         vnic->rx_queue_cnt++;
1340                 }
1341
1342                 vnic->start_grp_id = rss->queue[0];
1343                 vnic->end_grp_id = rss->queue[rss->queue_num - 1];
1344                 vnic->func_default = 0; //This is not a default VNIC.
1345
1346                 rc = bnxt_vnic_prep(bp, vnic);
1347                 if (rc) {
1348                         rte_flow_error_set(error,
1349                                            EINVAL,
1350                                            RTE_FLOW_ERROR_TYPE_ACTION,
1351                                            act,
1352                                            "VNIC prep fail");
1353                         rc = -rte_errno;
1354                         goto ret;
1355                 }
1356
1357                 PMD_DRV_LOG(DEBUG,
1358                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1359                             vnic_id, vnic, vnic->fw_grp_ids);
1360
1361                 vnic->ff_pool_idx = vnic_id;
1362                 PMD_DRV_LOG(DEBUG,
1363                             "Setting vnic ff_pool_idx %d\n", vnic->ff_pool_idx);
1364
1365                 /* This can be done only after vnic_grp_alloc is done. */
1366                 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1367                         vnic->fw_grp_ids[i] =
1368                                 bp->grp_info[rss->queue[i]].fw_grp_id;
1369                         /* Make sure vnic0 does not use these rings. */
1370                         bp->vnic_info[0].fw_grp_ids[rss->queue[i]] =
1371                                 INVALID_HW_RING_ID;
1372                 }
1373
1374                 for (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; ) {
1375                         for (i = 0; i < vnic->rx_queue_cnt; i++)
1376                                 vnic->rss_table[rss_idx++] =
1377                                         vnic->fw_grp_ids[i];
1378                 }
1379
1380                 /* Configure RSS only if the queue count is > 1 */
1381                 if (vnic->rx_queue_cnt > 1) {
1382                         vnic->hash_type =
1383                                 bnxt_rte_to_hwrm_hash_types(rss->types);
1384
1385                         if (!rss->key_len) {
1386                                 /* If hash key has not been specified,
1387                                  * use random hash key.
1388                                  */
1389                                 prandom_bytes(vnic->rss_hash_key,
1390                                               HW_HASH_KEY_SIZE);
1391                         } else {
1392                                 if (rss->key_len > HW_HASH_KEY_SIZE)
1393                                         memcpy(vnic->rss_hash_key,
1394                                                rss->key,
1395                                                HW_HASH_KEY_SIZE);
1396                                 else
1397                                         memcpy(vnic->rss_hash_key,
1398                                                rss->key,
1399                                                rss->key_len);
1400                         }
1401                         bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1402                 } else {
1403                         PMD_DRV_LOG(DEBUG, "No RSS config required\n");
1404                 }
1405
1406 vnic_found:
1407                 filter->dst_id = vnic->fw_vnic_id;
1408                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1409                 if (filter1 == NULL) {
1410                         rte_flow_error_set(error,
1411                                            ENOSPC,
1412                                            RTE_FLOW_ERROR_TYPE_ACTION,
1413                                            act,
1414                                            "New filter not available");
1415                         rc = -rte_errno;
1416                         goto ret;
1417                 }
1418
1419                 PMD_DRV_LOG(DEBUG, "L2 filter created\n");
1420                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1421                 break;
1422         default:
1423                 rte_flow_error_set(error,
1424                                    EINVAL,
1425                                    RTE_FLOW_ERROR_TYPE_ACTION,
1426                                    act,
1427                                    "Invalid action.");
1428                 rc = -rte_errno;
1429                 goto ret;
1430         }
1431
1432         if (filter1 && !filter->matching_l2_fltr_ptr) {
1433                 bnxt_free_filter(bp, filter1);
1434                 filter1->fw_l2_filter_id = -1;
1435         }
1436
1437 done:
1438         act = bnxt_flow_non_void_action(++act);
1439         if (act->type != RTE_FLOW_ACTION_TYPE_END) {
1440                 rte_flow_error_set(error,
1441                                    EINVAL,
1442                                    RTE_FLOW_ERROR_TYPE_ACTION,
1443                                    act,
1444                                    "Invalid action.");
1445                 rc = -rte_errno;
1446                 goto ret;
1447         }
1448
1449         return rc;
1450 ret:
1451
1452         //TODO: Cleanup according to ACTION TYPE.
1453         if (rte_errno)  {
1454                 if (vnic && STAILQ_EMPTY(&vnic->filter))
1455                         vnic->rx_queue_cnt = 0;
1456
1457                 if (rxq && !vnic->rx_queue_cnt)
1458                         rxq->vnic = &bp->vnic_info[0];
1459         }
1460         return rc;
1461 }
1462
1463 static
1464 struct bnxt_vnic_info *find_matching_vnic(struct bnxt *bp,
1465                                           struct bnxt_filter_info *filter)
1466 {
1467         struct bnxt_vnic_info *vnic = NULL;
1468         unsigned int i;
1469
1470         for (i = 0; i < bp->max_vnics; i++) {
1471                 vnic = &bp->vnic_info[i];
1472                 if (vnic->fw_vnic_id != INVALID_VNIC_ID &&
1473                     filter->dst_id == vnic->fw_vnic_id) {
1474                         PMD_DRV_LOG(DEBUG, "Found matching VNIC Id %d\n",
1475                                     vnic->ff_pool_idx);
1476                         return vnic;
1477                 }
1478         }
1479         return NULL;
1480 }
1481
1482 static int
1483 bnxt_flow_validate(struct rte_eth_dev *dev,
1484                    const struct rte_flow_attr *attr,
1485                    const struct rte_flow_item pattern[],
1486                    const struct rte_flow_action actions[],
1487                    struct rte_flow_error *error)
1488 {
1489         struct bnxt *bp = dev->data->dev_private;
1490         struct bnxt_vnic_info *vnic = NULL;
1491         struct bnxt_filter_info *filter;
1492         int ret = 0;
1493
1494         bnxt_acquire_flow_lock(bp);
1495         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1496         if (ret != 0) {
1497                 bnxt_release_flow_lock(bp);
1498                 return ret;
1499         }
1500
1501         filter = bnxt_get_unused_filter(bp);
1502         if (filter == NULL) {
1503                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1504                 bnxt_release_flow_lock(bp);
1505                 return -ENOMEM;
1506         }
1507
1508         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1509                                            error, filter);
1510         if (ret)
1511                 goto exit;
1512
1513         vnic = find_matching_vnic(bp, filter);
1514         if (vnic) {
1515                 if (STAILQ_EMPTY(&vnic->filter)) {
1516                         rte_free(vnic->fw_grp_ids);
1517                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1518                         bnxt_hwrm_vnic_free(bp, vnic);
1519                         vnic->rx_queue_cnt = 0;
1520                         PMD_DRV_LOG(DEBUG, "Free VNIC\n");
1521                 }
1522         }
1523
1524         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1525                 bnxt_hwrm_clear_em_filter(bp, filter);
1526         else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1527                 bnxt_hwrm_clear_ntuple_filter(bp, filter);
1528         else
1529                 bnxt_hwrm_clear_l2_filter(bp, filter);
1530
1531 exit:
1532         /* No need to hold on to this filter if we are just validating flow */
1533         bnxt_free_filter(bp, filter);
1534         bnxt_release_flow_lock(bp);
1535
1536         return ret;
1537 }
1538
1539 static void
1540 bnxt_update_filter(struct bnxt *bp, struct bnxt_filter_info *old_filter,
1541                    struct bnxt_filter_info *new_filter)
1542 {
1543         /* Clear the new L2 filter that was created in the previous step in
1544          * bnxt_validate_and_parse_flow. For L2 filters, we will use the new
1545          * filter which points to the new destination queue and so we clear
1546          * the previous L2 filter. For ntuple filters, we are going to reuse
1547          * the old L2 filter and create new NTUPLE filter with this new
1548          * destination queue subsequently during bnxt_flow_create. So we
1549          * decrement the ref cnt of the L2 filter that would've been bumped
1550          * up previously in bnxt_validate_and_parse_flow as the old n-tuple
1551          * filter that was referencing it will be deleted now.
1552          */
1553         bnxt_hwrm_clear_l2_filter(bp, old_filter);
1554         if (new_filter->filter_type == HWRM_CFA_L2_FILTER) {
1555                 bnxt_hwrm_set_l2_filter(bp, new_filter->dst_id, new_filter);
1556         } else {
1557                 if (new_filter->filter_type == HWRM_CFA_EM_FILTER)
1558                         bnxt_hwrm_clear_em_filter(bp, old_filter);
1559                 if (new_filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1560                         bnxt_hwrm_clear_ntuple_filter(bp, old_filter);
1561         }
1562 }
1563
1564 static int
1565 bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
1566 {
1567         struct bnxt_filter_info *mf;
1568         struct rte_flow *flow;
1569         int i;
1570
1571         for (i = bp->max_vnics - 1; i >= 0; i--) {
1572                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
1573
1574                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
1575                         continue;
1576
1577                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
1578                         mf = flow->filter;
1579
1580                         if (mf->filter_type == nf->filter_type &&
1581                             mf->flags == nf->flags &&
1582                             mf->src_port == nf->src_port &&
1583                             mf->src_port_mask == nf->src_port_mask &&
1584                             mf->dst_port == nf->dst_port &&
1585                             mf->dst_port_mask == nf->dst_port_mask &&
1586                             mf->ip_protocol == nf->ip_protocol &&
1587                             mf->ip_addr_type == nf->ip_addr_type &&
1588                             mf->ethertype == nf->ethertype &&
1589                             mf->vni == nf->vni &&
1590                             mf->tunnel_type == nf->tunnel_type &&
1591                             mf->l2_ovlan == nf->l2_ovlan &&
1592                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
1593                             mf->l2_ivlan == nf->l2_ivlan &&
1594                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
1595                             !memcmp(mf->l2_addr, nf->l2_addr,
1596                                     RTE_ETHER_ADDR_LEN) &&
1597                             !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
1598                                     RTE_ETHER_ADDR_LEN) &&
1599                             !memcmp(mf->src_macaddr, nf->src_macaddr,
1600                                     RTE_ETHER_ADDR_LEN) &&
1601                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
1602                                     RTE_ETHER_ADDR_LEN) &&
1603                             !memcmp(mf->src_ipaddr, nf->src_ipaddr,
1604                                     sizeof(nf->src_ipaddr)) &&
1605                             !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
1606                                     sizeof(nf->src_ipaddr_mask)) &&
1607                             !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
1608                                     sizeof(nf->dst_ipaddr)) &&
1609                             !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
1610                                     sizeof(nf->dst_ipaddr_mask))) {
1611                                 if (mf->dst_id == nf->dst_id)
1612                                         return -EEXIST;
1613                                 /* Free the old filter, update flow
1614                                  * with new filter
1615                                  */
1616                                 bnxt_update_filter(bp, mf, nf);
1617                                 STAILQ_REMOVE(&vnic->filter, mf,
1618                                               bnxt_filter_info, next);
1619                                 STAILQ_INSERT_TAIL(&vnic->filter, nf, next);
1620                                 bnxt_free_filter(bp, mf);
1621                                 flow->filter = nf;
1622                                 return -EXDEV;
1623                         }
1624                 }
1625         }
1626         return 0;
1627 }
1628
1629 static struct rte_flow *
1630 bnxt_flow_create(struct rte_eth_dev *dev,
1631                  const struct rte_flow_attr *attr,
1632                  const struct rte_flow_item pattern[],
1633                  const struct rte_flow_action actions[],
1634                  struct rte_flow_error *error)
1635 {
1636         struct bnxt *bp = dev->data->dev_private;
1637         struct bnxt_vnic_info *vnic = NULL;
1638         struct bnxt_filter_info *filter;
1639         bool update_flow = false;
1640         struct rte_flow *flow;
1641         int ret = 0;
1642         uint32_t tun_type;
1643
1644         if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
1645                 rte_flow_error_set(error, EINVAL,
1646                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1647                                    "Failed to create flow, Not a Trusted VF!");
1648                 return NULL;
1649         }
1650
1651         if (!dev->data->dev_started) {
1652                 rte_flow_error_set(error,
1653                                    EINVAL,
1654                                    RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
1655                                    NULL,
1656                                    "Device must be started");
1657                 return NULL;
1658         }
1659
1660         flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0);
1661         if (!flow) {
1662                 rte_flow_error_set(error, ENOMEM,
1663                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1664                                    "Failed to allocate memory");
1665                 return flow;
1666         }
1667
1668         bnxt_acquire_flow_lock(bp);
1669         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1670         if (ret != 0) {
1671                 PMD_DRV_LOG(ERR, "Not a validate flow.\n");
1672                 goto free_flow;
1673         }
1674
1675         filter = bnxt_get_unused_filter(bp);
1676         if (filter == NULL) {
1677                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1678                 goto free_flow;
1679         }
1680
1681         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1682                                            error, filter);
1683         if (ret != 0)
1684                 goto free_filter;
1685
1686         ret = bnxt_match_filter(bp, filter);
1687         if (ret == -EEXIST) {
1688                 PMD_DRV_LOG(DEBUG, "Flow already exists.\n");
1689                 /* Clear the filter that was created as part of
1690                  * validate_and_parse_flow() above
1691                  */
1692                 bnxt_hwrm_clear_l2_filter(bp, filter);
1693                 goto free_filter;
1694         } else if (ret == -EXDEV) {
1695                 PMD_DRV_LOG(DEBUG, "Flow with same pattern exists\n");
1696                 PMD_DRV_LOG(DEBUG, "Updating with different destination\n");
1697                 update_flow = true;
1698         }
1699
1700         /* If tunnel redirection to a VF/PF is specified then only tunnel_type
1701          * is set and enable is set to the tunnel type. Issue hwrm cmd directly
1702          * in such a case.
1703          */
1704         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1705             filter->enables == filter->tunnel_type) {
1706                 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1707                 if (ret) {
1708                         rte_flow_error_set(error, -ret,
1709                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1710                                            "Unable to query tunnel to VF");
1711                         goto free_filter;
1712                 }
1713                 if (tun_type == (1U << filter->tunnel_type)) {
1714                         ret =
1715                         bnxt_hwrm_tunnel_redirect_free(bp,
1716                                                        filter->tunnel_type);
1717                         if (ret) {
1718                                 PMD_DRV_LOG(ERR,
1719                                             "Unable to free existing tunnel\n");
1720                                 rte_flow_error_set(error, -ret,
1721                                                    RTE_FLOW_ERROR_TYPE_HANDLE,
1722                                                    NULL,
1723                                                    "Unable to free preexisting "
1724                                                    "tunnel on VF");
1725                                 goto free_filter;
1726                         }
1727                 }
1728                 ret = bnxt_hwrm_tunnel_redirect(bp, filter->tunnel_type);
1729                 if (ret) {
1730                         rte_flow_error_set(error, -ret,
1731                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1732                                            "Unable to redirect tunnel to VF");
1733                         goto free_filter;
1734                 }
1735                 vnic = &bp->vnic_info[0];
1736                 goto done;
1737         }
1738
1739         if (filter->filter_type == HWRM_CFA_EM_FILTER) {
1740                 filter->enables |=
1741                         HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1742                 ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter);
1743         }
1744
1745         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) {
1746                 filter->enables |=
1747                         HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1748                 ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter);
1749         }
1750
1751         vnic = find_matching_vnic(bp, filter);
1752 done:
1753         if (!ret || update_flow) {
1754                 flow->filter = filter;
1755                 flow->vnic = vnic;
1756                 if (update_flow) {
1757                         ret = -EXDEV;
1758                         goto free_flow;
1759                 }
1760
1761                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
1762                 PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
1763                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
1764                 bnxt_release_flow_lock(bp);
1765                 return flow;
1766         }
1767
1768 free_filter:
1769         bnxt_free_filter(bp, filter);
1770 free_flow:
1771         if (ret == -EEXIST)
1772                 rte_flow_error_set(error, ret,
1773                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1774                                    "Matching Flow exists.");
1775         else if (ret == -EXDEV)
1776                 rte_flow_error_set(error, 0,
1777                                    RTE_FLOW_ERROR_TYPE_NONE, NULL,
1778                                    "Flow with pattern exists, updating destination queue");
1779         else
1780                 rte_flow_error_set(error, -ret,
1781                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1782                                    "Failed to create flow.");
1783         rte_free(flow);
1784         flow = NULL;
1785         bnxt_release_flow_lock(bp);
1786         return flow;
1787 }
1788
1789 static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
1790                                                struct bnxt_filter_info *filter,
1791                                                struct rte_flow_error *error)
1792 {
1793         uint16_t tun_dst_fid;
1794         uint32_t tun_type;
1795         int ret = 0;
1796
1797         ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1798         if (ret) {
1799                 rte_flow_error_set(error, -ret,
1800                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1801                                    "Unable to query tunnel to VF");
1802                 return ret;
1803         }
1804         if (tun_type == (1U << filter->tunnel_type)) {
1805                 ret = bnxt_hwrm_tunnel_redirect_info(bp, filter->tunnel_type,
1806                                                      &tun_dst_fid);
1807                 if (ret) {
1808                         rte_flow_error_set(error, -ret,
1809                                            RTE_FLOW_ERROR_TYPE_HANDLE,
1810                                            NULL,
1811                                            "tunnel_redirect info cmd fail");
1812                         return ret;
1813                 }
1814                 PMD_DRV_LOG(INFO, "Pre-existing tunnel fid = %x vf->fid = %x\n",
1815                             tun_dst_fid + bp->first_vf_id, bp->fw_fid);
1816
1817                 /* Tunnel doesn't belong to this VF, so don't send HWRM
1818                  * cmd, just delete the flow from driver
1819                  */
1820                 if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id))
1821                         PMD_DRV_LOG(ERR,
1822                                     "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
1823                 else
1824                         ret = bnxt_hwrm_tunnel_redirect_free(bp,
1825                                                         filter->tunnel_type);
1826         }
1827         return ret;
1828 }
1829
1830 static int
1831 _bnxt_flow_destroy(struct bnxt *bp,
1832                    struct rte_flow *flow,
1833                     struct rte_flow_error *error)
1834 {
1835         struct bnxt_filter_info *filter;
1836         struct bnxt_vnic_info *vnic;
1837         int ret = 0;
1838
1839         filter = flow->filter;
1840         vnic = flow->vnic;
1841
1842         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1843             filter->enables == filter->tunnel_type) {
1844                 ret = bnxt_handle_tunnel_redirect_destroy(bp, filter, error);
1845                 if (!ret)
1846                         goto done;
1847                 else
1848                         return ret;
1849         }
1850
1851         ret = bnxt_match_filter(bp, filter);
1852         if (ret == 0)
1853                 PMD_DRV_LOG(ERR, "Could not find matching flow\n");
1854
1855         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1856                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1857         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1858                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1859         ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1860
1861 done:
1862         if (!ret) {
1863                 /* If it is a L2 drop filter, when the filter is created,
1864                  * the FW updates the BC/MC records.
1865                  * Once this filter is removed, issue the set_rx_mask command
1866                  * to reset the BC/MC records in the HW to the settings
1867                  * before the drop counter is created.
1868                  */
1869                 if (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)
1870                         bnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);
1871
1872                 STAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);
1873                 bnxt_free_filter(bp, filter);
1874                 STAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);
1875                 rte_free(flow);
1876
1877                 /* If this was the last flow associated with this vnic,
1878                  * switch the queue back to RSS pool.
1879                  */
1880                 if (vnic && !vnic->func_default &&
1881                     STAILQ_EMPTY(&vnic->flow_list)) {
1882                         rte_free(vnic->fw_grp_ids);
1883                         if (vnic->rx_queue_cnt > 1)
1884                                 bnxt_hwrm_vnic_ctx_free(bp, vnic);
1885
1886                         bnxt_hwrm_vnic_free(bp, vnic);
1887                         vnic->rx_queue_cnt = 0;
1888                 }
1889         } else {
1890                 rte_flow_error_set(error, -ret,
1891                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1892                                    "Failed to destroy flow.");
1893         }
1894
1895         return ret;
1896 }
1897
1898 static int
1899 bnxt_flow_destroy(struct rte_eth_dev *dev,
1900                   struct rte_flow *flow,
1901                   struct rte_flow_error *error)
1902 {
1903         struct bnxt *bp = dev->data->dev_private;
1904         int ret = 0;
1905
1906         bnxt_acquire_flow_lock(bp);
1907         if (!flow) {
1908                 rte_flow_error_set(error, EINVAL,
1909                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1910                                    "Invalid flow: failed to destroy flow.");
1911                 bnxt_release_flow_lock(bp);
1912                 return -EINVAL;
1913         }
1914
1915         if (!flow->filter) {
1916                 rte_flow_error_set(error, EINVAL,
1917                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1918                                    "Invalid flow: failed to destroy flow.");
1919                 bnxt_release_flow_lock(bp);
1920                 return -EINVAL;
1921         }
1922         ret = _bnxt_flow_destroy(bp, flow, error);
1923         bnxt_release_flow_lock(bp);
1924
1925         return ret;
1926 }
1927
1928 static int
1929 bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
1930 {
1931         struct bnxt *bp = dev->data->dev_private;
1932         struct bnxt_vnic_info *vnic;
1933         struct rte_flow *flow;
1934         unsigned int i;
1935         int ret = 0;
1936
1937         bnxt_acquire_flow_lock(bp);
1938         for (i = 0; i < bp->max_vnics; i++) {
1939                 vnic = &bp->vnic_info[i];
1940                 if (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)
1941                         continue;
1942
1943                 while (!STAILQ_EMPTY(&vnic->flow_list)) {
1944                         flow = STAILQ_FIRST(&vnic->flow_list);
1945
1946                         if (!flow->filter)
1947                                 continue;
1948
1949                         ret = _bnxt_flow_destroy(bp, flow, error);
1950                         if (ret)
1951                                 break;
1952                 }
1953         }
1954         bnxt_release_flow_lock(bp);
1955
1956         return ret;
1957 }
1958
1959 const struct rte_flow_ops bnxt_flow_ops = {
1960         .validate = bnxt_flow_validate,
1961         .create = bnxt_flow_create,
1962         .destroy = bnxt_flow_destroy,
1963         .flush = bnxt_flow_flush,
1964 };