net/bnxt: fix duplicate pattern for 5tuple filter
[dpdk.git] / drivers / net / bnxt / bnxt_ethdev.c
index 97810f6..41b23cc 100644 (file)
@@ -145,7 +145,8 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
        ETH_RSS_NONFRAG_IPV6_TCP |      \
        ETH_RSS_NONFRAG_IPV6_UDP)
 
-static void bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
+static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
+static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
 
 /***********************/
 
@@ -370,12 +371,17 @@ static int bnxt_init_chip(struct bnxt *bp)
                        goto err_out;
                }
        }
+       bnxt_print_link_info(bp->eth_dev);
 
        return 0;
 
 err_out:
        bnxt_free_all_hwrm_resources(bp);
 
+       /* Some of the error status returned by FW may not be from errno.h */
+       if (rc > 0)
+               rc = -EIO;
+
        return rc;
 }
 
@@ -391,7 +397,10 @@ static int bnxt_init_nic(struct bnxt *bp)
 {
        int rc;
 
-       bnxt_init_ring_grps(bp);
+       rc = bnxt_init_ring_grps(bp);
+       if (rc)
+               return rc;
+
        bnxt_init_vnics(bp);
        bnxt_init_filters(bp);
 
@@ -436,8 +445,13 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        dev_info->min_rx_bufsize = 1;
        dev_info->max_rx_pktlen = BNXT_MAX_MTU + ETHER_HDR_LEN + ETHER_CRC_LEN
                                  + VLAN_TAG_SIZE;
-       dev_info->rx_offload_capa = 0;
-       dev_info->tx_offload_capa = DEV_TX_OFFLOAD_IPV4_CKSUM |
+       dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
+                                       DEV_RX_OFFLOAD_IPV4_CKSUM |
+                                       DEV_RX_OFFLOAD_UDP_CKSUM |
+                                       DEV_RX_OFFLOAD_TCP_CKSUM |
+                                       DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
+       dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |
+                                       DEV_TX_OFFLOAD_IPV4_CKSUM |
                                        DEV_TX_OFFLOAD_TCP_CKSUM |
                                        DEV_TX_OFFLOAD_UDP_CKSUM |
                                        DEV_TX_OFFLOAD_TCP_TSO |
@@ -528,20 +542,6 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)
        return 0;
 }
 
-static inline int
-rte_bnxt_atomic_write_link_status(struct rte_eth_dev *eth_dev,
-                               struct rte_eth_link *link)
-{
-       struct rte_eth_link *dst = &eth_dev->data->dev_link;
-       struct rte_eth_link *src = link;
-
-       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
-                                       *(uint64_t *)src) == 0)
-               return 1;
-
-       return 0;
-}
-
 static void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
 {
        struct rte_eth_link *link = &eth_dev->data->dev_link;
@@ -569,20 +569,28 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
        int vlan_mask = 0;
        int rc;
 
+       if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {
+               RTE_LOG(ERR, PMD,
+                       "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
+                       bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
+       }
        bp->dev_stopped = 0;
 
        rc = bnxt_init_nic(bp);
        if (rc)
                goto error;
 
-       bnxt_link_update_op(eth_dev, 0);
+       bnxt_link_update_op(eth_dev, 1);
 
        if (eth_dev->data->dev_conf.rxmode.hw_vlan_filter)
                vlan_mask |= ETH_VLAN_FILTER_MASK;
        if (eth_dev->data->dev_conf.rxmode.hw_vlan_strip)
                vlan_mask |= ETH_VLAN_STRIP_MASK;
-       bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
+       rc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
+       if (rc)
+               goto error;
 
+       bp->flags |= BNXT_FLAG_INIT_DONE;
        return 0;
 
 error:
@@ -595,9 +603,14 @@ error:
 static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;
+       int rc = 0;
+
+       if (!bp->link_info.link_up)
+               rc = bnxt_set_hwrm_link_config(bp, true);
+       if (!rc)
+               eth_dev->data->dev_link.link_status = 1;
 
-       eth_dev->data->dev_link.link_status = 1;
-       bnxt_set_hwrm_link_config(bp, true);
+       bnxt_print_link_info(eth_dev);
        return 0;
 }
 
@@ -607,6 +620,8 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev)
 
        eth_dev->data->dev_link.link_status = 0;
        bnxt_set_hwrm_link_config(bp, false);
+       bp->link_info.link_up = 0;
+
        return 0;
 }
 
@@ -621,6 +636,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
        }
        bnxt_set_hwrm_link_config(bp, false);
        bnxt_hwrm_port_clr_stats(bp);
+       bp->flags &= ~BNXT_FLAG_INIT_DONE;
        bnxt_shutdown_nic(bp);
        bp->dev_stopped = 1;
 }
@@ -652,13 +668,14 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,
        uint64_t pool_mask = eth_dev->data->mac_pool_sel[index];
        struct bnxt_vnic_info *vnic;
        struct bnxt_filter_info *filter, *temp_filter;
-       int i;
+       uint32_t pool = RTE_MIN(MAX_FF_POOLS, ETH_64_POOLS);
+       uint32_t i;
 
        /*
         * Loop through all VNICs from the specified filter flow pools to
         * remove the corresponding MAC addr filter
         */
-       for (i = 0; i < MAX_FF_POOLS; i++) {
+       for (i = 0; i < pool; i++) {
                if (!(pool_mask & (1ULL << i)))
                        continue;
 
@@ -747,7 +764,8 @@ out:
        /* Timed out or success */
        if (new.link_status != eth_dev->data->dev_link.link_status ||
        new.link_speed != eth_dev->data->dev_link.link_speed) {
-               rte_bnxt_atomic_write_link_status(eth_dev, &new);
+               memcpy(&eth_dev->data->dev_link, &new,
+                       sizeof(struct rte_eth_link));
                bnxt_print_link_info(eth_dev);
        }
 
@@ -860,7 +878,7 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,
                        "(%d)\n", reta_size, HW_HASH_INDEX_SIZE);
                return -EINVAL;
        }
-       /* EW - need to revisit here copying from u64 to u16 */
+       /* EW - need to revisit here copying from uint64_t to uint16_t */
        memcpy(reta_conf, vnic->rss_table, reta_size);
 
        if (rte_intr_allow_others(intr_handle)) {
@@ -1023,7 +1041,7 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
 {
        struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
 
-       if (BNXT_NPAR_PF(bp) || BNXT_VF(bp)) {
+       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
                RTE_LOG(ERR, PMD, "Flow Control Settings cannot be modified\n");
                return -ENOTSUP;
        }
@@ -1339,7 +1357,7 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev,
                return bnxt_del_vlan_filter(bp, vlan_id);
 }
 
-static void
+static int
 bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)
 {
        struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
@@ -1371,6 +1389,8 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)
 
        if (mask & ETH_VLAN_EXTEND_MASK)
                RTE_LOG(ERR, PMD, "Extend VLAN Not supported\n");
+
+       return 0;
 }
 
 static void
@@ -1552,7 +1572,7 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev, uint16_t pvid, int on)
        uint16_t vlan = bp->vlan;
        int rc;
 
-       if (BNXT_NPAR_PF(bp) || BNXT_VF(bp)) {
+       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
                RTE_LOG(ERR, PMD,
                        "PVID cannot be modified for this function\n");
                return -ENOTSUP;
@@ -1604,7 +1624,7 @@ bnxt_rx_queue_count_op(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                        goto nothing_to_do;
                valid = FLIP_VALID(cons, cpr->cp_ring_struct->ring_mask, valid);
                cmp_type = CMP_TYPE(rxcmp);
-               if (cmp_type == RX_PKT_CMPL_TYPE_RX_L2_TPA_END) {
+               if (cmp_type == RX_TPA_END_CMPL_TYPE_RX_TPA_END) {
                        cmp = (rte_le_to_cpu_32(
                                        ((struct rx_tpa_end_cmpl *)
                                         (rxcmp))->agg_bufs_v1) &
@@ -1712,15 +1732,17 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
        int match = 0;
        *ret = 0;
 
-       if (efilter->ether_type != ETHER_TYPE_IPv4 &&
-               efilter->ether_type != ETHER_TYPE_IPv6) {
-               RTE_LOG(ERR, PMD, "unsupported ether_type(0x%04x) in"
+       if (efilter->ether_type == ETHER_TYPE_IPv4 ||
+               efilter->ether_type == ETHER_TYPE_IPv6) {
+               RTE_LOG(ERR, PMD, "invalid ether_type(0x%04x) in"
                        " ethertype filter.", efilter->ether_type);
                *ret = -EINVAL;
+               goto exit;
        }
        if (efilter->queue >= bp->rx_nr_rings) {
                RTE_LOG(ERR, PMD, "Invalid queue %d\n", efilter->queue);
                *ret = -EINVAL;
+               goto exit;
        }
 
        vnic0 = STAILQ_FIRST(&bp->ff_pool[0]);
@@ -1728,6 +1750,7 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
        if (vnic == NULL) {
                RTE_LOG(ERR, PMD, "Invalid queue %d\n", efilter->queue);
                *ret = -EINVAL;
+               goto exit;
        }
 
        if (efilter->flags & RTE_ETHTYPE_FLAGS_DROP) {
@@ -1756,6 +1779,7 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
        if (match)
                *ret = -EEXIST;
 
+exit:
        return mfilter;
 }
 
@@ -1937,25 +1961,33 @@ parse_ntuple_filter(struct bnxt *bp,
 }
 
 static struct bnxt_filter_info*
-bnxt_match_ntuple_filter(struct bnxt_vnic_info *vnic,
-                        struct bnxt_filter_info *bfilter)
+bnxt_match_ntuple_filter(struct bnxt *bp,
+                        struct bnxt_filter_info *bfilter,
+                        struct bnxt_vnic_info **mvnic)
 {
        struct bnxt_filter_info *mfilter = NULL;
+       int i;
 
-       STAILQ_FOREACH(mfilter, &vnic->filter, next) {
-               if (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&
-                   bfilter->src_ipaddr_mask[0] ==
-                   mfilter->src_ipaddr_mask[0] &&
-                   bfilter->src_port == mfilter->src_port &&
-                   bfilter->src_port_mask == mfilter->src_port_mask &&
-                   bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&
-                   bfilter->dst_ipaddr_mask[0] ==
-                   mfilter->dst_ipaddr_mask[0] &&
-                   bfilter->dst_port == mfilter->dst_port &&
-                   bfilter->dst_port_mask == mfilter->dst_port_mask &&
-                   bfilter->flags == mfilter->flags &&
-                   bfilter->enables == mfilter->enables)
-                       return mfilter;
+       for (i = bp->nr_vnics - 1; i >= 0; i--) {
+               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+               STAILQ_FOREACH(mfilter, &vnic->filter, next) {
+                       if (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&
+                           bfilter->src_ipaddr_mask[0] ==
+                           mfilter->src_ipaddr_mask[0] &&
+                           bfilter->src_port == mfilter->src_port &&
+                           bfilter->src_port_mask == mfilter->src_port_mask &&
+                           bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&
+                           bfilter->dst_ipaddr_mask[0] ==
+                           mfilter->dst_ipaddr_mask[0] &&
+                           bfilter->dst_port == mfilter->dst_port &&
+                           bfilter->dst_port_mask == mfilter->dst_port_mask &&
+                           bfilter->flags == mfilter->flags &&
+                           bfilter->enables == mfilter->enables) {
+                               if (mvnic)
+                                       *mvnic = vnic;
+                               return mfilter;
+                       }
+               }
        }
        return NULL;
 }
@@ -1966,7 +1998,7 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,
                       enum rte_filter_op filter_op)
 {
        struct bnxt_filter_info *bfilter, *mfilter, *filter1;
-       struct bnxt_vnic_info *vnic, *vnic0;
+       struct bnxt_vnic_info *vnic, *vnic0, *mvnic;
        int ret;
 
        if (nfilter->flags != RTE_5TUPLE_FLAGS) {
@@ -2004,12 +2036,22 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,
        bfilter->ethertype = 0x800;
        bfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
 
-       mfilter = bnxt_match_ntuple_filter(vnic, bfilter);
+       mfilter = bnxt_match_ntuple_filter(bp, bfilter, &mvnic);
 
-       if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD) {
-               RTE_LOG(ERR, PMD, "filter exists.");
+       if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD &&
+           bfilter->dst_id == mfilter->dst_id) {
+               RTE_LOG(ERR, PMD, "filter exists.\n");
                ret = -EEXIST;
                goto free_filter;
+       } else if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD &&
+                  bfilter->dst_id != mfilter->dst_id) {
+               mfilter->dst_id = vnic->fw_vnic_id;
+               ret = bnxt_hwrm_set_ntuple_filter(bp, mfilter->dst_id, mfilter);
+               STAILQ_REMOVE(&mvnic->filter, mfilter, bnxt_filter_info, next);
+               STAILQ_INSERT_TAIL(&vnic->filter, mfilter, next);
+               RTE_LOG(ERR, PMD, "filter with matching pattern exists.\n");
+               RTE_LOG(ERR, PMD, " Updated it to the new destination queue\n");
+               goto free_filter;
        }
        if (mfilter == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
                RTE_LOG(ERR, PMD, "filter doesn't exist.");
@@ -2024,13 +2066,18 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,
                        goto free_filter;
                STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next);
        } else {
+               if (mfilter == NULL) {
+                       /* This should not happen. But for Coverity! */
+                       ret = -ENOENT;
+                       goto free_filter;
+               }
                ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter);
 
-               STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info,
-                             next);
+               STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info, next);
                bnxt_free_filter(bp, mfilter);
-               bfilter->fw_l2_filter_id = -1;
+               mfilter->fw_l2_filter_id = -1;
                bnxt_free_filter(bp, bfilter);
+               bfilter->fw_l2_filter_id = -1;
        }
 
        return 0;
@@ -2075,6 +2122,385 @@ bnxt_ntuple_filter(struct rte_eth_dev *dev,
        }
        return ret;
 }
+
+static int
+bnxt_parse_fdir_filter(struct bnxt *bp,
+                      struct rte_eth_fdir_filter *fdir,
+                      struct bnxt_filter_info *filter)
+{
+       enum rte_fdir_mode fdir_mode =
+               bp->eth_dev->data->dev_conf.fdir_conf.mode;
+       struct bnxt_vnic_info *vnic0, *vnic;
+       struct bnxt_filter_info *filter1;
+       uint32_t en = 0;
+       int i;
+
+       if (fdir_mode == RTE_FDIR_MODE_PERFECT_TUNNEL)
+               return -EINVAL;
+
+       filter->l2_ovlan = fdir->input.flow_ext.vlan_tci;
+       en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
+
+       switch (fdir->input.flow_type) {
+       case RTE_ETH_FLOW_IPV4:
+       case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
+               /* FALLTHROUGH */
+               filter->src_ipaddr[0] = fdir->input.flow.ip4_flow.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.ip4_flow.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = fdir->input.flow.ip4_flow.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
+               filter->src_port = fdir->input.flow.tcp4_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.tcp4_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->src_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = 6;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV4_UDP:
+               filter->src_port = fdir->input.flow.udp4_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.udp4_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->src_ipaddr[0] = fdir->input.flow.udp4_flow.ip.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.udp4_flow.ip.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = 17;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_IPV6:
+       case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER:
+               /* FALLTHROUGH */
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.ipv6_flow.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.ipv6_flow.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.ipv6_flow.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV6_TCP:
+               filter->src_port = fdir->input.flow.tcp6_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.tcp6_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.tcp6_flow.ip.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.tcp6_flow.ip.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.tcp6_flow.ip.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV6_UDP:
+               filter->src_port = fdir->input.flow.udp6_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.udp6_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.udp6_flow.ip.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.udp6_flow.ip.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.udp6_flow.ip.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_L2_PAYLOAD:
+               filter->ethertype = fdir->input.flow.l2_flow.ether_type;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_VXLAN:
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       return -EINVAL;
+               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
+               filter->tunnel_type =
+                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
+               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
+               break;
+       case RTE_ETH_FLOW_NVGRE:
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       return -EINVAL;
+               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
+               filter->tunnel_type =
+                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
+               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
+               break;
+       case RTE_ETH_FLOW_UNKNOWN:
+       case RTE_ETH_FLOW_RAW:
+       case RTE_ETH_FLOW_FRAG_IPV4:
+       case RTE_ETH_FLOW_NONFRAG_IPV4_SCTP:
+       case RTE_ETH_FLOW_FRAG_IPV6:
+       case RTE_ETH_FLOW_NONFRAG_IPV6_SCTP:
+       case RTE_ETH_FLOW_IPV6_EX:
+       case RTE_ETH_FLOW_IPV6_TCP_EX:
+       case RTE_ETH_FLOW_IPV6_UDP_EX:
+       case RTE_ETH_FLOW_GENEVE:
+               /* FALLTHROUGH */
+       default:
+               return -EINVAL;
+       }
+
+       vnic0 = STAILQ_FIRST(&bp->ff_pool[0]);
+       vnic = STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);
+       if (vnic == NULL) {
+               RTE_LOG(ERR, PMD, "Invalid queue %d\n", fdir->action.rx_queue);
+               return -EINVAL;
+       }
+
+
+       if (fdir_mode == RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+               rte_memcpy(filter->dst_macaddr,
+                       fdir->input.flow.mac_vlan_flow.mac_addr.addr_bytes, 6);
+                       en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR;
+       }
+
+       if (fdir->action.behavior == RTE_ETH_FDIR_REJECT) {
+               filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
+               filter1 = STAILQ_FIRST(&vnic0->filter);
+               //filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
+       } else {
+               filter->dst_id = vnic->fw_vnic_id;
+               for (i = 0; i < ETHER_ADDR_LEN; i++)
+                       if (filter->dst_macaddr[i] == 0x00)
+                               filter1 = STAILQ_FIRST(&vnic0->filter);
+                       else
+                               filter1 = bnxt_get_l2_filter(bp, filter, vnic);
+       }
+
+       if (filter1 == NULL)
+               return -EINVAL;
+
+       en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
+       filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
+
+       filter->enables = en;
+
+       return 0;
+}
+
+static struct bnxt_filter_info *
+bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf)
+{
+       struct bnxt_filter_info *mf = NULL;
+       int i;
+
+       for (i = bp->nr_vnics - 1; i >= 0; i--) {
+               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+
+               STAILQ_FOREACH(mf, &vnic->filter, next) {
+                       if (mf->filter_type == nf->filter_type &&
+                           mf->flags == nf->flags &&
+                           mf->src_port == nf->src_port &&
+                           mf->src_port_mask == nf->src_port_mask &&
+                           mf->dst_port == nf->dst_port &&
+                           mf->dst_port_mask == nf->dst_port_mask &&
+                           mf->ip_protocol == nf->ip_protocol &&
+                           mf->ip_addr_type == nf->ip_addr_type &&
+                           mf->ethertype == nf->ethertype &&
+                           mf->vni == nf->vni &&
+                           mf->tunnel_type == nf->tunnel_type &&
+                           mf->l2_ovlan == nf->l2_ovlan &&
+                           mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
+                           mf->l2_ivlan == nf->l2_ivlan &&
+                           mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
+                           !memcmp(mf->l2_addr, nf->l2_addr, ETHER_ADDR_LEN) &&
+                           !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->src_macaddr, nf->src_macaddr,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->dst_macaddr, nf->dst_macaddr,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->src_ipaddr, nf->src_ipaddr,
+                                   sizeof(nf->src_ipaddr)) &&
+                           !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
+                                   sizeof(nf->src_ipaddr_mask)) &&
+                           !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
+                                   sizeof(nf->dst_ipaddr)) &&
+                           !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
+                                   sizeof(nf->dst_ipaddr_mask)))
+                               return mf;
+               }
+       }
+       return NULL;
+}
+
+static int
+bnxt_fdir_filter(struct rte_eth_dev *dev,
+                enum rte_filter_op filter_op,
+                void *arg)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct rte_eth_fdir_filter *fdir  = (struct rte_eth_fdir_filter *)arg;
+       struct bnxt_filter_info *filter, *match;
+       struct bnxt_vnic_info *vnic;
+       int ret = 0, i;
+
+       if (filter_op == RTE_ETH_FILTER_NOP)
+               return 0;
+
+       if (arg == NULL && filter_op != RTE_ETH_FILTER_FLUSH)
+               return -EINVAL;
+
+       switch (filter_op) {
+       case RTE_ETH_FILTER_ADD:
+       case RTE_ETH_FILTER_DELETE:
+               /* FALLTHROUGH */
+               filter = bnxt_get_unused_filter(bp);
+               if (filter == NULL) {
+                       RTE_LOG(ERR, PMD,
+                               "Not enough resources for a new flow.\n");
+                       return -ENOMEM;
+               }
+
+               ret = bnxt_parse_fdir_filter(bp, fdir, filter);
+               if (ret != 0)
+                       goto free_filter;
+               filter->filter_type = HWRM_CFA_NTUPLE_FILTER;
+
+               match = bnxt_match_fdir(bp, filter);
+               if (match != NULL && filter_op == RTE_ETH_FILTER_ADD) {
+                       RTE_LOG(ERR, PMD, "Flow already exists.\n");
+                       ret = -EEXIST;
+                       goto free_filter;
+               }
+               if (match == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
+                       RTE_LOG(ERR, PMD, "Flow does not exist.\n");
+                       ret = -ENOENT;
+                       goto free_filter;
+               }
+
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       vnic = STAILQ_FIRST(&bp->ff_pool[0]);
+               else
+                       vnic =
+                       STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);
+
+               if (filter_op == RTE_ETH_FILTER_ADD) {
+                       ret = bnxt_hwrm_set_ntuple_filter(bp,
+                                                         filter->dst_id,
+                                                         filter);
+                       if (ret)
+                               goto free_filter;
+                       STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
+               } else {
+                       ret = bnxt_hwrm_clear_ntuple_filter(bp, match);
+                       STAILQ_REMOVE(&vnic->filter, match,
+                                     bnxt_filter_info, next);
+                       bnxt_free_filter(bp, match);
+                       filter->fw_l2_filter_id = -1;
+                       bnxt_free_filter(bp, filter);
+               }
+               break;
+       case RTE_ETH_FILTER_FLUSH:
+               for (i = bp->nr_vnics - 1; i >= 0; i--) {
+                       struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+
+                       STAILQ_FOREACH(filter, &vnic->filter, next) {
+                               if (filter->filter_type ==
+                                   HWRM_CFA_NTUPLE_FILTER) {
+                                       ret =
+                                       bnxt_hwrm_clear_ntuple_filter(bp,
+                                                                     filter);
+                                       STAILQ_REMOVE(&vnic->filter, filter,
+                                                     bnxt_filter_info, next);
+                               }
+                       }
+               }
+               return ret;
+       case RTE_ETH_FILTER_UPDATE:
+       case RTE_ETH_FILTER_STATS:
+       case RTE_ETH_FILTER_INFO:
+               /* FALLTHROUGH */
+               RTE_LOG(ERR, PMD, "operation %u not implemented", filter_op);
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "unknown operation %u", filter_op);
+               ret = -EINVAL;
+               break;
+       }
+       return ret;
+
+free_filter:
+       filter->fw_l2_filter_id = -1;
+       bnxt_free_filter(bp, filter);
+       return ret;
+}
+
 static int
 bnxt_filter_ctrl_op(struct rte_eth_dev *dev __rte_unused,
                    enum rte_filter_type filter_type,
@@ -2083,12 +2509,13 @@ bnxt_filter_ctrl_op(struct rte_eth_dev *dev __rte_unused,
        int ret = 0;
 
        switch (filter_type) {
-       case RTE_ETH_FILTER_FDIR:
        case RTE_ETH_FILTER_TUNNEL:
-               /* FALLTHROUGH */
                RTE_LOG(ERR, PMD,
                        "filter type: %d: To be implemented\n", filter_type);
                break;
+       case RTE_ETH_FILTER_FDIR:
+               ret = bnxt_fdir_filter(dev, filter_op, arg);
+               break;
        case RTE_ETH_FILTER_NTUPLE:
                ret = bnxt_ntuple_filter(dev, filter_op, arg);
                break;
@@ -2132,7 +2559,260 @@ bnxt_dev_supported_ptypes_get_op(struct rte_eth_dev *dev)
        return NULL;
 }
 
+static int bnxt_map_regs(struct bnxt *bp, uint32_t *reg_arr, int count,
+                        int reg_win)
+{
+       uint32_t reg_base = *reg_arr & 0xfffff000;
+       uint32_t win_off;
+       int i;
+
+       for (i = 0; i < count; i++) {
+               if ((reg_arr[i] & 0xfffff000) != reg_base)
+                       return -ERANGE;
+       }
+       win_off = BNXT_GRCPF_REG_WINDOW_BASE_OUT + (reg_win - 1) * 4;
+       rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off));
+       return 0;
+}
+
+static int bnxt_map_ptp_regs(struct bnxt *bp)
+{
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint32_t *reg_arr;
+       int rc, i;
+
+       reg_arr = ptp->rx_regs;
+       rc = bnxt_map_regs(bp, reg_arr, BNXT_PTP_RX_REGS, 5);
+       if (rc)
+               return rc;
+
+       reg_arr = ptp->tx_regs;
+       rc = bnxt_map_regs(bp, reg_arr, BNXT_PTP_TX_REGS, 6);
+       if (rc)
+               return rc;
+
+       for (i = 0; i < BNXT_PTP_RX_REGS; i++)
+               ptp->rx_mapped_regs[i] = 0x5000 + (ptp->rx_regs[i] & 0xfff);
+
+       for (i = 0; i < BNXT_PTP_TX_REGS; i++)
+               ptp->tx_mapped_regs[i] = 0x6000 + (ptp->tx_regs[i] & 0xfff);
+
+       return 0;
+}
+
+static void bnxt_unmap_ptp_regs(struct bnxt *bp)
+{
+       rte_cpu_to_le_32(rte_write32(0, (uint8_t *)bp->bar0 +
+                        BNXT_GRCPF_REG_WINDOW_BASE_OUT + 16));
+       rte_cpu_to_le_32(rte_write32(0, (uint8_t *)bp->bar0 +
+                        BNXT_GRCPF_REG_WINDOW_BASE_OUT + 20));
+}
+
+static uint64_t bnxt_cc_read(struct bnxt *bp)
+{
+       uint64_t ns;
+
+       ns = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                             BNXT_GRCPF_REG_SYNC_TIME));
+       ns |= (uint64_t)(rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                                         BNXT_GRCPF_REG_SYNC_TIME + 4))) << 32;
+       return ns;
+}
+
+static int bnxt_get_tx_ts(struct bnxt *bp, uint64_t *ts)
+{
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint32_t fifo;
+
+       fifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->tx_mapped_regs[BNXT_PTP_TX_FIFO]));
+       if (fifo & BNXT_PTP_TX_FIFO_EMPTY)
+               return -EAGAIN;
+
+       fifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->tx_mapped_regs[BNXT_PTP_TX_FIFO]));
+       *ts = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->tx_mapped_regs[BNXT_PTP_TX_TS_L]));
+       *ts |= (uint64_t)rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->tx_mapped_regs[BNXT_PTP_TX_TS_H])) << 32;
+
+       return 0;
+}
+
+static int bnxt_get_rx_ts(struct bnxt *bp, uint64_t *ts)
+{
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       struct bnxt_pf_info *pf = &bp->pf;
+       uint16_t port_id;
+       uint32_t fifo;
+
+       if (!ptp)
+               return -ENODEV;
+
+       fifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO]));
+       if (!(fifo & BNXT_PTP_RX_FIFO_PENDING))
+               return -EAGAIN;
+
+       port_id = pf->port_id;
+       rte_cpu_to_le_32(rte_write32(1 << port_id, (uint8_t *)bp->bar0 +
+              ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO_ADV]));
+
+       fifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                                  ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO]));
+       if (fifo & BNXT_PTP_RX_FIFO_PENDING) {
+/*             bnxt_clr_rx_ts(bp);       TBD  */
+               return -EBUSY;
+       }
+
+       *ts = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->rx_mapped_regs[BNXT_PTP_RX_TS_L]));
+       *ts |= (uint64_t)rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +
+                               ptp->rx_mapped_regs[BNXT_PTP_RX_TS_H])) << 32;
+
+       return 0;
+}
+
+static int
+bnxt_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts)
+{
+       uint64_t ns;
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+
+       if (!ptp)
+               return 0;
+
+       ns = rte_timespec_to_ns(ts);
+       /* Set the timecounters to a new value. */
+       ptp->tc.nsec = ns;
+
+       return 0;
+}
+
+static int
+bnxt_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)
+{
+       uint64_t ns, systime_cycles;
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+
+       if (!ptp)
+               return 0;
+
+       systime_cycles = bnxt_cc_read(bp);
+       ns = rte_timecounter_update(&ptp->tc, systime_cycles);
+       *ts = rte_ns_to_timespec(ns);
+
+       return 0;
+}
+static int
+bnxt_timesync_enable(struct rte_eth_dev *dev)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint32_t shift = 0;
+
+       if (!ptp)
+               return 0;
+
+       ptp->rx_filter = 1;
+       ptp->tx_tstamp_en = 1;
+       ptp->rxctl = BNXT_PTP_MSG_EVENTS;
+
+       if (!bnxt_hwrm_ptp_cfg(bp))
+               bnxt_map_ptp_regs(bp);
+
+       memset(&ptp->tc, 0, sizeof(struct rte_timecounter));
+       memset(&ptp->rx_tstamp_tc, 0, sizeof(struct rte_timecounter));
+       memset(&ptp->tx_tstamp_tc, 0, sizeof(struct rte_timecounter));
+
+       ptp->tc.cc_mask = BNXT_CYCLECOUNTER_MASK;
+       ptp->tc.cc_shift = shift;
+       ptp->tc.nsec_mask = (1ULL << shift) - 1;
+
+       ptp->rx_tstamp_tc.cc_mask = BNXT_CYCLECOUNTER_MASK;
+       ptp->rx_tstamp_tc.cc_shift = shift;
+       ptp->rx_tstamp_tc.nsec_mask = (1ULL << shift) - 1;
+
+       ptp->tx_tstamp_tc.cc_mask = BNXT_CYCLECOUNTER_MASK;
+       ptp->tx_tstamp_tc.cc_shift = shift;
+       ptp->tx_tstamp_tc.nsec_mask = (1ULL << shift) - 1;
+
+       return 0;
+}
+
+static int
+bnxt_timesync_disable(struct rte_eth_dev *dev)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+
+       if (!ptp)
+               return 0;
+
+       ptp->rx_filter = 0;
+       ptp->tx_tstamp_en = 0;
+       ptp->rxctl = 0;
+
+       bnxt_hwrm_ptp_cfg(bp);
+
+       bnxt_unmap_ptp_regs(bp);
+
+       return 0;
+}
+
+static int
+bnxt_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
+                                struct timespec *timestamp,
+                                uint32_t flags __rte_unused)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint64_t rx_tstamp_cycles = 0;
+       uint64_t ns;
+
+       if (!ptp)
+               return 0;
+
+       bnxt_get_rx_ts(bp, &rx_tstamp_cycles);
+       ns = rte_timecounter_update(&ptp->rx_tstamp_tc, rx_tstamp_cycles);
+       *timestamp = rte_ns_to_timespec(ns);
+       return  0;
+}
+
+static int
+bnxt_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
+                                struct timespec *timestamp)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint64_t tx_tstamp_cycles = 0;
+       uint64_t ns;
+
+       if (!ptp)
+               return 0;
 
+       bnxt_get_tx_ts(bp, &tx_tstamp_cycles);
+       ns = rte_timecounter_update(&ptp->tx_tstamp_tc, tx_tstamp_cycles);
+       *timestamp = rte_ns_to_timespec(ns);
+
+       return 0;
+}
+
+static int
+bnxt_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+
+       if (!ptp)
+               return 0;
+
+       ptp->tc.nsec += delta;
+
+       return 0;
+}
 
 static int
 bnxt_get_eeprom_length_op(struct rte_eth_dev *dev)
@@ -2328,6 +3008,13 @@ static const struct eth_dev_ops bnxt_dev_ops = {
        .get_eeprom_length    = bnxt_get_eeprom_length_op,
        .get_eeprom           = bnxt_get_eeprom_op,
        .set_eeprom           = bnxt_set_eeprom_op,
+       .timesync_enable      = bnxt_timesync_enable,
+       .timesync_disable     = bnxt_timesync_disable,
+       .timesync_read_time   = bnxt_timesync_read_time,
+       .timesync_write_time   = bnxt_timesync_write_time,
+       .timesync_adjust_time = bnxt_timesync_adjust_time,
+       .timesync_read_rx_timestamp = bnxt_timesync_read_rx_timestamp,
+       .timesync_read_tx_timestamp = bnxt_timesync_read_tx_timestamp,
 };
 
 static bool bnxt_vf_pciid(uint16_t id)
@@ -2392,7 +3079,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
        const struct rte_memzone *mz = NULL;
        static int version_printed;
        uint32_t total_alloc_len;
-       phys_addr_t mz_phys_addr;
+       rte_iova_t mz_phys_addr;
        struct bnxt *bp;
        int rc;
 
@@ -2400,7 +3087,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
                RTE_LOG(INFO, PMD, "%s\n", bnxt_version);
 
        rte_eth_copy_pci_info(eth_dev, pci_dev);
-       eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
 
        bp = eth_dev->data->dev_private;
 
@@ -2444,13 +3130,13 @@ skip_init:
                                return -ENOMEM;
                }
                memset(mz->addr, 0, mz->len);
-               mz_phys_addr = mz->phys_addr;
+               mz_phys_addr = mz->iova;
                if ((unsigned long)mz->addr == mz_phys_addr) {
                        RTE_LOG(WARNING, PMD,
                                "Memzone physical address same as virtual.\n");
                        RTE_LOG(WARNING, PMD,
-                               "Using rte_mem_virt2phy()\n");
-                       mz_phys_addr = rte_mem_virt2phy(mz->addr);
+                               "Using rte_mem_virt2iova()\n");
+                       mz_phys_addr = rte_mem_virt2iova(mz->addr);
                        if (mz_phys_addr == 0) {
                                RTE_LOG(ERR, PMD,
                                "unable to map address to physical memory\n");
@@ -2479,13 +3165,13 @@ skip_init:
                                return -ENOMEM;
                }
                memset(mz->addr, 0, mz->len);
-               mz_phys_addr = mz->phys_addr;
+               mz_phys_addr = mz->iova;
                if ((unsigned long)mz->addr == mz_phys_addr) {
                        RTE_LOG(WARNING, PMD,
                                "Memzone physical address same as virtual.\n");
                        RTE_LOG(WARNING, PMD,
-                               "Using rte_mem_virt2phy()\n");
-                       mz_phys_addr = rte_mem_virt2phy(mz->addr);
+                               "Using rte_mem_virt2iova()\n");
+                       mz_phys_addr = rte_mem_virt2iova(mz->addr);
                        if (mz_phys_addr == 0) {
                                RTE_LOG(ERR, PMD,
                                "unable to map address to physical memory\n");
@@ -2509,9 +3195,17 @@ skip_init:
        rc = bnxt_hwrm_ver_get(bp);
        if (rc)
                goto error_free;
-       bnxt_hwrm_queue_qportcfg(bp);
+       rc = bnxt_hwrm_queue_qportcfg(bp);
+       if (rc) {
+               RTE_LOG(ERR, PMD, "hwrm queue qportcfg failed\n");
+               goto error_free;
+       }
 
-       bnxt_hwrm_func_qcfg(bp);
+       rc = bnxt_hwrm_func_qcfg(bp);
+       if (rc) {
+               RTE_LOG(ERR, PMD, "hwrm func qcfg failed\n");
+               goto error_free;
+       }
 
        /* Get the MAX capabilities for this function */
        rc = bnxt_hwrm_func_qcaps(bp);
@@ -2536,11 +3230,19 @@ skip_init:
        /* Copy the permanent MAC from the qcap response address now. */
        memcpy(bp->mac_addr, bp->dflt_mac_addr, sizeof(bp->mac_addr));
        memcpy(&eth_dev->data->mac_addrs[0], bp->mac_addr, ETHER_ADDR_LEN);
+
+       if (bp->max_ring_grps < bp->rx_cp_nr_rings) {
+               /* 1 ring is for default completion ring */
+               RTE_LOG(ERR, PMD, "Insufficient resource: Ring Group\n");
+               rc = -ENOSPC;
+               goto error_free;
+       }
+
        bp->grp_info = rte_zmalloc("bnxt_grp_info",
                                sizeof(*bp->grp_info) * bp->max_ring_grps, 0);
        if (!bp->grp_info) {
                RTE_LOG(ERR, PMD,
-                       "Failed to alloc %zu bytes needed to store group info table\n",
+                       "Failed to alloc %zu bytes to store group info table\n",
                        sizeof(*bp->grp_info) * bp->max_ring_grps);
                rc = -ENOMEM;
                goto error_free;
@@ -2568,6 +3270,8 @@ skip_init:
        ALLOW_FUNC(HWRM_VNIC_RSS_COS_LB_CTX_FREE);
        ALLOW_FUNC(HWRM_CFA_L2_FILTER_FREE);
        ALLOW_FUNC(HWRM_STAT_CTX_FREE);
+       ALLOW_FUNC(HWRM_PORT_PHY_QCFG);
+       ALLOW_FUNC(HWRM_VNIC_TPA_CFG);
        rc = bnxt_hwrm_func_driver_register(bp);
        if (rc) {
                RTE_LOG(ERR, PMD,
@@ -2584,7 +3288,7 @@ skip_init:
        rc = bnxt_hwrm_func_reset(bp);
        if (rc) {
                RTE_LOG(ERR, PMD, "hwrm chip reset failure rc: %x\n", rc);
-               rc = -1;
+               rc = -EIO;
                goto error_free;
        }