vhost/crypto: fix fetch size
authorFan Zhang <roy.fan.zhang@intel.com>
Wed, 29 Jan 2020 10:24:22 +0000 (10:24 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 5 Feb 2020 10:47:18 +0000 (11:47 +0100)
This patch fixes the incorrect rte_vhost_crypto_fetch_requests
return value.

Coverity issue: 343401
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
lib/librte_vhost/vhost_crypto.c

index 684fddc..6891197 100644 (file)
@@ -1539,18 +1539,18 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
 
        if (unlikely(dev == NULL)) {
                VC_LOG_ERR("Invalid vid %i", vid);
-               return -EINVAL;
+               return 0;
        }
 
        if (unlikely(qid >= VHOST_MAX_QUEUE_PAIRS)) {
                VC_LOG_ERR("Invalid qid %u", qid);
-               return -EINVAL;
+               return 0;
        }
 
        vcrypto = (struct vhost_crypto *)dev->extern_data;
        if (unlikely(vcrypto == NULL)) {
                VC_LOG_ERR("Cannot find required data, is it initialized?");
-               return -ENOENT;
+               return 0;
        }
 
        vq = dev->virtqueue[qid];
@@ -1572,7 +1572,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
                if (unlikely(rte_mempool_get_bulk(vcrypto->mbuf_pool,
                                (void **)mbufs, count * 2) < 0)) {
                        VC_LOG_ERR("Insufficient memory");
-                       return -ENOMEM;
+                       return 0;
                }
 
                for (i = 0; i < count; i++) {
@@ -1602,7 +1602,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
                if (unlikely(rte_mempool_get_bulk(vcrypto->mbuf_pool,
                                (void **)mbufs, count) < 0)) {
                        VC_LOG_ERR("Insufficient memory");
-                       return -ENOMEM;
+                       return 0;
                }
 
                for (i = 0; i < count; i++) {