power: fix governor storage to trim newlines
authorDavid Hunt <david.hunt@intel.com>
Fri, 29 Mar 2019 16:39:20 +0000 (16:39 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 1 Apr 2019 20:23:44 +0000 (22:23 +0200)
Currently the Power Libray stores the governor name with an embedded
newline read from the scaling_governor sysfs file. This patch strips
it out.

Fixes: 445c6528b55f ("power: common interface for guest and host")
Cc: stable@dpdk.org
Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_power/power_acpi_cpufreq.c
lib/librte_power/power_pstate_cpufreq.c

index 534efe8..49325d0 100644 (file)
@@ -147,6 +147,8 @@ power_set_governor_userspace(struct rte_power_info *pi)
 
        s = fgets(buf, sizeof(buf), f);
        FOPS_OR_NULL_GOTO(s, out);
+       /* Strip off terminating '\n' */
+       strtok(buf, "\n");
 
        /* Check if current governor is userspace */
        if (strncmp(buf, POWER_GOVERNOR_USERSPACE,
index 9c1a162..3e04e80 100644 (file)
@@ -292,6 +292,8 @@ power_set_governor_performance(struct pstate_power_info *pi)
 
        s = fgets(buf, sizeof(buf), f);
        FOPS_OR_NULL_GOTO(s, out);
+       /* Strip off terminating '\n' */
+       strtok(buf, "\n");
 
        /* Check if current governor is performance */
        if (strncmp(buf, POWER_GOVERNOR_PERF,