net/atlantic: remove extra checks for error codes
authorIgor Russkikh <igor.russkikh@aquantia.com>
Tue, 12 Mar 2019 15:24:55 +0000 (15:24 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 20 Mar 2019 17:15:42 +0000 (18:15 +0100)
Found by Coverity scan. Checks are useless
because at these code places err is always zero.

Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")
Cc: stable@dpdk.org
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
drivers/net/atlantic/hw_atl/hw_atl_utils.c

index f11093a..13f02b9 100644 (file)
@@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
                                goto err_exit;
                }
        } while (sw.tid != fw.tid || 0xFFFFU == fw.len);
-       if (err < 0)
-               goto err_exit;
 
        if (rpc) {
                if (fw.len) {
@@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)
        }
 
        err = hw_atl_utils_fw_rpc_call(self, rpc_size);
-       if (err < 0)
-               goto err_exit;
+
 err_exit:
        return err;
 }