devtools: fix result of svg include check
authorMichael Santana <msantana@redhat.com>
Mon, 4 Mar 2019 19:07:16 +0000 (14:07 -0500)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 4 Mar 2019 21:46:10 +0000 (22:46 +0100)
Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.

Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: stable@dpdk.org
Signed-off-by: Michael Santana <msantana@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
devtools/checkpatches.sh

index 2cf2404..3272774 100755 (executable)
@@ -73,7 +73,7 @@ check_forbidden_additions() { # <patch>
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using explicit .svg extension instead of .*' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1" || res = 1
+               "$1" || res=1
 
        return $res
 }