app/testpmd: check MAC address query
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Tue, 16 Mar 2021 06:51:36 +0000 (12:21 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 16 Mar 2021 10:17:09 +0000 (11:17 +0100)
This patch checks return value for rte_eth_dev_info_get() in show_macs().

Coverity issue: 353629
Fixes: e1d44d0ad623 ("app/testpmd: show MAC addresses added to a port")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
app/test-pmd/config.c

index 576d5ac..4ce75a8 100644 (file)
@@ -4930,7 +4930,8 @@ show_macs(portid_t port_id)
 
        dev = &rte_eth_devices[port_id];
 
-       rte_eth_dev_info_get(port_id, &dev_info);
+       if (eth_dev_info_get_print_err(port_id, &dev_info))
+               return;
 
        for (i = 0; i < dev_info.max_mac_addrs; i++) {
                addr = &dev->data->mac_addrs[i];