examples/eventdev: fix crash on exit
authorHarry van Haaren <harry.van.haaren@intel.com>
Tue, 5 May 2020 09:39:04 +0000 (10:39 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 11 May 2020 17:20:54 +0000 (19:20 +0200)
This commit fixes a segfault on exit by using Ctrl^C if the master lcore
was also being used as a worker core. The root cause of the issue was
that the interrupt handler was cleaning up resources such as the ethdev
and eventdev ports, and once the interrupt handler would return, that
thread would continue working as an eventdev worker, and dereference the
memory which just had free() called on it.

Fixed by moving the cleanup code from the interrupt handler to the
cleanup stage of main(), which the master thread will execute once
it has returned from its worker() functionality.

Fixes: 085edac2ca38 ("examples/eventdev_pipeline: support Tx adapter")
Cc: stable@dpdk.org
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Tested-by: Jun W Zhou <junx.w.zhou@intel.com>
examples/eventdev_pipeline/main.c

index d0da51b..2195826 100644 (file)
@@ -301,12 +301,6 @@ signal_handler(int signum)
 
                rte_eal_mp_wait_lcore();
 
-               RTE_ETH_FOREACH_DEV(portid) {
-                       rte_eth_dev_close(portid);
-               }
-
-               rte_event_dev_stop(0);
-               rte_event_dev_close(0);
        }
        if (signum == SIGTSTP)
                rte_event_dev_dump(0, stdout);
@@ -469,5 +463,14 @@ main(int argc, char **argv)
 
        }
 
+       RTE_ETH_FOREACH_DEV(portid) {
+               rte_eth_dev_close(portid);
+       }
+
+       rte_event_dev_stop(0);
+       rte_event_dev_close(0);
+
+       rte_eal_cleanup();
+
        return 0;
 }