net/bnxt: allow only unicast MAC address filter creation
authorAjit Khaparde <ajit.khaparde@broadcom.com>
Wed, 2 Oct 2019 23:25:51 +0000 (16:25 -0700)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 8 Oct 2019 10:14:31 +0000 (12:14 +0200)
Check if the application is trying to create filters using
broadcast and multicast MAC address and reject it.

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>
Reviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
drivers/net/bnxt/bnxt_flow.c

index 2e2b21d..4e6b4d7 100644 (file)
@@ -219,6 +219,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
                        }
 
                        if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
+                               if (!rte_is_unicast_ether_addr(&eth_spec->dst)) {
+                                       rte_flow_error_set(error,
+                                                          EINVAL,
+                                                          RTE_FLOW_ERROR_TYPE_ITEM,
+                                                          item,
+                                                          "DMAC is invalid");
+                                       return -rte_errno;
+                               }
                                rte_memcpy(filter->dst_macaddr,
                                           &eth_spec->dst, RTE_ETHER_ADDR_LEN);
                                en |= use_ntuple ?
@@ -233,6 +241,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
                        }
 
                        if (rte_is_broadcast_ether_addr(&eth_mask->src)) {
+                               if (!rte_is_unicast_ether_addr(&eth_spec->src)) {
+                                       rte_flow_error_set(error,
+                                                          EINVAL,
+                                                          RTE_FLOW_ERROR_TYPE_ITEM,
+                                                          item,
+                                                          "SMAC is invalid");
+                                       return -rte_errno;
+                               }
                                rte_memcpy(filter->src_macaddr,
                                           &eth_spec->src, RTE_ETHER_ADDR_LEN);
                                en |= use_ntuple ?