build: allow stricter fallthrough warnings
authorBruce Richardson <bruce.richardson@intel.com>
Mon, 7 Oct 2019 14:30:10 +0000 (15:30 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 23 Oct 2019 23:02:30 +0000 (01:02 +0200)
DPDK currently compiles with implicit-fallthrough=2 warning level. With gcc
-Wextra flag, the default level is 3, so some minor changes are needed to
support this in DPDK.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
drivers/net/bonding/rte_eth_bond_pmd.c
drivers/net/fm10k/base/meson.build
lib/librte_cmdline/cmdline_parse_num.c

index a2d13d9..1e38cbf 100644 (file)
@@ -2439,7 +2439,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)
                                bond_ctx->mode4.slave_link.link_autoneg;
                ethdev->data->dev_link.link_duplex =
                                bond_ctx->mode4.slave_link.link_duplex;
-               /* fall through to update link speed */
+               /* fall through */
+               /* to update link speed */
        case BONDING_MODE_ROUND_ROBIN:
        case BONDING_MODE_BALANCE:
        case BONDING_MODE_TLB:
index 5525cdc..9e1022f 100644 (file)
@@ -12,7 +12,8 @@ sources = [
 
 error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value',
        '-Wno-strict-aliasing', '-Wno-format-extra-args',
-       '-Wno-unused-variable', '-Wno-missing-field-initializers'
+       '-Wno-unused-variable', '-Wno-missing-field-initializers',
+       '-Wno-implicit-fallthrough'
 ]
 c_args = cflags
 if allow_experimental_apis
index 182ac12..478f181 100644 (file)
@@ -196,7 +196,7 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res,
 
                case HEX:
                        st = HEX_OK;
-                       /* fall-through no break */
+                       /* fall-through */
                case HEX_OK:
                        if (c >= '0' && c <= '9') {
                                if (add_to_res(c - '0', &res1, 16) < 0)