net/mlx5: fix flow director rules comparison
authorNélio Laranjeiro <nelio.laranjeiro@6wind.com>
Thu, 9 Nov 2017 12:43:06 +0000 (13:43 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 10 Nov 2017 08:27:27 +0000 (08:27 +0000)
When deleting/replacing a flow director rule the first rule of the list
was always the one replaced instead of the corresponding one.

Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
drivers/net/mlx5/mlx5_flow.c

index cd99cb0..3df8fba 100644 (file)
@@ -2914,13 +2914,16 @@ priv_fdir_filter_delete(struct priv *priv,
                        flow_h = flow_spec;
                        if (memcmp(spec, flow_spec,
                                   RTE_MIN(attr_h->size, flow_h->size)))
-                               continue;
+                               goto wrong_flow;
                        spec = (void *)((uintptr_t)attr + attr_h->size);
                        flow_spec = (void *)((uintptr_t)flow_attr +
                                             flow_h->size);
                }
                /* At this point, the flow match. */
                break;
+wrong_flow:
+               /* The flow does not match. */
+               continue;
        }
        if (flow)
                priv_flow_destroy(priv, &priv->flows, flow);