net/ipn3ke: delete identical branch
authorAndy Pei <andy.pei@intel.com>
Wed, 22 May 2019 06:44:42 +0000 (14:44 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 20 Jun 2019 21:42:04 +0000 (23:42 +0200)
Whether the if statement is true or not, the operation is identical.
It is unnecessary to check the if statement, so just delete the if
statement.

Coverity issue: 337928
Fixes: c820468ac99c ("net/ipn3ke: support TM")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
drivers/net/ipn3ke/ipn3ke_tm.c

index 4bcf3aa..39c49bc 100644 (file)
@@ -1541,23 +1541,12 @@ ipn3ke_tm_hierarchy_commit_check(struct rte_eth_dev *dev,
                                                NULL,
                                                rte_strerror(EINVAL));
                        }
-               } else if (n->node_state ==
-                       IPN3KE_TM_NODE_STATE_CONFIGURED_DEL) {
-                       if (n->level != IPN3KE_TM_NODE_LEVEL_VT ||
-                               n->n_children != 0) {
-                               return -rte_tm_error_set(error,
-                                               EINVAL,
-                                               RTE_TM_ERROR_TYPE_UNSPECIFIED,
-                                               NULL,
-                                               rte_strerror(EINVAL));
-                       } else {
-                               return -rte_tm_error_set(error,
+               } else if (n->node_state == IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)
+                       return -rte_tm_error_set(error,
                                                EINVAL,
                                                RTE_TM_ERROR_TYPE_UNSPECIFIED,
                                                NULL,
                                                rte_strerror(EINVAL));
-                       }
-               }
        }
 
        n = tm->h.port_commit_node;