net/i40e: add check for invalid VF queue number
authorBeilei Xing <beilei.xing@intel.com>
Tue, 18 Apr 2017 08:46:20 +0000 (16:46 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 19 Apr 2017 13:37:37 +0000 (15:37 +0200)
Add check to avoid invalid VF queue number is used in
tunnel filter.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
drivers/net/i40e/i40e_flow.c

index 8fe626c..0a0181f 100644 (file)
@@ -1234,13 +1234,19 @@ i40e_flow_parse_tunnel_action(struct rte_eth_dev *dev,
        if (act->type == RTE_FLOW_ACTION_TYPE_QUEUE) {
                act_q = (const struct rte_flow_action_queue *)act->conf;
                filter->queue_id = act_q->index;
-               if (!filter->is_to_vf)
-                       if (filter->queue_id >= pf->dev_data->nb_rx_queues) {
-                               rte_flow_error_set(error, EINVAL,
+               if ((!filter->is_to_vf) &&
+                   (filter->queue_id >= pf->dev_data->nb_rx_queues)) {
+                       rte_flow_error_set(error, EINVAL,
                                   RTE_FLOW_ERROR_TYPE_ACTION,
                                   act, "Invalid queue ID for tunnel filter");
-                               return -rte_errno;
-                       }
+                       return -rte_errno;
+               } else if (filter->is_to_vf &&
+                          (filter->queue_id >= pf->vf_nb_qps)) {
+                       rte_flow_error_set(error, EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_ACTION,
+                                  act, "Invalid queue ID for tunnel filter");
+                       return -rte_errno;
+               }
        }
 
        /* Check if the next non-void item is END */