kni: remove stubs for Rx mode or ioctl
authorStephen Hemminger <stephen@networkplumber.org>
Mon, 24 Jun 2019 16:47:06 +0000 (09:47 -0700)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 15 Jul 2019 17:13:50 +0000 (19:13 +0200)
The netdev subsystem already handles case where
network sevice does not support ioctl.

If device has no rx_mode hook it is not called.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
kernel/linux/kni/kni_net.c

index ad83658..c86337d 100644 (file)
@@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev)
        netif_wake_queue(dev);
 }
 
-/*
- * Ioctl commands
- */
-static int
-kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
-{
-       pr_debug("kni_net_ioctl group:%d cmd:%d\n",
-               ((struct kni_dev *)netdev_priv(dev))->group_id, cmd);
-
-       return -EOPNOTSUPP;
-}
-
-static void
-kni_net_set_rx_mode(struct net_device *dev)
-{
-}
-
 static int
 kni_net_change_mtu(struct net_device *dev, int new_mtu)
 {
@@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = {
        .ndo_change_rx_flags = kni_net_set_promiscusity,
        .ndo_start_xmit = kni_net_tx,
        .ndo_change_mtu = kni_net_change_mtu,
-       .ndo_do_ioctl = kni_net_ioctl,
-       .ndo_set_rx_mode = kni_net_set_rx_mode,
        .ndo_get_stats = kni_net_stats,
        .ndo_tx_timeout = kni_net_tx_timeout,
        .ndo_set_mac_address = kni_net_set_mac,