net/qede: add check for null return
authorShahed Shaikh <shahed.shaikh@cavium.com>
Sat, 27 Jan 2018 21:15:34 +0000 (13:15 -0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 29 Jan 2018 09:58:35 +0000 (10:58 +0100)
Test the return value of ecore_ptt_acquire for NULL.

Coverity issue: 257049
Fixes: d378cefab84e ("net/qede: add support for GENEVE tunneling offload")

Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
drivers/net/qede/qede_ethdev.c

index cab5059..c3cea6d 100644 (file)
@@ -681,7 +681,16 @@ qede_tunnel_update(struct qede_dev *qdev,
 
        for_each_hwfn(edev, i) {
                p_hwfn = &edev->hwfns[i];
-               p_ptt = IS_PF(edev) ? ecore_ptt_acquire(p_hwfn) : NULL;
+               if (IS_PF(edev)) {
+                       p_ptt = ecore_ptt_acquire(p_hwfn);
+                       if (!p_ptt) {
+                               DP_ERR(p_hwfn, "Can't acquire PTT\n");
+                               return -EAGAIN;
+                       }
+               } else {
+                       p_ptt = NULL;
+               }
+
                rc = ecore_sp_pf_update_tunn_cfg(p_hwfn, p_ptt,
                                tunn_info, ECORE_SPQ_MODE_CB, NULL);
                if (IS_PF(edev))