net/bnxt: fix non matching flow hitting filter rule
authorSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Sat, 21 Dec 2019 02:29:40 +0000 (18:29 -0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 17 Jan 2020 18:46:01 +0000 (19:46 +0100)
As part of ntuple filter, we were creating L2 filter with the ntuple
redirect queue resulting in any L2 matching flow getting steered to
this queue. For ntuple filters, we need to create the L2 filter with
default queue. The user specified redirect queue will be set while
creating the ntuple filter in hardware.

Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
Cc: stable@dpdk.org
Signed-off-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_flow.c

index 7343b7e..855994a 100644 (file)
@@ -1126,7 +1126,16 @@ use_vnic:
                PMD_DRV_LOG(DEBUG,
                            "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
                filter->dst_id = vnic->fw_vnic_id;
-               filter1 = bnxt_get_l2_filter(bp, filter, vnic);
+
+               /* For ntuple filter, create the L2 filter with default VNIC.
+                * The user specified redirect queue will be set while creating
+                * the ntuple filter in hardware.
+                */
+               vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
+               if (use_ntuple)
+                       filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
+               else
+                       filter1 = bnxt_get_l2_filter(bp, filter, vnic);
                if (filter1 == NULL) {
                        rte_flow_error_set(error,
                                           ENOSPC,