eal: fix check of all requested CPU features
authorNeil Horman <nhorman@tuxdriver.com>
Wed, 16 Apr 2014 10:50:40 +0000 (06:50 -0400)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Thu, 17 Apr 2014 22:20:04 +0000 (00:20 +0200)
Only the last feature was checked since commit 99f2cdf9ca10
(eal: fix %rbx corruption and simplify the code)

The return code for rte_cpu_get_flag_enabled is only checked on the termination
of the for loop that it is called inside, but should be checked for every
iteration it makes through the for loop.  This is caused by some silly missing
brackets.  Simply add them in

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Pablo De Lara Guarch <pablo.de.lara.guarch@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
lib/librte_eal/common/eal_common_cpuflags.c

index f9c1840..5c0927c 100644 (file)
@@ -255,7 +255,7 @@ rte_cpu_check_supported(void)
        unsigned i;
        int ret;
 
-       for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++)
+       for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) {
                ret = rte_cpu_get_flag_enabled(compile_time_flags[i]);
 
                if (ret < 0) {
@@ -271,4 +271,5 @@ rte_cpu_check_supported(void)
                                cpu_feature_table[compile_time_flags[i]].name);
                        exit(1);
                }
+       }
 }