devtools: fix symbol check for dash
authorThomas Monjalon <thomas@monjalon.net>
Sun, 5 Aug 2018 09:38:47 +0000 (11:38 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 9 Aug 2018 16:12:22 +0000 (18:12 +0200)
The script check-symbol-change.sh was not running when
/bin/sh redirects to dash.

Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhorman@tuxdriver.com
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
devtools/check-symbol-change.sh

index 40b7207..daaf45e 100755 (executable)
@@ -4,8 +4,8 @@
 
 build_map_changes()
 {
-       local fname=$1
-       local mapdb=$2
+       local fname="$1"
+       local mapdb="$2"
 
        cat "$fname" | awk '
                # Initialize our variables
@@ -80,7 +80,7 @@ build_map_changes()
 
 check_for_rule_violations()
 {
-       local mapdb=$1
+       local mapdb="$1"
        local mname
        local symname
        local secname
@@ -89,10 +89,10 @@ check_for_rule_violations()
 
        while read mname symname secname ar
        do
-               if [ "$ar" == "add" ]
+               if [ "$ar" = "add" ]
                then
 
-                       if [ "$secname" == "unknown" ]
+                       if [ "$secname" = "unknown" ]
                        then
                                # Just inform the user of this occurrence, but
                                # don't flag it as an error