ipc: handle unsupported IPC in async request
authorAnatoly Burakov <anatoly.burakov@intel.com>
Thu, 25 Apr 2019 12:45:19 +0000 (13:45 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 5 Jun 2019 09:28:10 +0000 (11:28 +0200)
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call to explicitly handle unsupported IPC cases.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/eal_common_proc.c
lib/librte_eal/common/include/rte_eal.h

index 7195d57..cfd571e 100644 (file)
@@ -1066,7 +1066,8 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
 
        if (internal_config.no_shconf) {
                RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n");
-               return 0;
+               rte_errno = ENOTSUP;
+               return -1;
        }
 
        if (gettimeofday(&now, NULL) < 0) {
index 9cd66fe..cf701e1 100644 (file)
@@ -361,6 +361,9 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
  * This function sends a request message to the peer process, and will not
  * block. Instead, reply will be received in a separate callback.
  *
+ * @note IPC may be unsupported in certain circumstances, so caller should check
+ *    for ENOTSUP error.
+ *
  * @param req
  *   The req argument contains the customized request message.
  *