test: check flow classifier creation
authorMin Hu (Connor) <humin29@huawei.com>
Thu, 22 Apr 2021 06:13:54 +0000 (14:13 +0800)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 12 May 2021 19:46:05 +0000 (21:46 +0200)
'cls->cls' will be NULL if flow classifier create has failed,
then segmentation fault will occur if the variable is used.

This patch fixed it.

Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
app/test/test_flow_classify.c

index ef0b6fd..951606f 100644 (file)
@@ -828,6 +828,12 @@ test_flow_classify(void)
        cls_params.name = "flow_classifier";
        cls_params.socket_id = 0;
        cls->cls = rte_flow_classifier_create(&cls_params);
+       if (cls->cls == NULL) {
+               printf("Line %i: flow classifier create has failed!\n",
+                      __LINE__);
+               rte_free(cls);
+               return TEST_FAILED;
+       }
 
        /* initialise ACL table params */
        table_acl_params.n_rule_fields = RTE_DIM(ipv4_defs);