crypto/dpaa_sec: remove ICV memset on decryption side
authorAlok Makhariya <alok.makhariya@nxp.com>
Thu, 12 Oct 2017 13:07:23 +0000 (18:37 +0530)
committerPablo de Lara <pablo.de.lara.guarch@intel.com>
Wed, 25 Oct 2017 16:09:26 +0000 (18:09 +0200)
Since the packet lengths are modified, it is not required to
explicitly reset the ICV.

Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")

Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com>
drivers/crypto/dpaa_sec/dpaa_sec.c

index 7b9a683..b54803c 100644 (file)
@@ -598,7 +598,6 @@ build_auth_only(struct rte_crypto_op *op, dpaa_sec_session *ses)
                /* hash result or digest, save digest first */
                rte_memcpy(old_digest, sym->auth.digest.data,
                           ses->digest_length);
-               memset(sym->auth.digest.data, 0, ses->digest_length);
                qm_sg_entry_set64(sg, start_addr + sym->auth.data.offset);
                sg->length = sym->auth.data.length;
                cpu_to_hw_sg(sg);
@@ -738,7 +737,6 @@ build_cipher_auth_gcm(struct rte_crypto_op *op, dpaa_sec_session *ses)
 
                memcpy(ctx->digest, sym->aead.digest.data,
                       ses->digest_length);
-               memset(sym->aead.digest.data, 0, ses->digest_length);
                sg++;
 
                qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest));
@@ -832,7 +830,6 @@ build_cipher_auth(struct rte_crypto_op *op, dpaa_sec_session *ses)
 
                memcpy(ctx->digest, sym->auth.digest.data,
                       ses->digest_length);
-               memset(sym->auth.digest.data, 0, ses->digest_length);
                sg++;
 
                qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest));