net/bnxt: fix single PF per port check

The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
extra check needed for VF along with BNXT_SINGLE_PF(bp).

Also make error messages more explicit.

Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
Fixes: f86febfb46da ("net/bnxt: support VF")
Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 748b766..9c3e0f9 100644 (file)
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
        if (rc)
                return rc;
 
-       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
-               PMD_DRV_LOG(ERR, "Flow Control Settings cannot be modified\n");
+       if (!BNXT_SINGLE_PF(bp)) {
+               PMD_DRV_LOG(ERR,
+                           "Flow Control Settings cannot be modified on VF or on shared PF\n");
                return -ENOTSUP;
        }
 
@@ -2994,9 +2995,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev, uint16_t pvid, int on)
        if (rc)
                return rc;
 
-       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
-               PMD_DRV_LOG(ERR,
-                       "PVID cannot be modified for this function\n");
+       if (!BNXT_SINGLE_PF(bp)) {
+               PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on shared PF\n");
                return -ENOTSUP;
        }
        bp->vlan = on ? pvid : 0;