eal: fix shared lib mode detection
authorTimothy Redaelli <tredaelli@redhat.com>
Tue, 24 Nov 2020 15:14:14 +0000 (16:14 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 25 Nov 2020 22:54:12 +0000 (23:54 +0100)
Commit 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
introduced a check that enabled shared lib mode when librte_eal.so can
be loaded, but it can't work, at least, on Fedora/CentOS/RHEL since .so
symlinks are not installed when you install dpdk package, but only when
you install dpdk-devel package.

This commit uses librte_eal.so.ABI_VERSION to check for shared lib,
since it exists on any linux distributions.

See Fedora Packaging Guidelines for more information:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
Cc: stable@dpdk.org
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Tested-by: Ali Alnubani <alialnu@nvidia.com>
lib/librte_eal/common/eal_common_options.c
lib/librte_eal/common/meson.build

index fc6f0ce..ac3884a 100644 (file)
@@ -503,7 +503,7 @@ eal_plugins_init(void)
         * (Using dlopen with NOLOAD flag on EAL, will return NULL if the EAL
         * shared library is not already loaded i.e. it's statically linked.)
         */
-       if (dlopen("librte_eal.so", RTLD_LAZY | RTLD_NOLOAD) != NULL &&
+       if (dlopen("librte_eal.so."ABI_VERSION, RTLD_LAZY | RTLD_NOLOAD) != NULL &&
                        *default_solib_dir != '\0' &&
                        stat(default_solib_dir, &sb) == 0 &&
                        S_ISDIR(sb.st_mode))
index 9f32262..39abf7a 100644 (file)
@@ -3,6 +3,8 @@
 
 includes += include_directories('.')
 
+cflags += [ '-DABI_VERSION="@0@"'.format(abi_version) ]
+
 if is_windows
        sources += files(
                'eal_common_bus.c',