net/octeontx2: fix link information for loopback port
authorAshish Gupta <ashishg@marvell.com>
Thu, 6 Feb 2020 12:30:58 +0000 (18:00 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 18 Mar 2020 09:21:41 +0000 (10:21 +0100)
Loopback devices are exposed as ethdev device in octeontx2.
This patch fixes the link information for loopback ports.

Fixes: 38f566280abb ("net/octeontx2: add link stats operations")
Cc: stable@dpdk.org
Signed-off-by: Ashish Gupta <ashishg@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
drivers/net/octeontx2/otx2_link.c

index f5679b0..4128f56 100644 (file)
@@ -82,32 +82,57 @@ otx2_eth_dev_link_status_update(struct otx2_dev *dev,
        _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL);
 }
 
+static int
+lbk_link_update(struct rte_eth_link *link)
+{
+       link->link_status = ETH_LINK_UP;
+       link->link_speed = ETH_SPEED_NUM_100G;
+       link->link_autoneg = ETH_LINK_FIXED;
+       link->link_duplex = ETH_LINK_FULL_DUPLEX;
+       return 0;
+}
+
+static int
+cgx_link_update(struct otx2_eth_dev *dev, struct rte_eth_link *link)
+{
+       struct otx2_mbox *mbox = dev->mbox;
+       struct cgx_link_info_msg *rsp;
+       int rc;
+       otx2_mbox_alloc_msg_cgx_get_linkinfo(mbox);
+       rc = otx2_mbox_process_msg(mbox, (void *)&rsp);
+       if (rc)
+               return rc;
+
+       link->link_status = rsp->link_info.link_up;
+       link->link_speed = rsp->link_info.speed;
+       link->link_autoneg = ETH_LINK_AUTONEG;
+
+       if (rsp->link_info.full_duplex)
+               link->link_duplex = rsp->link_info.full_duplex;
+       return 0;
+}
+
 int
 otx2_nix_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
 {
        struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
-       struct otx2_mbox *mbox = dev->mbox;
-       struct cgx_link_info_msg *rsp;
        struct rte_eth_link link;
        int rc;
 
        RTE_SET_USED(wait_to_complete);
+       memset(&link, 0, sizeof(struct rte_eth_link));
 
-       if (otx2_dev_is_lbk(dev) || otx2_dev_is_sdp(dev))
+       if (otx2_dev_is_sdp(dev))
                return 0;
 
-       otx2_mbox_alloc_msg_cgx_get_linkinfo(mbox);
-       rc = otx2_mbox_process_msg(mbox, (void *)&rsp);
+       if (otx2_dev_is_lbk(dev))
+               rc = lbk_link_update(&link);
+       else
+               rc = cgx_link_update(dev, &link);
+
        if (rc)
                return rc;
 
-       link.link_status = rsp->link_info.link_up;
-       link.link_speed = rsp->link_info.speed;
-       link.link_autoneg = ETH_LINK_AUTONEG;
-
-       if (rsp->link_info.full_duplex)
-               link.link_duplex = rsp->link_info.full_duplex;
-
        return rte_eth_linkstatus_set(eth_dev, &link);
 }