net/bnxt: fix SRAM resource free block list
authorKishore Padmanabha <kishore.padmanabha@broadcom.com>
Tue, 16 Nov 2021 13:04:35 +0000 (18:34 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Tue, 16 Nov 2021 23:11:01 +0000 (00:11 +0100)
The SRAM resource free did not reset the next block to be used
when the block is not empty. This caused the flows not be created
when max flows limit is reached and you delete one flow and try to
add a new flow. The fix calls the update of the next free block
even when block is not empty.

Fixes: 37ff91c158a3 ("net/bnxt: add SRAM manager model")

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Mike Baucom <michael.baucom@broadcom.com>
Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
drivers/net/bnxt/tf_core/tf_sram_mgr.c

index a248ef2..acb3372 100644 (file)
@@ -794,17 +794,19 @@ tf_sram_mgr_free(void *sram_handle,
                        TFP_DRV_LOG(ERR, "Free block_id(%d) failed error(%s)\n",
                                    block_id, strerror(-rc));
                }
-               /* Free local entry regardless
-                */
+               /* Free local entry regardless */
                tf_sram_free_block(slice_list, block);
 
-               /* Find the next non-full block in the list
-                */
-               tf_sram_find_first_not_full_block(slice_list,
-                                            parms->slice_size,
-                                            &slice_list->first_not_full_block);
+               /* Clear the not full block to set it again */
+               slice_list->first_not_full_block = NULL;
        }
+       if (slice_list->first_not_full_block)
+               return rc;
 
+       /* set the non full block so it can be used in next alloc */
+       tf_sram_find_first_not_full_block(slice_list,
+                                         parms->slice_size,
+                                         &slice_list->first_not_full_block);
        return rc;
 }