net/bnxt: support flow API create
authorKishore Padmanabha <kishore.padmanabha@broadcom.com>
Wed, 15 Apr 2020 08:19:04 +0000 (13:49 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 21 Apr 2020 11:57:08 +0000 (13:57 +0200)
This patch does the following
1. Validates rte_flow_create arguments
2. Parses rte_flow_item types
3. Parses rte_flow_action types
4. Calls ulp_matcher_pattern_match to see if the flow is supported
5. If there is a match, calls ulp_mapper_flow_create to program
   key & action tables

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
drivers/net/bnxt/Makefile
drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c [new file with mode: 0644]

index 5e2d751..5ed33cc 100644 (file)
@@ -65,6 +65,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_utils.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_mapper.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_matcher.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/ulp_rte_parser.c
+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_ulp/bnxt_ulp_flow.c
 
 #
 # Export include files
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c
new file mode 100644 (file)
index 0000000..6402dd3
--- /dev/null
@@ -0,0 +1,177 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2014-2020 Broadcom
+ * All rights reserved.
+ */
+
+#include "bnxt.h"
+#include "bnxt_tf_common.h"
+#include "ulp_rte_parser.h"
+#include "ulp_matcher.h"
+#include "ulp_flow_db.h"
+#include "ulp_mapper.h"
+#include <rte_malloc.h>
+
+static int32_t
+bnxt_ulp_flow_validate_args(const struct rte_flow_attr *attr,
+                           const struct rte_flow_item pattern[],
+                           const struct rte_flow_action actions[],
+                           struct rte_flow_error *error)
+{
+       /* Perform the validation of the arguments for null */
+       if (!error)
+               return BNXT_TF_RC_ERROR;
+
+       if (!pattern) {
+               rte_flow_error_set(error,
+                                  EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_ITEM_NUM,
+                                  NULL,
+                                  "NULL pattern.");
+               return BNXT_TF_RC_ERROR;
+       }
+
+       if (!actions) {
+               rte_flow_error_set(error,
+                                  EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_ACTION_NUM,
+                                  NULL,
+                                  "NULL action.");
+               return BNXT_TF_RC_ERROR;
+       }
+
+       if (!attr) {
+               rte_flow_error_set(error,
+                                  EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_ATTR,
+                                  NULL,
+                                  "NULL attribute.");
+               return BNXT_TF_RC_ERROR;
+       }
+
+       if (attr->egress && attr->ingress) {
+               rte_flow_error_set(error,
+                                  EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_ATTR,
+                                  attr,
+                                  "EGRESS AND INGRESS UNSUPPORTED");
+               return BNXT_TF_RC_ERROR;
+       }
+       return BNXT_TF_RC_SUCCESS;
+}
+
+/* Function to create the rte flow. */
+static struct rte_flow *
+bnxt_ulp_flow_create(struct rte_eth_dev                        *dev,
+                    const struct rte_flow_attr         *attr,
+                    const struct rte_flow_item         pattern[],
+                    const struct rte_flow_action       actions[],
+                    struct rte_flow_error              *error)
+{
+       struct ulp_rte_hdr_bitmap hdr_bitmap;
+       struct ulp_rte_hdr_field hdr_field[BNXT_ULP_PROTO_HDR_MAX];
+       struct ulp_rte_act_bitmap act_bitmap;
+       struct ulp_rte_act_prop act_prop;
+       enum ulp_direction_type dir = ULP_DIR_INGRESS;
+       uint32_t class_id, act_tmpl;
+       uint32_t app_priority;
+       int ret;
+       struct bnxt_ulp_context *ulp_ctx = NULL;
+       uint32_t vnic;
+       uint8_t svif;
+       struct rte_flow *flow_id;
+       uint32_t fid;
+
+       if (bnxt_ulp_flow_validate_args(attr,
+                                       pattern, actions,
+                                       error) == BNXT_TF_RC_ERROR) {
+               BNXT_TF_DBG(ERR, "Invalid arguments being passed\n");
+               return NULL;
+       }
+
+       ulp_ctx = bnxt_ulp_eth_dev_ptr2_cntxt_get(dev);
+       if (!ulp_ctx) {
+               BNXT_TF_DBG(ERR, "ULP context is not initialized\n");
+               return NULL;
+       }
+
+       /* clear the header bitmap and field structure */
+       memset(&hdr_bitmap, 0, sizeof(struct ulp_rte_hdr_bitmap));
+       memset(hdr_field, 0, sizeof(hdr_field));
+       memset(&act_bitmap, 0, sizeof(act_bitmap));
+       memset(&act_prop, 0, sizeof(act_prop));
+
+       svif = bnxt_get_svif(dev->data->port_id, false);
+       BNXT_TF_DBG(ERR, "SVIF for port[%d][port]=0x%08x\n",
+                   dev->data->port_id, svif);
+
+       hdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].size = sizeof(svif);
+       hdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].spec[0] = svif;
+       hdr_field[BNXT_ULP_HDR_FIELD_SVIF_INDEX].mask[0] = -1;
+       ULP_BITMAP_SET(hdr_bitmap.bits, BNXT_ULP_HDR_BIT_SVIF);
+
+       /*
+        * VNIC is being pushed as 32bit and the pop will take care of
+        * proper size
+        */
+       vnic = (uint32_t)bnxt_get_vnic_id(dev->data->port_id);
+       vnic = htonl(vnic);
+       rte_memcpy(&act_prop.act_details[BNXT_ULP_ACT_PROP_IDX_VNIC],
+                  &vnic, BNXT_ULP_ACT_PROP_SZ_VNIC);
+
+       /* Parse the rte flow pattern */
+       ret = bnxt_ulp_rte_parser_hdr_parse(pattern,
+                                           &hdr_bitmap,
+                                           hdr_field);
+       if (ret != BNXT_TF_RC_SUCCESS)
+               goto parse_error;
+
+       /* Parse the rte flow action */
+       ret = bnxt_ulp_rte_parser_act_parse(actions,
+                                           &act_bitmap,
+                                           &act_prop);
+       if (ret != BNXT_TF_RC_SUCCESS)
+               goto parse_error;
+
+       if (attr->egress)
+               dir = ULP_DIR_EGRESS;
+
+       ret = ulp_matcher_pattern_match(dir, &hdr_bitmap, hdr_field,
+                                       &act_bitmap, &class_id);
+
+       if (ret != BNXT_TF_RC_SUCCESS)
+               goto parse_error;
+
+       ret = ulp_matcher_action_match(dir, &act_bitmap, &act_tmpl);
+       if (ret != BNXT_TF_RC_SUCCESS)
+               goto parse_error;
+
+       app_priority = attr->priority;
+       /* call the ulp mapper to create the flow in the hardware */
+       ret = ulp_mapper_flow_create(ulp_ctx,
+                                    app_priority,
+                                    &hdr_bitmap,
+                                    hdr_field,
+                                    &act_bitmap,
+                                    &act_prop,
+                                    class_id,
+                                    act_tmpl,
+                                    &fid);
+       if (!ret) {
+               flow_id = (struct rte_flow *)((uintptr_t)fid);
+               return flow_id;
+       }
+
+parse_error:
+       rte_flow_error_set(error, ret, RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+                          "Failed to create flow.");
+       return NULL;
+}
+
+const struct rte_flow_ops bnxt_ulp_rte_flow_ops = {
+       .validate = NULL,
+       .create = bnxt_ulp_flow_create,
+       .destroy = NULL,
+       .flush = NULL,
+       .query = NULL,
+       .isolate = NULL
+};