common/qat: fix failure to create PMD
authorFiona Trahe <fiona.trahe@intel.com>
Thu, 11 Oct 2018 17:14:05 +0000 (18:14 +0100)
committerAkhil Goyal <akhil.goyal@nxp.com>
Wed, 17 Oct 2018 10:23:40 +0000 (12:23 +0200)
If QAT crypto pmd failed to be created due to reaching MAX
cryptodevs it prevented QAT comp PMD being created. And vice versa.
Change to warning in these cases and allow the other PMD to be created.

Fixes: c0c90bc4cade ("compress/qat: add create and destroy functions")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Tomasz Cel <tomaszx.cel@intel.com>
drivers/common/qat/qat_device.c

index b158fb9..8d4df92 100644 (file)
@@ -196,6 +196,7 @@ static int qat_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
                struct rte_pci_device *pci_dev)
 {
        int ret = 0;
+       int num_pmds_created = 0;
        struct qat_pci_device *qat_pci_dev;
 
        QAT_LOG(DEBUG, "Found QAT device at %02x:%02x.%x",
@@ -208,23 +209,33 @@ static int qat_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
                return -ENODEV;
 
        ret = qat_sym_dev_create(qat_pci_dev);
-       if (ret != 0)
-               goto error_out;
+       if (ret == 0)
+               num_pmds_created++;
+       else
+               QAT_LOG(WARNING,
+                               "Failed to create QAT SYM PMD on device %s",
+                               qat_pci_dev->name);
 
        ret = qat_comp_dev_create(qat_pci_dev);
-       if (ret != 0)
-               goto error_out;
+       if (ret == 0)
+               num_pmds_created++;
+       else
+               QAT_LOG(WARNING,
+                               "Failed to create QAT COMP PMD on device %s",
+                               qat_pci_dev->name);
 
        ret = qat_asym_dev_create(qat_pci_dev);
-       if (ret != 0)
-               goto error_out;
+       if (ret == 0)
+               num_pmds_created++;
+       else
+               QAT_LOG(WARNING,
+                               "Failed to create QAT ASYM PMD on device %s",
+                               qat_pci_dev->name);
 
-       return 0;
-
-error_out:
-       qat_pci_dev_destroy(qat_pci_dev, pci_dev);
-       return ret;
+       if (num_pmds_created == 0)
+               qat_pci_dev_destroy(qat_pci_dev, pci_dev);
 
+       return 0;
 }
 
 static int qat_pci_remove(struct rte_pci_device *pci_dev)