net/enic: fix flow API memory leak
authorJohn Daley <johndale@cisco.com>
Fri, 28 Sep 2018 03:08:36 +0000 (20:08 -0700)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 11 Oct 2018 16:53:48 +0000 (18:53 +0200)
rte_flow structures were not being freed when destroyed or flushed.

Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
Cc: stable@dpdk.org
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Signed-off-by: John Daley <johndale@cisco.com>
drivers/net/enic/enic_flow.c

index 0cf04ae..9b612f1 100644 (file)
@@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
        enic_flow_del_filter(enic, flow->enic_filter_id, error);
        LIST_REMOVE(flow, next);
        rte_spinlock_unlock(&enic->flows_lock);
+       rte_free(flow);
        return 0;
 }
 
@@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
                flow = LIST_FIRST(&enic->flows);
                enic_flow_del_filter(enic, flow->enic_filter_id, error);
                LIST_REMOVE(flow, next);
+               rte_free(flow);
        }
        rte_spinlock_unlock(&enic->flows_lock);
        return 0;