scripts: check first word of commit messages
authorBruce Richardson <bruce.richardson@intel.com>
Tue, 28 Jun 2016 11:27:12 +0000 (12:27 +0100)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Wed, 29 Jun 2016 11:33:01 +0000 (13:33 +0200)
Avoid messages starting with "It" without describing what
it is talking about.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
scripts/check-git-log.sh

index 4253d14..9a0d068 100755 (executable)
@@ -114,6 +114,12 @@ bad=$(echo "$headlines" | awk 'length>60 {print}' | sed 's,^,\t,')
 bad=$(echo "$bodylines" | grep -v '^Fixes:' | awk 'length>75 {print}' | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Line too long:\n$bad\n"
 
+# check starting commit message with "It"
+bad=$(echo "$bodylines" | head -n1 | grep -E --color=always \
+       -ie '^It ' \
+       | sed 's,^,\t,')
+[ -z "$bad" ] || printf "Wrong beginning of commit message:\n$bad\n"
+
 # check tags spelling
 bad=$(echo "$tags" |
        grep -v '^\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by: [^,]* <.*@.*>$' |