app/testpmd: fix allocation check in TM config
authorJasvinder Singh <jasvinder.singh@intel.com>
Mon, 22 Jan 2018 15:45:53 +0000 (15:45 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 31 Jan 2018 22:34:47 +0000 (23:34 +0100)
Calloc() function might returns NULL due to insufficient space. Therefore,
check for handling memory allocation failure is added.

Coverity issue: 257030
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
Cc: stable@dpdk.org
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
app/test-pmd/tm.c

index b76335c..7231552 100644 (file)
@@ -575,6 +575,10 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
                                tc_parent_node_id = h->pipe_node_id[i][j];
                                tnp.shared_shaper_id =
                                        (uint32_t *)calloc(1, sizeof(uint32_t));
+                               if (tnp.shared_shaper_id == NULL) {
+                                       printf("Shared shaper mem alloc err\n");
+                                       return -1;
+                               }
                                tnp.shared_shaper_id[0] = k;
                                pos = j + (i * PIPE_NODES_PER_SUBPORT);
                                h->tc_node_id[pos][k] =