net/ice/base: clarify comments on checking PFC mode
authorQi Zhang <qi.z.zhang@intel.com>
Tue, 10 Aug 2021 02:51:22 +0000 (10:51 +0800)
committerQi Zhang <qi.z.zhang@intel.com>
Wed, 11 Aug 2021 02:24:13 +0000 (04:24 +0200)
Rework the comment around checking PFC mode to make it clear why we are
checking the mode after sending the command.

Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Junfeng Guo <junfeng.guo@intel.com>
drivers/net/ice/base/ice_dcb.c

index 9c9675f..cb6c5ba 100644 (file)
@@ -764,11 +764,10 @@ ice_aq_set_pfc_mode(struct ice_hw *hw, u8 pfc_mode, struct ice_sq_cd *cd)
        if (status)
                return status;
 
-       /* The spec isn't clear about whether the FW will return an error code
-        * if the PFC mode requested by the driver was not set. The spec just
-        * says that the FW will write the PFC mode set back into cmd->pfc_mode,
-        * so after the AQ has been executed, check if cmd->pfc_mode is what was
-        * requested.
+       /* FW will write the PFC mode set back into cmd->pfc_mode, but if DCB is
+        * disabled, FW will write back 0 to cmd->pfc_mode. After the AQ has
+        * been executed, check if cmd->pfc_mode is what was requested. If not,
+        * return an error.
         */
        if (cmd->pfc_mode != pfc_mode)
                return ICE_ERR_NOT_SUPPORTED;