devtools: add explicit warnings for forbidden tokens
authorArnon Warshavsky <arnon@qwilt.com>
Fri, 2 Nov 2018 10:52:21 +0000 (12:52 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Sun, 4 Nov 2018 20:54:04 +0000 (21:54 +0100)
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages

Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
devtools/check-forbidden-tokens.awk
devtools/checkpatches.sh

index fd77cdd..8c89de3 100755 (executable)
@@ -63,12 +63,7 @@ BEGIN {
 END {
        if (count > 0) {
                print "Warning in " substr(last_file,6) ":"
-               print "are you sure you want to add the following:"
-               for (key in expressions) {
-                       if (expressions[key] > 0) {
-                               print key
-                       }
-               }
+               print MESSAGE
                exit RET_ON_FAIL
        }
 }
index fb9e9f7..ee8debe 100755 (executable)
@@ -49,6 +49,7 @@ check_forbidden_additions() { # <patch>
        awk -v FOLDERS="lib drivers" \
                -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
                -v RET_ON_FAIL=1 \
+               -v MESSAGE='Using rte_panic/rte_exit' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
                "$1"
        # svg figures must be included with wildcard extension
@@ -56,6 +57,7 @@ check_forbidden_additions() { # <patch>
        awk -v FOLDERS='doc' \
                -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
                -v RET_ON_FAIL=1 \
+               -v MESSAGE='Using explicit .svg extension instead of .*' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
                "$1"
 }