app/flow-perf: fix memory leak from RSS action
authorWisam Jaddo <wisamm@mellanox.com>
Sun, 30 Aug 2020 11:15:37 +0000 (11:15 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 18 Sep 2020 16:55:10 +0000 (18:55 +0200)
Currently, each call for add_rss_action will allocate
extra memory for rss_data, which will reflect bad results
on memory consumption for all flows, and will leads into
memory leak.

In this fix, it will check if it's allocated before
reallocating it.

Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation")
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
Acked-by: Alexander Kozyrev <akozyrev@nvidia.com>
app/test-flow-perf/actions_gen.c

index 9fe11ab..99e47bf 100644 (file)
@@ -86,8 +86,9 @@ add_rss(struct rte_flow_action *actions,
 
        uint16_t queue;
 
-       rss_data = rte_malloc("rss_data",
-               sizeof(struct action_rss_data), 0);
+       if (rss_data == NULL)
+               rss_data = rte_malloc("rss_data",
+                       sizeof(struct action_rss_data), 0);
 
        if (rss_data == NULL)
                rte_exit(EXIT_FAILURE, "No Memory available!");