net/null: remove redundant check
authorFerruh Yigit <ferruh.yigit@intel.com>
Mon, 2 Mar 2020 17:36:42 +0000 (17:36 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 21 Apr 2020 11:57:07 +0000 (13:57 +0200)
There is no need to check if the argument exist or not,
`rte_kvargs_process` returns success if the argument is not provided at
all.

Fixes: c743e50c475f ("null: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/null/rte_eth_null.c

index 87a29b8..beedd5f 100644 (file)
@@ -610,23 +610,18 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)
                if (kvlist == NULL)
                        return -1;
 
-               if (rte_kvargs_count(kvlist, ETH_NULL_PACKET_SIZE_ARG) == 1) {
-
-                       ret = rte_kvargs_process(kvlist,
-                                       ETH_NULL_PACKET_SIZE_ARG,
-                                       &get_packet_size_arg, &packet_size);
-                       if (ret < 0)
-                               goto free_kvlist;
-               }
-
-               if (rte_kvargs_count(kvlist, ETH_NULL_PACKET_COPY_ARG) == 1) {
-
-                       ret = rte_kvargs_process(kvlist,
-                                       ETH_NULL_PACKET_COPY_ARG,
-                                       &get_packet_copy_arg, &packet_copy);
-                       if (ret < 0)
-                               goto free_kvlist;
-               }
+               ret = rte_kvargs_process(kvlist,
+                               ETH_NULL_PACKET_SIZE_ARG,
+                               &get_packet_size_arg, &packet_size);
+               if (ret < 0)
+                       goto free_kvlist;
+
+
+               ret = rte_kvargs_process(kvlist,
+                               ETH_NULL_PACKET_COPY_ARG,
+                               &get_packet_copy_arg, &packet_copy);
+               if (ret < 0)
+                       goto free_kvlist;
        }
 
        PMD_LOG(INFO, "Configure pmd_null: packet size is %d, "