app/testpmd: fix pointer reference in macswap
authorYongseok Koh <yskoh@mellanox.com>
Mon, 14 Jan 2019 10:00:21 +0000 (02:00 -0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 14 Jan 2019 16:44:29 +0000 (17:44 +0100)
The pointer is misused and could set wrong MAC address. As a result, some
of packets can be dropped in receiver side due to MAC address mismatch.
This can be shown as performance degradation.

Bugzilla ID: 188
Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86")

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
app/test-pmd/macswap_sse.h

index 7d268bf..662fe79 100644 (file)
@@ -76,7 +76,7 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb,
                eth_hdr[0] = rte_pktmbuf_mtod(mb[0], struct ether_hdr *);
 
                /* Swap dest and src mac addresses. */
-               addr0 = _mm_loadu_si128((__m128i *)eth_hdr);
+               addr0 = _mm_loadu_si128((__m128i *)eth_hdr[0]);
                addr0 = _mm_shuffle_epi8(addr0, shfl_msk);
                _mm_storeu_si128((__m128i *)eth_hdr[0], addr0);