mempool/dpaa: fix leak in pool creation failure

When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing
'bp' thus leading resource leak. This patch avoids this.

Coverity issue: 337679

Signed-off-by: Li Qiang <liq3ea@163.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
index 0030817..54cdf37 100644 (file)
--- a/drivers/mempool/dpaa/dpaa_mempool.c
+++ b/drivers/mempool/dpaa/dpaa_mempool.c
@@ -78,8 +78,10 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
                rte_dpaa_bpid_info = (struct dpaa_bp_info *)rte_zmalloc(NULL,
                                sizeof(struct dpaa_bp_info) * DPAA_MAX_BPOOLS,
                                RTE_CACHE_LINE_SIZE);
-               if (rte_dpaa_bpid_info == NULL)
+               if (rte_dpaa_bpid_info == NULL) {
+                       bman_free_pool(bp);
                        return -ENOMEM;
+               }
        }
 
        rte_dpaa_bpid_info[bpid].mp = mp;