net/fm10k: fix descriptor filling in vector Tx
authorXiao Wang <xiao.w.wang@intel.com>
Wed, 3 Jul 2019 02:53:32 +0000 (10:53 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 8 Jul 2019 19:26:52 +0000 (21:26 +0200)
The shift left operation "pkt->vlan_tci << 16" gets vlan_tci extended
to signed type and may cause invalid descriptor. Also the same issue for
the "data_len" field. This patch fixes it by casting them to uint64_t.

Fixes: 21f13c541eb0 ("fm10k: add vector Tx")
Cc: stable@dpdk.org
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/fm10k/fm10k_rxtx_vec.c

index 96b46a2..788e248 100644 (file)
@@ -711,7 +711,7 @@ vtx1(volatile struct fm10k_tx_desc *txdp,
                struct rte_mbuf *pkt, uint64_t flags)
 {
        __m128i descriptor = _mm_set_epi64x(flags << 56 |
-                       pkt->vlan_tci << 16 | pkt->data_len,
+                       (uint64_t)pkt->vlan_tci << 16 | (uint64_t)pkt->data_len,
                        MBUF_DMA_ADDR(pkt));
        _mm_store_si128((__m128i *)txdp, descriptor);
 }