crypto/dpaa2_sec: improve debug logging
authorHemant Agrawal <hemant.agrawal@nxp.com>
Mon, 30 Sep 2019 14:41:04 +0000 (20:11 +0530)
committerAkhil Goyal <akhil.goyal@nxp.com>
Wed, 9 Oct 2019 09:50:12 +0000 (11:50 +0200)
unnecessary debug logs in data path are removed
and hardware debug logs are compiled off.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c

index b811f2f..2ab34a0 100644 (file)
@@ -305,8 +305,6 @@ build_authenc_gcm_sg_fd(dpaa2_sec_session *sess,
        uint8_t *IV_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
                        sess->iv.offset);
 
-       PMD_INIT_FUNC_TRACE();
-
        if (sym_op->m_dst)
                mbuf = sym_op->m_dst;
        else
@@ -453,8 +451,6 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess,
        uint8_t *IV_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
                        sess->iv.offset);
 
-       PMD_INIT_FUNC_TRACE();
-
        if (sym_op->m_dst)
                dst = sym_op->m_dst;
        else
@@ -602,8 +598,6 @@ build_authenc_sg_fd(dpaa2_sec_session *sess,
        uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
                        sess->iv.offset);
 
-       PMD_INIT_FUNC_TRACE();
-
        if (sym_op->m_dst)
                mbuf = sym_op->m_dst;
        else
@@ -748,8 +742,6 @@ build_authenc_fd(dpaa2_sec_session *sess,
                        sess->iv.offset);
        struct rte_mbuf *dst;
 
-       PMD_INIT_FUNC_TRACE();
-
        if (sym_op->m_dst)
                dst = sym_op->m_dst;
        else
@@ -887,8 +879,6 @@ static inline int build_auth_sg_fd(
        uint8_t *old_digest;
        struct rte_mbuf *mbuf;
 
-       PMD_INIT_FUNC_TRACE();
-
        data_len = sym_op->auth.data.length;
        data_offset = sym_op->auth.data.offset;
 
@@ -1006,8 +996,6 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
        uint8_t *old_digest;
        int retval;
 
-       PMD_INIT_FUNC_TRACE();
-
        data_len = sym_op->auth.data.length;
        data_offset = sym_op->auth.data.offset;
 
@@ -1123,8 +1111,6 @@ build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
        uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
                        sess->iv.offset);
 
-       PMD_INIT_FUNC_TRACE();
-
        data_len = sym_op->cipher.data.length;
        data_offset = sym_op->cipher.data.offset;
 
@@ -1258,8 +1244,6 @@ build_cipher_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
                        sess->iv.offset);
        struct rte_mbuf *dst;
 
-       PMD_INIT_FUNC_TRACE();
-
        data_len = sym_op->cipher.data.length;
        data_offset = sym_op->cipher.data.offset;
 
@@ -1371,8 +1355,6 @@ build_sec_fd(struct rte_crypto_op *op,
        int ret = -1;
        dpaa2_sec_session *sess;
 
-       PMD_INIT_FUNC_TRACE();
-
        if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION)
                sess = (dpaa2_sec_session *)get_sym_session_private_data(
                                op->sym->session, cryptodev_driver_id);
@@ -1821,7 +1803,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
 {
        struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private;
        struct alginfo cipherdata;
-       int bufsize, i;
+       int bufsize;
        struct ctxt_priv *priv;
        struct sec_flow_context *flc;
 
@@ -1937,9 +1919,11 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
        flc->word1_sdl = (uint8_t)bufsize;
        session->ctxt = priv;
 
+#ifdef CAAM_DESC_DEBUG
+       int i;
        for (i = 0; i < bufsize; i++)
                DPAA2_SEC_DEBUG("DESC[%d]:0x%x", i, priv->flc_desc[0].desc[i]);
-
+#endif
        return 0;
 
 error_out:
@@ -1955,7 +1939,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
 {
        struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private;
        struct alginfo authdata;
-       int bufsize, i;
+       int bufsize;
        struct ctxt_priv *priv;
        struct sec_flow_context *flc;
 
@@ -2099,10 +2083,12 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
 
        flc->word1_sdl = (uint8_t)bufsize;
        session->ctxt = priv;
+#ifdef CAAM_DESC_DEBUG
+       int i;
        for (i = 0; i < bufsize; i++)
                DPAA2_SEC_DEBUG("DESC[%d]:0x%x",
                                i, priv->flc_desc[DESC_INITFINAL].desc[i]);
-
+#endif
 
        return 0;
 
@@ -2120,7 +2106,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
        struct dpaa2_sec_aead_ctxt *ctxt = &session->ext_params.aead_ctxt;
        struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private;
        struct alginfo aeaddata;
-       int bufsize, i;
+       int bufsize;
        struct ctxt_priv *priv;
        struct sec_flow_context *flc;
        struct rte_crypto_aead_xform *aead_xform = &xform->aead;
@@ -2218,10 +2204,12 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
 
        flc->word1_sdl = (uint8_t)bufsize;
        session->ctxt = priv;
+#ifdef CAAM_DESC_DEBUG
+       int i;
        for (i = 0; i < bufsize; i++)
                DPAA2_SEC_DEBUG("DESC[%d]:0x%x\n",
                            i, priv->flc_desc[0].desc[i]);
-
+#endif
        return 0;
 
 error_out:
@@ -2239,7 +2227,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        struct dpaa2_sec_aead_ctxt *ctxt = &session->ext_params.aead_ctxt;
        struct dpaa2_sec_dev_private *dev_priv = dev->data->dev_private;
        struct alginfo authdata, cipherdata;
-       int bufsize, i;
+       int bufsize;
        struct ctxt_priv *priv;
        struct sec_flow_context *flc;
        struct rte_crypto_cipher_xform *cipher_xform;
@@ -2444,9 +2432,12 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
 
        flc->word1_sdl = (uint8_t)bufsize;
        session->ctxt = priv;
+#ifdef CAAM_DESC_DEBUG
+       int i;
        for (i = 0; i < bufsize; i++)
                DPAA2_SEC_DEBUG("DESC[%d]:0x%x",
                            i, priv->flc_desc[0].desc[i]);
+#endif
 
        return 0;