net/atlantic: fix arguments check
authorIgor Russkikh <igor.russkikh@aquantia.com>
Mon, 29 Apr 2019 08:20:27 +0000 (08:20 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 3 May 2019 16:45:23 +0000 (18:45 +0200)
Found by Coverity scan, two pointer args should be not zero checked

Coverity issue: 337929
Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface")

Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c

index 0d24aa9..5927d90 100644 (file)
@@ -671,7 +671,7 @@ static int aq_fw2x_send_macsec_request(struct aq_hw_s *self,
        int err = 0;
        u32 mpi_opts = 0;
 
-       if (!response || !response)
+       if (!req || !response)
                return 0;
 
        if ((self->caps_lo & BIT(CAPS_LO_MACSEC)) == 0)