vhost: fix return code of messages requiring replies
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Fri, 12 Oct 2018 12:40:30 +0000 (14:40 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 18 Oct 2018 08:24:39 +0000 (10:24 +0200)
VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE
and VHOST_USER_SET_LOG_BASE require replies, so their handlers
should return VH_RESULT_REPLY, not VH_RESULT_OK.

Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature")

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
lib/librte_vhost/vhost_user.c

index e8375ca..09a90a2 100644 (file)
@@ -1151,7 +1151,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev,
 
        msg->size = sizeof(msg->payload.state);
 
-       return VH_RESULT_OK;
+       return VH_RESULT_REPLY;
 }
 
 /*
@@ -1208,7 +1208,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
        msg->payload.u64 = protocol_features;
        msg->size = sizeof(msg->payload.u64);
 
-       return VH_RESULT_OK;
+       return VH_RESULT_REPLY;
 }
 
 static int
@@ -1288,7 +1288,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg)
 
        msg->size = sizeof(msg->payload.u64);
 
-       return VH_RESULT_OK;
+       return VH_RESULT_REPLY;
 }
 
 static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,