app/testpmd: fix MAC address in ARP reply
authorAdrien Mazarguil <adrien.mazarguil@6wind.com>
Fri, 22 May 2015 11:07:31 +0000 (13:07 +0200)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Fri, 29 May 2015 18:27:23 +0000 (20:27 +0200)
In the icmpecho forwarding mode, ARP replies from testpmd contain
invalid zero-filled MAC addresses. This is broken since the commit below.

Fixes: 31db4d38de72 ("net: change arp header struct declaration")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Ivan Boule <ivan.boule@6wind.com>
app/test-pmd/icmpecho.c

index 010c5a9..c5933f4 100644 (file)
@@ -400,7 +400,7 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)
                        arp_h->arp_op = rte_cpu_to_be_16(ARP_OP_REPLY);
                        ether_addr_copy(&arp_h->arp_data.arp_tha, &eth_addr);
                        ether_addr_copy(&arp_h->arp_data.arp_sha, &arp_h->arp_data.arp_tha);
-                       ether_addr_copy(&eth_addr, &arp_h->arp_data.arp_sha);
+                       ether_addr_copy(&eth_h->s_addr, &arp_h->arp_data.arp_sha);
 
                        /* Swap IP addresses in ARP payload */
                        ip_addr = arp_h->arp_data.arp_sip;