ethdev: force offloading API rules
authorFerruh Yigit <ferruh.yigit@intel.com>
Thu, 31 May 2018 12:44:30 +0000 (13:44 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 14 Jun 2018 17:27:50 +0000 (19:27 +0200)
The error path was disabled in previous release to let apps to be more
flexible.

But this release they are enabled, applications have to obey offload API
rules otherwise they will get errors from following APIs:
rte_eth_dev_configure
rte_eth_rx_queue_setup
rte_eth_tx_queue_setup

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
lib/librte_ethdev/rte_ethdev.c

index cd4bfd3..66e3116 100644 (file)
@@ -1171,7 +1171,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                                local_conf.rxmode.offloads,
                                dev_info.rx_offload_capa,
                                __func__);
-               /* Will return -EINVAL in the next release */
+               return -EINVAL;
        }
        if ((local_conf.txmode.offloads & dev_info.tx_offload_capa) !=
             local_conf.txmode.offloads) {
@@ -1182,7 +1182,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                                local_conf.txmode.offloads,
                                dev_info.tx_offload_capa,
                                __func__);
-               /* Will return -EINVAL in the next release */
+               return -EINVAL;
        }
 
        /* Check that device supports requested rss hash functions. */
@@ -1580,7 +1580,7 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
                                local_conf.offloads,
                                dev_info.rx_queue_offload_capa,
                                __func__);
-               /* Will return -EINVAL in the next release */
+               return -EINVAL;
        }
 
        ret = (*dev->dev_ops->rx_queue_setup)(dev, rx_queue_id, nb_rx_desc,
@@ -1745,7 +1745,7 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
                                local_conf.offloads,
                                dev_info.tx_queue_offload_capa,
                                __func__);
-               /* Will return -EINVAL in the next release */
+               return -EINVAL;
        }
 
        return eth_err(port_id, (*dev->dev_ops->tx_queue_setup)(dev,