net/bnx2x: add switch fall-through comments
authorBruce Richardson <bruce.richardson@intel.com>
Thu, 4 May 2017 15:38:15 +0000 (16:38 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 5 May 2017 16:36:42 +0000 (18:36 +0200)
Add in a comment for each switch fall-through indicating that it is
intentional. This will fix compiler warnings with GCC 7.

Fixes: b5bf7719221d ("bnx2x: driver support routines")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
drivers/net/bnx2x/ecore_sp.c
drivers/net/bnx2x/elink.c

index e6fecd8..22f2dc9 100644 (file)
@@ -2725,7 +2725,7 @@ static int ecore_mcast_validate_e2(__rte_unused struct bnx2x_softc *sc,
                /* DEL command deletes all currently configured MACs */
        case ECORE_MCAST_CMD_DEL:
                o->set_registry_size(o, 0);
-               /* Don't break */
+               /* fall-through */
 
                /* RESTORE command will restore the entire multicast configuration */
        case ECORE_MCAST_CMD_RESTORE:
index 5329396..9ffa7dc 100644 (file)
@@ -5898,6 +5898,7 @@ elink_status_t elink_set_led(struct elink_params *params,
                 */
                if (!vars->link_up)
                        break;
+               /* fall-through */
        case ELINK_LED_MODE_ON:
                if (((params->phy[ELINK_EXT_PHY1].type ==
                      PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BNX2X8727) ||
@@ -11534,11 +11535,13 @@ static void elink_phy_def_cfg(struct elink_params *params,
        switch (link_config & PORT_FEATURE_LINK_SPEED_MASK) {
        case PORT_FEATURE_LINK_SPEED_10M_HALF:
                phy->req_duplex = DUPLEX_HALF;
+               /* fall-through */
        case PORT_FEATURE_LINK_SPEED_10M_FULL:
                phy->req_line_speed = ELINK_SPEED_10;
                break;
        case PORT_FEATURE_LINK_SPEED_100M_HALF:
                phy->req_duplex = DUPLEX_HALF;
+               /* fall-through */
        case PORT_FEATURE_LINK_SPEED_100M_FULL:
                phy->req_line_speed = ELINK_SPEED_100;
                break;