Aaron Conole [Wed, 2 Aug 2017 18:02:13 +0000 (14:02 -0400)]
net/enic: fix crash when freeing 0 packet to mempool
Occasionally, the amount of packets to free from the work queue ends
perfectly on a boundary to have nb_free = 0 and pool = 0. This causes
a segfault as follows:
(gdb) bt
#0 rte_mempool_default_cache
#1 rte_mempool_put_bulk (n=0, obj_table=0x7f10deff2530, mp=0x0)
#2 enic_free_wq_bufs (wq=wq@entry=0x7efabffcd5b0,
completed_index=completed_index@entry=33)
#3 0x00007f11e9c86e17 in enic_cleanup_wq (enic=<optimized out>,
wq=wq@entry=0x7efabffcd5b0)
at /usr/src/debug/openvswitch-2.6.1/dpdk-16.11/drivers/net/enic/enic_rxtx.c:442
#4 0x00007f11e9c86e5f in enic_xmit_pkts (tx_queue=0x7efabffcd5b0,
tx_pkts=0x7f10deffb1a8, nb_pkts=<optimized out>)
at /usr/src/debug/openvswitch-2.6.1/dpdk-16.11/drivers/net/enic/enic_rxtx.c:470
#5 0x00007f11e9e147ad in rte_eth_tx_burst (nb_pkts=<optimized out>,
tx_pkts=0x7f10deffb1a8, queue_id=0, port_id=<optimized out>)
This commit makes the enic wq driver match other drivers who call the
bulk free, by checking that there are actual packets to free.
Fixes:
36935afbc53c ("net/enic: refactor Tx mbuf recycling")
CC: stable@dpdk.org
Reported-by: Vincent S. Cojot <vcojot@redhat.com>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=
1468631
Signed-off-by: Aaron Conole <aconole@redhat.com>
Reviewed-by: John Daley <johndale@cisco.com>
Qi Zhang [Wed, 2 Aug 2017 07:22:09 +0000 (15:22 +0800)]
net/i40e: fix Rx data segment buffer length
Buffer length be configured for each data segment should not exceed
the requested value, or device may fill data that exceed the boundary
of memory that be reserved.
Fixes:
4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Reviewed-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Tested-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Gaetan Rivet [Thu, 3 Aug 2017 15:08:34 +0000 (17:08 +0200)]
net/failsafe: fix blank line parsing
When the output of an exec() slave definition is only a single newline
character, the fail-safe currently fails to parse the device with the
value returned by the rte_devargs library.
This behavior is incorrect, because the fail-safe should make a
difference between the absence of a device, and an erroneous device
declaration.
Fix the output sanitization in the case where no newline was at its end
and detect the special case of an absent device. The correct error code
is then returned.
Fixes:
a0194d828100 ("net/failsafe: add flexible device definition")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Raslan Darawsheh [Thu, 3 Aug 2017 13:09:58 +0000 (16:09 +0300)]
net/failsafe: fix missing pclose after popen
When there is no preferred device, failsafe will always
try to scan for preferred device. And if there is no device
found with the exec option, popen() will get an empty output.
In this case, it was forgotten to close the file descriptor.
It is fixed by closing the file descriptor even if the output is empty.
Coverity issue: 158633
Fixes:
a0194d828100 ("net/failsafe: add flexible device definition")
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Chas Williams [Mon, 24 Jul 2017 14:22:42 +0000 (10:22 -0400)]
net/vmxnet3: fix filtering on promiscuous disabling
We should only restore shadow_vfta when hw_vlan_filter is active.
Otherwise, we should restore the previous filtering behavior.
Fixes:
f003fc383487 ("vmxnet3: enable vlan filtering")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <ciwillia@brocade.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
Tiwei Bie [Tue, 1 Aug 2017 09:01:21 +0000 (17:01 +0800)]
vhost: make page logging atomic
Each dirty page logging operation should be atomic. But it's not
atomic in current implementation. So it's possible that some dirty
pages can't be logged successfully when different threads try to
log different pages into the same byte of the log buffer concurrently.
This patch fixes this issue.
Fixes:
b171fad1ffa5 ("vhost: log used vring changes")
Cc: stable@dpdk.org
Reported-by: Xiao Wang <xiao.w.wang@intel.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Gaetan Rivet [Thu, 3 Aug 2017 12:34:31 +0000 (14:34 +0200)]
eal: fix leak on hotplug parsing error
If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted
in the global list. When jumping to err_devarg, the removal fails and it
is not properly freed.
Free the allocated rte_devargs if its removal failed.
Coverity issue: 158658
Fixes:
7e8b26650146 ("eal: fix hotplug add / remove")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Gaetan Rivet [Thu, 3 Aug 2017 12:34:19 +0000 (14:34 +0200)]
eal: fix possible crash in hotplug
If devargs is NULL, building the full_dev_name will segfault
when using strlen on it.
Coverity issue: 158630
Fixes:
7e8b26650146 ("eal: fix hotplug add / remove")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Gaetan Rivet [Wed, 2 Aug 2017 17:12:07 +0000 (19:12 +0200)]
devargs: fix policy check when adding arguments
Do not fail upon detecting a set bus configuration when adding an
rte_devargs. i.e. adding a blacklisted PCI device while the bus is
configured in whitelist mode.
This failure condition has been introduced when the bus policies
were implemented. This implementation however was meant to strictly
follow the existing API. This check was not and should not be performed
until the current API has been properly deprecated.
The same kind of check is already done when parsing EAL options.
Fixes:
02823c1db0bc ("devargs: parse bus policies")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Gaetan Rivet [Wed, 2 Aug 2017 17:10:22 +0000 (19:10 +0200)]
eal: read and parse device option separately
When the EAL parses the common options given to the application,
not all subsystems are available. Some device drivers are registered
afterward upon dynamic plugin loading.
Devices using those drivers are thus unable to be parsed by any drivers
and are rejected.
Store the device options first and keep them for later processing.
Parse these right before initializing the buses, the drivers must have
been stabilized at this point.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Tested-by: Dirk-Holger Lenz <dirk.lenz@ng4t.com>
Thomas Monjalon [Tue, 11 Jul 2017 17:10:46 +0000 (19:10 +0200)]
pci: fix log level of scan summary on BSD
Printing the number of scanned devices should be a debug log,
not an error.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon [Thu, 3 Aug 2017 13:53:50 +0000 (15:53 +0200)]
doc: notify libnuma dependency in release notes
Fixes:
066731939589 ("doc: add libnuma as dependency")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon [Thu, 3 Aug 2017 13:44:48 +0000 (15:44 +0200)]
doc: notify x86 SSE4.2 requirement in release notes
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Harry van Haaren [Wed, 12 Jul 2017 13:38:52 +0000 (14:38 +0100)]
doc: add author on cc to git fixline alias
With this commit, the correct method to use git fixline to indicate
a fix of a previous commit has changed. The new rules require the
author of the original code that is being fixed to be on CC.
The logic behind this improvement is that if there is a genuine bug,
one of the ideal people to review is the author of the original code
being fixed. Adding them on Cc makes them aware of the patch, avoiding
it from being passed by accidentally while reading the mailing-list.
Given that the original author (now on Cc:) might not actually review,
there is no value in keeping the Cc: in git commit history. If the
original author performs a review, their Reviewed-by: or Acked-by: is
stored in git history (same as now).
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Sat, 15 Jul 2017 09:49:48 +0000 (11:49 +0200)]
devtools: speed up maintainers check
There is a huge speed improvement when forcing Unicode to be disabled
in this script.
In my test, it is improved from 13s to 6s.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Sat, 15 Jul 2017 10:00:33 +0000 (12:00 +0200)]
devtools: add script to find duplicated includes
Based on Stephen's idea (originally implemented in a Perl script),
this is a shell script to find duplicated includes in a file.
It looks for all the .c and .h files of the git repository.
It is fast enough because automatically well parallelized.
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Keith Wiles <keith.wiles@intel.com>
Thomas Monjalon [Mon, 31 Jul 2017 12:07:38 +0000 (14:07 +0200)]
devtools: ignore non merged tags for backport
When checking if a buggy commit was introduced in an old version,
the script compares last tag containing the bug and current version.
The non merged tags from non related branches must be ignored.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon [Mon, 31 Jul 2017 22:36:28 +0000 (00:36 +0200)]
version: 17.08-rc3
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Shahaf Shuler [Sun, 23 Jul 2017 10:23:09 +0000 (13:23 +0300)]
doc: postpone unaccomplished offloads deprecation
The work on ethdev Rx and Tx offloads has not been completed for 17.08.
It will be completed on 17.11
The notice is kept and postponed until the end of this work.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Shahaf Shuler [Sat, 29 Jul 2017 16:17:32 +0000 (19:17 +0300)]
doc: move i40e specific to i40e guide
The Linux Getting Started Guide contains
parts which are specific for i40e PMD. This results
in confusion for users which read the guide at their
first try with DPDK.
Moving those parts to the i40e NIC manual.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Shahaf Shuler [Sat, 29 Jul 2017 16:17:31 +0000 (19:17 +0300)]
doc: cleanup UIO hard requirement
UIO is not a must for all PMDs.
Cleaning up the Linux Getting Started Guide from this hard requirement.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Shahaf Shuler [Sat, 29 Jul 2017 16:17:30 +0000 (19:17 +0300)]
doc: move kernel drivers to a new chapter
The UIO and VFIO sections should not be part of
the "Compiling the DPDK Target from Source" chapter,
as it is PMD specific and not true for all PMDs.
Instead, moving those sections to a new chapter
which include all kernel drivers being used along with
the different PMDs.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Shahaf Shuler [Fri, 28 Jul 2017 14:28:33 +0000 (17:28 +0300)]
doc: update mlx guides
Update the guides with:
* New supported features.
* Supported OFED and FW versions.
* Quick start guide.
* Performance tunning guide.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Shahaf Shuler [Fri, 28 Jul 2017 14:28:32 +0000 (17:28 +0300)]
doc: update release notes for mlx driver
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Shahaf Shuler [Fri, 28 Jul 2017 14:28:31 +0000 (17:28 +0300)]
doc: update mlx5 supported features
Supported features which were not included:
* ARMv8
* Extended stats
Not supported features which were wrongly included:
* Inner L3 checksum
* Inner L4 checksum
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Gage Eads [Mon, 31 Jul 2017 21:49:51 +0000 (16:49 -0500)]
mk: use extra cflags when linking libs with compiler
When using the compiler to link libraries, include EXTRA_CFLAGS. This is
needed when cross-compiling to pass --sysroot, for example. GCC
cross-compilers built with Yocto don't use the --with-sysroot option,
making it necessary to pass the --sysroot command-line option.
This is the same solution as in commit
e8fbb6d9cfd9 ("mk: use extra cflags
when linking with compiler"), but applied to libs instead of apps.
Signed-off-by: Gage Eads <gage.eads@intel.com>
Rami Rosen [Fri, 28 Jul 2017 21:35:05 +0000 (00:35 +0300)]
ethdev: fix doxygen comment for PCI info copy
This trivial patch removes wrong comments about
the return value of the rte_eth_copy_pci_info() method.
The method return value type is void.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Wenzhuo Lu [Fri, 28 Jul 2017 18:55:58 +0000 (02:55 +0800)]
app/testpmd: fix usage message
There're '\n's missing, so the error prompt looks bad.
Fixes:
3af72783d1fd ("app/testpmd: configure event display")
Fixes:
7ee3e9446290 ("app/testpmd: add --flow-isolate-all option")
CC: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Pablo de Lara [Mon, 31 Jul 2017 04:40:37 +0000 (05:40 +0100)]
examples/l2fwd-crypto: fix possible out-of-bounds
rte_cryptodev_socket_id() returns the socket id of
a crypto device, unless the device id is not valid,
in which case, it returns -1.
This should not happen, as the device id is controlled
by the application, but just for safety, a check is added.
Coverity issue: 158628, 158638, 158656, 158662
Fixes:
b3bbd9e5f265 ("cryptodev: support device independent sessions")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Jerin Jacob [Mon, 31 Jul 2017 10:04:52 +0000 (15:34 +0530)]
app/testeventdev: fix divide by zero in stats
pkts == 0 will result in divide by zero case.
Added a check to fix it.
Coverity issue: 158652
Fixes:
9d3aeb185eb4 ("app/testeventdev: launch perf lcores")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Jerin Jacob [Mon, 31 Jul 2017 10:04:51 +0000 (15:34 +0530)]
app/testeventdev: fix string overflow in parsing
Coverity issue: 158660
Fixes:
4afd440ec132 ("app/testeventdev: update options through command line")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Harry van Haaren [Mon, 31 Jul 2017 16:38:55 +0000 (17:38 +0100)]
service: fix shifts to operate on 64-bit integers
This commit fixes shifts to an integer (1 << shift) which
is assumed to be a 32-bit integer. In this case, the shift is
variable and expected to be valid for 64-bit integers. Given that
the expectation to work with 64 bits exists, we must ensure that
the (1 << shift) one in that formula is actually a uin64_t.
The UINT64_C() macro portably adds the correct suffix to a constant,
informing the compiler that the value is to be assigned 64 bits.
The issue would only manifests when there were greater than 31
services registered.
Fixes:
21698354c832 ("service: introduce service cores concept")
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Wei Dai [Mon, 31 Jul 2017 18:12:11 +0000 (02:12 +0800)]
net/ixgbe: support 2.5G and 5G on X550
This patch adds support of 2.5G and 5G ethernet interface on X550.
Signed-off-by: Wei Dai <wei.dai@intel.com>
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Rasesh Mody [Mon, 24 Jul 2017 10:19:08 +0000 (03:19 -0700)]
net/qede: update PMD version 2.5.2.1
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Mon, 24 Jul 2017 10:19:07 +0000 (03:19 -0700)]
net/qede: fix chip details print
Fix chip details printed as part of print adapter info
Fixes:
2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Harish Patil [Mon, 24 Jul 2017 10:19:05 +0000 (03:19 -0700)]
net/qede: fix inner L3/L4 checksum for tunnels
Force recalculation of tunnel L4 chksum when inner L3/L4 chksum gets
updated due to HW offload.
Fixes:
aab21617502e ("net/qede: add Tx offloads for MPLS-in-UDP packets")
Signed-off-by: Harish Patil <harish.patil@cavium.com>
Rasesh Mody [Mon, 24 Jul 2017 10:19:04 +0000 (03:19 -0700)]
net/qede/base: fix for adapter specific stats
Handle different MAC statistic fields between two chip variants by
reading the MAC counters from the adapter suitable statistics bins.
Fixes:
ec94dbc57362 ("qede: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Harish Patil [Mon, 24 Jul 2017 10:19:03 +0000 (03:19 -0700)]
net/qede: fix incorrect queue id for 100G
'commit
4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")'
introduced a regression where default RSS configuration is incorrect in
the case of 100G mode. Currently we are passing absolute queue ids while
creating RX/TX queues. But in CMT mode we need to provide queue id
relative to the engine id. So this fix takes into account num_hwfns
while creating queues.
Fixes:
4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
Signed-off-by: Harish Patil <harish.patil@cavium.com>
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Rasesh Mody [Mon, 24 Jul 2017 10:19:02 +0000 (03:19 -0700)]
net/qede/base: fix recovery from previous ungraceful exit
This patch modifies the recovery flow to allow ongoing PCIe
transactions to be completed. To achieve this, the load sequence is
changed such that the "final_cleanup" notification is sent while the
FID_enable is cleared.
This change ensures that the chip cleanup actions takes place from
previous driver instance if needed.
Fixes:
ec94dbc57362 ("qede: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Ajit Khaparde [Mon, 31 Jul 2017 16:24:23 +0000 (11:24 -0500)]
net/bnxt: fix arguments to callback process
The callback arguments to _rte_eth_dev_callback_process() are swapped.
Fix them.
Fixes:
d6af1a13d7a1 ("ethdev: add return values to callback process API")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Matan Azrad [Mon, 31 Jul 2017 14:30:29 +0000 (17:30 +0300)]
net/mlx4: fix probe failure report
The corrupted code doesn't return error when probe function
fails due to error in device mac address getting.
By this way, the probe function may return success even if the
ETH dev is not allocated.
Hence, the probe caller, for example failsafe PMD, fails when it
tries to get ETH dev after the device was plugged out while mlx4
was probing it.
The fix adds error report to the probe caller when priv_get_mac fails
and in all other failure options which are missing it.
By this way, it prevents the unexpected behavior to miss ETH device
after the device was probed successfully.
Fixes:
7fae69eeff13 ("mlx4: new poll mode driver")
Fixes:
001a520e419f ("net/mlx4: add port parameter")
Fixes:
7b0661539229 ("mlx4: check if port is configured for ethernet")
Fixes:
fec3608673e6 ("mlx4: query netdevice to get initial MAC address")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Matan Azrad [Thu, 27 Jul 2017 10:27:24 +0000 (13:27 +0300)]
net/mlx4: fix flow creation before start
The corrupted code causes segmentation fault when user creates
flow with drop action before device starting.
For example, failsafe PMD recreates all the flows before calling
dev_start in plug-in sequence and mlx4 allocated its flow drop
queue in dev_start.
Hence, when failsafe created flow with drop action after plug-in
event, mlx4 tried to dereference flow drop queue which was
uninitialized.
The fix added check to the drop qp accessible and conditioned the
ibv_create_flow calling on device starting.
Fixes:
642fe56a1ba5 ("net/mlx4: use a single drop queue for all drop flows")
Fixes:
46d5736a7049 ("net/mlx4: support basic flow items and actions")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Yongseok Koh [Wed, 26 Jul 2017 19:29:33 +0000 (12:29 -0700)]
net/mlx5: fix L4 packet type support
TCP/UDP/NONFRAG/FRAG flags aren't counted for both outer and inner
header even though device supports it.
Fixes:
0603df73a077 ("net/mlx5: fix Rx packet validation and type")
Fixes:
6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Yongseok Koh [Wed, 26 Jul 2017 19:29:32 +0000 (12:29 -0700)]
net/mlx5: fix missing packet type calculation
Calculation of packet type is currently enabled only when HW checksum is
enabled.
This isn't related to HW checksum offload. Enable it regardless.
Fixes:
081f7eae242e ("mlx5: process offload flags only when requested")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Yongseok Koh [Tue, 25 Jul 2017 16:42:16 +0000 (09:42 -0700)]
net/mlx5: fix counting consumed Tx descriptors
When advancing Tx ring index (txq->wqe_ci) in txq_scatter_v(), the title
descriptor of multi-packet send isn't taken into account if it doesn't
cross 64B boundary.
Fixes:
6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Yongseok Koh [Thu, 20 Jul 2017 15:48:35 +0000 (08:48 -0700)]
net/mlx5: poll completion queue once per a call
mlx5_tx_complete() polls completion queue multiple times until it
encounters an invalid entry. As Tx completions are suppressed by
MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple
completions in a poll. And freeing too many buffers in a call can
cause high jitter.
This patch improves throughput a little.
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Daniel Mrzyglod [Thu, 27 Jul 2017 06:41:09 +0000 (08:41 +0200)]
doc: add 802.3ad modes in testpmd guide
Add testpmd commands for setting aggregators mode in mode 4 (IEEE802.3AD).
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Tomasz Kulasek [Wed, 26 Jul 2017 15:48:29 +0000 (17:48 +0200)]
test/bonding: fix device name
Bonding devices name must start with "net_bonding" prefix.
Fixes:
9bf4901d1a11 ("bus/vdev: remove probe with driver name option")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Daniel Mrzyglod [Wed, 26 Jul 2017 15:44:03 +0000 (17:44 +0200)]
test/bonding: fix namespace of the RSS tests
Drivers are looking by name of the device so change namespace to proper
one.
Fixes:
43b630244e7e ("app/test: add dynamic bonding RSS configuration")
Cc: stable@dpdk.org
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Herbert Guan [Thu, 13 Jul 2017 08:00:36 +0000 (16:00 +0800)]
test/bonding: fix parameters of a balance Tx
When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
should be toggled according to the test name.
Fixes:
92073ef961ee ("bond: unit tests")
Cc: stable@dpdk.org
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Herbert Guan [Mon, 10 Jul 2017 11:13:46 +0000 (19:13 +0800)]
test/bonding: fix memory corruptions
There were double-free problems in some test cases, which will cause
a duplicated mbuf will be added into mempool. After double-free,
some new allocated mbuf will hold a same address and thus cause the
memory corruption.
Another minor issue is that in some test cases, allocated mbuf will
not be released after test case exits. Hopefully these leaked mbuf
will be released by the next test case in its setup phase when
stopping the virtual pmd ports, while this do is a memory leak of
the exited test case.
To fix above 2 issues, this patch will do:
1) Release virtual pmd ports' tx queue in the clean up function
remove_slaves_and_stop_bonded_device() of each test cases.
2) Do not release allocated mbufs for test bursts. These mbufs
will be released in remove_slaves_and_stop_bonded_device() when
test case exits.
Fixes:
92073ef961ee ("bond: unit tests")
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Tomasz Kulasek [Wed, 26 Jul 2017 15:46:07 +0000 (17:46 +0200)]
test: fix virtual device name not set
Device name in device structure in virtual device used in
link_bonding_autotest is not set what causes segmentation fault when
rte_eth_dev_allocated is called.
Fixes:
a1e7c17555e8 ("ethdev: use device name from device structure")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Ajit Khaparde [Sat, 29 Jul 2017 20:54:09 +0000 (15:54 -0500)]
net/bnxt: fix setting conflicting VLAN bits
Only set the vlanonly bit if vlan_nonvlan is clear. Also, allow the
VLAN table to be cleared when vlanonly is set.
Clearing the VLAN table when vlanonly is set will stop all traffic
since it requires all frames to have a VLAN tag, and that tag to be
in the zero-length table. This is still a valid use case though,
and has been seen in the wild.
Fixes:
36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof")
Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Xiaoyun Li [Fri, 28 Jul 2017 15:48:11 +0000 (23:48 +0800)]
net/i40e: fix PF notify when VF is not up
This patch stops PF from sending messages to inactive VF
and modifies VF state to active when VF reset is completed.
Fixes:
4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Kuba Kozak [Thu, 27 Jul 2017 07:28:22 +0000 (09:28 +0200)]
net/i40e: fix parsing QinQ pattern
Add check if o_vlan_mask and i_vlan_mask are not a NULL pointer.
Coverity issue: 143448
Coverity issue: 143449
Fixes:
d37705068ee8 ("net/i40e: parse QinQ pattern")
Cc: stable@dpdk.org
Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Gowrishankar Muthukrishnan [Mon, 31 Jul 2017 12:54:27 +0000 (18:24 +0530)]
net/bonding: enable in ppc64le
Earlier bonding pmd was disabled in default config for ppc64le.
Hence, removing it as it has been verified.
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Tomasz Kulasek [Wed, 26 Jul 2017 15:53:30 +0000 (17:53 +0200)]
net/bonding: fix link status interrupt when down
RTE_ETH_EVENT_INTR_LSC callbacks are not called when all slaves goes down
in bond_ethdev_lsc_event_callback. It causes that link status change of
bonded device is not propagated up.
Fixes:
deba8a2f8b0b ("net/bonding: fix link properties management")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Tomasz Kulasek [Wed, 26 Jul 2017 15:50:48 +0000 (17:50 +0200)]
net/bonding: fix crash when primary slave set
rte_eth_bond_primary_set segfaults for invalid port. This patch moves
devices check before use of internal data.
Fixes:
4c42498d916d ("net/bonding: allow slaves to also be bonded devices")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
David Hunt [Mon, 24 Jul 2017 08:48:44 +0000 (09:48 +0100)]
net/i40e: fix sync phy type by adding retry
Some phy's take longer than others to come up. Add a retry to give
more phy's a chance to come up before returning an error.
Fixes:
2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus SFP")
Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Gowrishankar Muthukrishnan [Tue, 25 Jul 2017 13:38:07 +0000 (19:08 +0530)]
net/mlx5: fix inconsistent link status query
ETHTOOL_GLINKSETTINGS ioctl call in mlx5 pmd returns inconsistent
link status due to which any application relying on it would not
function correctly.
Fixes:
188408719888 ("net/mlx5: fix support for newer link speeds")
Cc: stable@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Kuba Kozak [Tue, 25 Jul 2017 12:19:25 +0000 (14:19 +0200)]
net/igb: fix access bound in ethertype filter
Fix wrong structure type used as argument in memset() call.
Coverity issue: 147223
Coverity issue: 147227
Fixes:
a8600af43738 ("net/igb: parse flow API ethertype filter")
Fixes:
22bb13410cb2 ("net/igb: create consistent filter")
Cc: stable@dpdk.org
Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Ajit Khaparde [Tue, 25 Jul 2017 03:32:23 +0000 (22:32 -0500)]
net/bnxt: fix setting VLAN anti spoof with same value
If the current VLAN anti spoof setting is same as the new value,
the firmware can return an error. Call the HWRM command to update
the new setting if it is different from the current value.
Fixes:
36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Leonid Myravjev [Fri, 21 Jul 2017 11:25:38 +0000 (11:25 +0000)]
net/ixgbe: remove subdev ids from PCI device table
The pci_id_ixgbe_map table has only PCI_ANY_ID for
.subvend and .subdev in all entries. Using of IXGBE_SUBDEV_ID_82599_SFP
for 'dev' is not correct. It generates the wrong PMD_INFO_STRING.
The output of the program "dpdk-pmdinfo.py" is confusing.
Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Wei Zhao [Thu, 20 Jul 2017 07:25:21 +0000 (15:25 +0800)]
net/ixgbe: support IPv4-other type filter
Add support for ipv4-other type in ntuple filter.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Qi Zhang [Fri, 21 Jul 2017 08:56:37 +0000 (16:56 +0800)]
net/ixgbe: fix mirror rule index overflow
Mirror rule id should not exceed the boundary defined by
IXGBE_MAX_MIRROR_RULES.
Fixes:
fe3a45fd4104 ("ixgbe: add VMDq support")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:33 +0000 (22:22 -0500)]
net/bnxt: free filter before reusing it
This patch sends the HWRM command to free a filter in the hardware,
before using it again.
Fixes:
f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:32 +0000 (22:22 -0500)]
net/bnxt: check invalid L2 filter id
Add code to check for invalid filter_id in bnxt_hwrm_clear_filter
Fixes:
f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:31 +0000 (22:22 -0500)]
net/bnxt: fix VLAN antispoof configuration code
We are wrongly using a Rx side HWRM command set_rx_mask to configure
VLAN anti-spoof. This being a Tx side feature, this patch
tries to fix it.
Since the HWRM command to do it is available only in
the newer firmware versions, the patch verifies the firmware
version before attempting to send the HWRM command to
the firmware.
Fixes:
36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof")
Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:30 +0000 (22:22 -0500)]
net/bnxt: reset VF stats during initialization
This patch resets the VF stats during initialization
Fixes:
b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:29 +0000 (22:22 -0500)]
net/bnxt: fix set link config
remove the unnecessary rte_delay in bnxt_set_hwrm_link_config
Fixes:
7bc8e9a227cc ("net/bnxt: support async link notification")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:28 +0000 (22:22 -0500)]
net/bnxt: fix vnic cleanup
Check if the vnic_id and rss_rule is not invalid before passing it
to the firmware to cleanup the VNIC. Log a message if the vnic_id
is invalid.
Fixes:
db678d5c2b54 ("net/bnxt: add HWRM VNIC configure")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:27 +0000 (22:22 -0500)]
net/bnxt: fix crash
Fix use of local variable to avoid segfault.
cnt was incorrectly tested and decremented in the loop that removes
a VLAN from the table.
Fixes:
36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof")
Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ajit Khaparde [Fri, 21 Jul 2017 03:22:26 +0000 (22:22 -0500)]
net/bnxt: fix log levels for non error conditions
1) handle_async_event is a DEBUG level log message.
2) Log "Unable to get default VNIC for VF %d" at INFO level.
Fixes:
36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof")
Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Jeff Guo [Fri, 21 Jul 2017 03:07:04 +0000 (11:07 +0800)]
net/i40e: fix link down and negotiation
Enable the functions set link down and set link up in i40e by check
phy_type, and fix the issue of auto negotiation failed in XXV710 when
bind kernel driver after unbind from DPDK driver by modify the speed
setting distinguish from set link up and down. With this fix, if unbind
DPDK to bind kernel driver, no need to set auto negotiation and ifconfig
up anymore, remove the part from doc.
Fixes:
ca7e599d4506 ("net/i40e: fix link management")
Fixes:
2f1e22817420 ("i40e: skip link control as firmware workaround")
Fixes:
6e145fcc754b ("i40e: support autoneg or force link speed")
Cc: stable@dpdk.org
Signed-off-by: Jeff Guo <jia.guo@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Wei Zhao [Thu, 20 Jul 2017 07:25:41 +0000 (15:25 +0800)]
net/ixgbe: fix 82599ES flow API port check
This NIC type port check should use port index
not mask for 82599ES.
Fixes:
d9347d254008 ("net/ixgbe: support 82599ES SCTP packet drop action")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Qi Zhang [Thu, 20 Jul 2017 08:19:50 +0000 (16:19 +0800)]
net/ixgbe: fix SCTP port support
Only x550 family support SCTP port in FDIR filter, so
add this limitation when parse consistent API.
Fixes:
11777435c727 ("net/ixgbe: parse flow director filter")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Wenzhuo Lu [Wed, 26 Jul 2017 14:43:39 +0000 (22:43 +0800)]
net/i40e: fix TM hierarchy commit check
If there's no Traffic Management node added. Not
necessary to check if TM is committed.
Fixes:
cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Wenzhuo Lu [Wed, 26 Jul 2017 14:54:13 +0000 (22:54 +0800)]
net/ixgbe: fix TM hierarchy commit check
If there's no Traffic Management node added,
not necessary to check if TM is committed.
Fixes:
5713ade69776 ("net/ixgbe: support committing TM hierarchy")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Jiayu Hu [Mon, 31 Jul 2017 07:56:44 +0000 (15:56 +0800)]
net/virtio: fix Rx interrupt setup
When use rte_eth_dev_configure() to enable rx queue interrupt for virtio
devices, virtio_init_device() isn't called to set up the interrupt
environment, which causes rx queue interrupt setup failed. This patch is
to fix this issue.
Fixes:
26b683b4f7d0 ("net/virtio: setup Rx queue interrupts")
Cc: stable@dpdk.org
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Jianfeng Tan [Fri, 28 Jul 2017 23:01:14 +0000 (23:01 +0000)]
net/virtio: fix MAC address read
When virtio-net devices are bound to uio_pci_generic, we get
the wrong mac addr by virtio PMD. The wrong mac addr is a
addr that is 4-byte left shift of the correct addr.
It's a regression bug introduced by the cleanup patch below.
The condition of if we set use_msix should be if msix is
actually enabled. Only to check if there is a capability list
is not enough. For example, binding a transitional device
to uio_pci_device would trigger the wrong assignment of use_msix.
To correct that, we also check the flags of msix capability to
make sure it's enabled.
Fixes:
ee1843bd8907 ("net/virtio: remove redundant MSI-X detection")
Cc: stable@dpdk.org
Reported-by: Vipin Varghese <vipin.varghese@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Pablo de Lara [Wed, 26 Jul 2017 04:20:05 +0000 (05:20 +0100)]
mbuf: fix doxygen comment of bulk alloc
When calling rte_pktmbuf_alloc_bulk, if there are
not enough objects in the mempool, it returns
a negative value, which should be reflected
in the Doxygen comments.
Fixes:
9ec201f5d6e7 ("mbuf: provide bulk allocation")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Zhiyong Yang [Fri, 28 Jul 2017 08:10:14 +0000 (16:10 +0800)]
ethdev: remove duplicate interrupt handle copy
The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
in the function rte_eth_copy_pci_info(), remove it here.
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Gaetan Rivet [Mon, 31 Jul 2017 13:40:07 +0000 (15:40 +0200)]
ethdev: fix invalid length write on detach
The name of a device is copied in a provided buffer within
rte_eth_dev_detach(). The current sizeof is done on a pointer instead of
the intended array usually pointed to.
The name field of an rte_device is not assured however to point an
rte_devargs name field. The almost correct length to base this copy over
is thus RTE_DEV_NAME_MAX_LEN.
Almost correct, because unfortunately this function does not allow the
user to pass down a size parameter for the buffer it is meant to write.
This API should be fixed, it is broken by design.
Fixes:
a1e7c17555e8 ("ethdev: use device name from device structure")
Cc: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Gaetan Rivet [Mon, 31 Jul 2017 12:58:29 +0000 (14:58 +0200)]
dev: fix vdev attach after PCI mismatch
If the device is a vdev, the parsing for PCI will fail with -EFAULT,
and will not try to check for a vdev.
Checking against error values returned by rte_eal_hotplug_add is
inelegant and prone to mistakes. Additionally, the failed PCI probe
prints a useless error that would throw off unsuspecting users:
ERROR: failed to parse device "pci:net_ring0"
This error is printed when attempting to probe a virtual device first
with the PCI bus (here, a net_ring0 device).
Use the relevant functions to infer the intended bus. The limitation to
PCI or vdev device is kept for strict API compatibility. Thus the PCI
probe attempt is avoided and the right function is directly called.
Fixes:
1c35f666df07 ("dev: fix attach proceeding with vdev on PCI success")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Matan Azrad [Mon, 24 Jul 2017 13:47:33 +0000 (16:47 +0300)]
ethdev: fix flow rule copy functions
The corrupted code checks only RAW flow item type special case for
returning its size but doesn't deal with any other flow item type
and returns 0 for all the others.
This bug leaves the flow descriptor empty for non RAW types.
The fix takes the correct size to any regular types from appropriate
array.
The same issue, with a similar fix, is in flow action size method
which deals only with RSS special type.
This bug was already present in the original code taken from testpmd.
Fixes:
18da437b5f63 ("ethdev: add flow rule copy function")
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Matan Azrad [Mon, 24 Jul 2017 13:47:32 +0000 (16:47 +0300)]
app/testpmd: fix flow rule copy functions
The corrupted code checks only RAW flow item type special case for
returning its size but doesn't deal with any other flow item type
and returns 0 for all the others.
This bug leaves the flow descriptor empty for non RAW types.
The fix takes the correct size to any regular types from appropriate
array.
The same issue, with a similar fix, is in flow action size method which
deals only with RSS special type.
Fixes:
938a184a1870 ("app/testpmd: implement basic support for flow API")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 13:35:56 +0000 (15:35 +0200)]
app/testpmd: add log on device detach failures
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 13:35:55 +0000 (15:35 +0200)]
net/mlx5: advertise the detach capability
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 13:35:54 +0000 (15:35 +0200)]
net/mlx4: advertise the detach capability
This PMD supports hotplug, it is able to be detached.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 13:35:53 +0000 (15:35 +0200)]
ethdev: remove useless check in detach capability
This capability is not bound to which driver is handling the device, but
whether the bus is able to unplug it.
This check is already performed in rte_eal_dev_detach, there is no need
to do it in the ethdev layer.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 13:35:52 +0000 (15:35 +0200)]
ethdev: fix device state on detach
The device state should be handled by the ethdev layer when possible.
Applications should not have to do it.
Not setting the state to UNUSED will make the port_id of the device
valid for all ethdev API functions, usually resulting in segfault.
Fixes:
284c908cc588 ("app/testpmd: request device removal interrupt")
Cc: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Tested-by: Shachar Beiser <shacharbe@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Gaetan Rivet [Wed, 26 Jul 2017 11:52:22 +0000 (13:52 +0200)]
dev: fix attach proceeding with vdev on PCI success
When rte_eal_hotplug_add() successfully probes a PCI device,
the return value is zero.
The check afterward only returns on error different from -EINVAL.
It should return also on success, as there is no need to
attempt probing the device with vdev.
Fixes:
0bba9e605048 ("eal: use new hotplug API in attach")
Cc: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Chas Williams [Sat, 22 Jul 2017 20:07:33 +0000 (16:07 -0400)]
log: get level for dynamic types
This function wasn't provided in the original commit.
Fixes:
4f0981e6ec6c ("eal: deprecate log functions")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <ciwillia@brocade.com>
Herbert Guan [Thu, 13 Jul 2017 02:16:42 +0000 (10:16 +0800)]
eal/arm64: fix poly64/128 compilation with GCC < 4.9
Use built-in data types for unsupported poly64/128 types
for GCC version lower than 4.9.0
Fixes:
3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
Cc: stable@dpdk.org
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
Jiayu Hu [Mon, 31 Jul 2017 01:43:24 +0000 (09:43 +0800)]
gro: fix bitwise overflow
When try to get GRO types, expression "1 << i" with type "int" may
overflow. This patch is to fix this issue.
Coverity issue: 158664
Fixes:
e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Hemant Agrawal [Mon, 24 Jul 2017 09:20:27 +0000 (14:50 +0530)]
eal: disable NUMA related warnings on non-NUMA systems
Disable multiple NUMA warnings on non-NUMA systems.
"EAL: eal_parse_sysfs_value(): cannot open sysfs value
/sys/bus/pci/devices/0000:00:00.0/numa_node
EAL: numa_node is invalid or not present. Set it 0 as default
EAL: cannot open /proc/self/numa_maps, consider that all memory is
in socket_id 0"
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Hemant Agrawal [Mon, 24 Jul 2017 07:23:49 +0000 (12:53 +0530)]
doc: update DPAA2 net PMD guide
added features, limitations and copyright.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Hemant Agrawal [Mon, 24 Jul 2017 07:23:48 +0000 (12:53 +0530)]
doc: add DPAA2 net PMD enhancements to release notes
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Hemant Agrawal [Mon, 24 Jul 2017 07:23:47 +0000 (12:53 +0530)]
doc: update DPAA2 eventdev extra path
The DPDK helper for NXP devices is not dpdk-extras
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Hemant Agrawal [Mon, 24 Jul 2017 07:23:46 +0000 (12:53 +0530)]
doc: add DPAA2 eventdev to release notes
announcing the addition of DPAA2 eventdev
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>